From swell.k@gmail.com  Sun Feb 27 22:55:16 2011
Return-Path: <swell.k@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 22E7E106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 27 Feb 2011 22:55:16 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50])
	by mx1.freebsd.org (Postfix) with ESMTP id ACCC48FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 27 Feb 2011 22:55:15 +0000 (UTC)
Received: by wwb31 with SMTP id 31so4323849wwb.31
        for <FreeBSD-gnats-submit@freebsd.org>; Sun, 27 Feb 2011 14:55:14 -0800 (PST)
Received: by 10.227.23.200 with SMTP id s8mr1113040wbb.196.1298847314026;
        Sun, 27 Feb 2011 14:55:14 -0800 (PST)
Received: from localhost (tor-exit-router36-readme.formlessnetworking.net [199.48.147.36])
        by mx.google.com with ESMTPS id o6sm2761295wbo.9.2011.02.27.14.55.11
        (version=SSLv3 cipher=OTHER);
        Sun, 27 Feb 2011 14:55:13 -0800 (PST)
Message-Id: <86ipw5xf3r.fsf@gmail.com>
Date: Mon, 28 Feb 2011 01:55:04 +0300
From: Anonymous <swell.k@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [zfs][patch] use /dev prefix by default when importing

>Number:         155104
>Category:       bin
>Synopsis:       [zfs][patch] use /dev prefix by default when importing
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-fs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 27 23:00:24 UTC 2011
>Closed-Date:    
>Last-Modified:  Sun Jan 19 10:50:00 UTC 2014
>Originator:     Anonymous
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
>Environment:
>Description:
Don't use Solaris prefix /dev/dsk when trying
zpool_{find,search}_import() without arguments.

cf. http://docs.freebsd.org/cgi/mid.cgi?86lj1s3pv0.fsf
>How-To-Repeat:
$ zdb -e tank
>Fix:
--- a.diff begins here ---
Index: cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
===================================================================
--- cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	(revision 219090)
+++ cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	(working copy)
@@ -1129,7 +1129,11 @@ zpool_find_import_impl(libzfs_handle_t *hdl, impor
 	char *end, **dir = iarg->path;
 	size_t pathleft;
 	nvlist_t *ret = NULL;
+#ifdef sun
 	static char *default_dir = "/dev/dsk";
+#else
+	static char *default_dir = "/dev";
+#endif
 	pool_list_t pools = { 0 };
 	pool_entry_t *pe, *penext;
 	vdev_entry_t *ve, *venext;
--- a.diff ends here ---
>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/155104: commit references a PR
Date: Tue, 15 May 2012 17:11:15 +0000 (UTC)

 Author: avg
 Date: Tue May 15 17:11:00 2012
 New Revision: 235479
 URL: http://svn.freebsd.org/changeset/base/235479
 
 Log:
   zpool_find_import_impl: another /dev/dsk -> /dev fix
   
   This seems to fix zdb -e behavior.
   
   PR:		bin/155104
   Submitted by:	swell.k@gmail.com
   MFC after:	2 weeks
 
 Modified:
   head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
 
 Modified: head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
 ==============================================================================
 --- head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Tue May 15 17:07:29 2012	(r235478)
 +++ head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Tue May 15 17:11:00 2012	(r235479)
 @@ -1145,7 +1145,7 @@ zpool_find_import_impl(libzfs_handle_t *
  	char *end, **dir = iarg->path;
  	size_t pathleft;
  	nvlist_t *ret = NULL;
 -	static char *default_dir = "/dev/dsk";
 +	static char *default_dir = "/dev";
  	pool_list_t pools = { 0 };
  	pool_entry_t *pe, *penext;
  	vdev_entry_t *ve, *venext;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/155104: commit references a PR
Date: Sat,  2 Jun 2012 18:57:01 +0000 (UTC)

 Author: avg
 Date: Sat Jun  2 18:56:41 2012
 New Revision: 236467
 URL: http://svn.freebsd.org/changeset/base/236467
 
 Log:
   MFC r235479: zpool_find_import_impl: another /dev/dsk -> /dev fix
   
   PR:		bin/155104
 
 Modified:
   stable/9/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
 Directory Properties:
   stable/9/cddl/contrib/opensolaris/   (props changed)
 
 Modified: stable/9/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
 ==============================================================================
 --- stable/9/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Sat Jun  2 18:55:25 2012	(r236466)
 +++ stable/9/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Sat Jun  2 18:56:41 2012	(r236467)
 @@ -1145,7 +1145,7 @@ zpool_find_import_impl(libzfs_handle_t *
  	char *end, **dir = iarg->path;
  	size_t pathleft;
  	nvlist_t *ret = NULL;
 -	static char *default_dir = "/dev/dsk";
 +	static char *default_dir = "/dev";
  	pool_list_t pools = { 0 };
  	pool_entry_t *pe, *penext;
  	vdev_entry_t *ve, *venext;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/155104: commit references a PR
Date: Sat,  2 Jun 2012 19:02:07 +0000 (UTC)

 Author: avg
 Date: Sat Jun  2 19:01:47 2012
 New Revision: 236471
 URL: http://svn.freebsd.org/changeset/base/236471
 
 Log:
   MFC r235479: zpool_find_import_impl: another /dev//dsk -> /dev fix
   
   PR:		bin/155104
 
 Modified:
   stable/8/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
 Directory Properties:
   stable/8/cddl/contrib/opensolaris/   (props changed)
 
 Modified: stable/8/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c
 ==============================================================================
 --- stable/8/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Sat Jun  2 18:59:18 2012	(r236470)
 +++ stable/8/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_import.c	Sat Jun  2 19:01:47 2012	(r236471)
 @@ -1145,7 +1145,7 @@ zpool_find_import_impl(libzfs_handle_t *
  	char *end, **dir = iarg->path;
  	size_t pathleft;
  	nvlist_t *ret = NULL;
 -	static char *default_dir = "/dev/dsk";
 +	static char *default_dir = "/dev";
  	pool_list_t pools = { 0 };
  	pool_entry_t *pe, *penext;
  	vdev_entry_t *ve, *venext;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: Anton Sayetsky <vsjcfm@gmail.com>
To: bug-followup@freebsd.org, swell.k@gmail.com
Cc:  
Subject: Re: bin/155104: [zfs][patch] use /dev prefix by default when importing
Date: Sun, 19 Jan 2014 12:45:17 +0200

 Why this PR is still open even when the commit was made a long time ago?
>Unformatted:
