From nobody@FreeBSD.org  Wed Jan 26 17:03:54 2011
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DFECC1065673
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 26 Jan 2011 17:03:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id D08618FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 26 Jan 2011 17:03:54 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p0QH3s7e079162
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 26 Jan 2011 17:03:54 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p0QH3sQh079161;
	Wed, 26 Jan 2011 17:03:54 GMT
	(envelope-from nobody)
Message-Id: <201101261703.p0QH3sQh079161@red.freebsd.org>
Date: Wed, 26 Jan 2011 17:03:54 GMT
From: Michael Moll <kvedulv@kvedulv.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: xz crashes on ARM
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         154310
>Category:       bin
>Synopsis:       [patch] xz(1) crashes on ARM
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    mm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 26 17:10:08 UTC 2011
>Closed-Date:    Tue Feb 08 15:43:31 UTC 2011
>Last-Modified:  Tue Feb 08 15:43:31 UTC 2011
>Originator:     Michael Moll
>Release:        CURRENT
>Organization:
>Environment:
FreeBSD deskstar.kvedulv.de 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r217665: Sat Jan 22 20:15:50 CET 2011     mmoll@emperor.kvedulv.de:/usr/obj/arm.arm/usr/current/src/sys/DESKSTAR  arm

>Description:
xz crashes on ARM (maybe also on other platforms).
>How-To-Repeat:

>Fix:
The attached patch implements an idea from http://lists.freebsd.org/pipermail/freebsd-arm/2010-September/002570.html and is not ARM specific.

Patch attached with submission follows:

Index: lib/liblzma/config.h
===================================================================
--- lib/liblzma/config.h	(revision 217884)
+++ lib/liblzma/config.h	(working copy)
@@ -66,7 +66,6 @@
 #define SIZEOF_SIZE_T 8
 #define STDC_HEADERS 1
 #define TUKLIB_CPUCORES_SYSCTL 1
-#define TUKLIB_FAST_UNALIGNED_ACCESS 1
 #define TUKLIB_PHYSMEM_SYSCONF 1
 #ifndef _ALL_SOURCE
 # define _ALL_SOURCE 1
@@ -86,6 +85,10 @@
 #define VERSION "5.0.0"
 #if defined(__FreeBSD__)
 #include <machine/endian.h>
+#include <machine/_types.h>
+#if __NO_STRICT_ALIGNMENT
+#define TUKLIB_FAST_UNALIGNED_ACCESS 1
+#endif
 #if _BYTE_ORDER == _BIG_ENDIAN
 # define WORDS_BIGENDIAN 1
 #endif


>Release-Note:
>Audit-Trail:

From: Michael Moll <kvedulv@kvedulv.de>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/154310: [patch] xz(1) crashes on ARM
Date: Mon, 31 Jan 2011 15:00:52 +0100

 Some further investigation shows that this was probably fixed in the
 past with r210103 but with the import of xz 5.0.0 (r215187) the
 according part was effectively reverted again.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/154310: commit references a PR
Date: Tue,  1 Feb 2011 10:28:10 +0000 (UTC)

 Author: mm
 Date: Tue Feb  1 10:28:05 2011
 New Revision: 218166
 URL: http://svn.freebsd.org/changeset/base/218166
 
 Log:
   Reintroduce bugfix from r210103 and fix xz on strong-aligned architectures.
   This fix was accidentially reverted with the 5.0.0 update in r215187.
   
   PR:		bin/154310
   Submitted by:	Michael Moll <kvedulv@kvedulv.de>
   MFC after:	3 days
 
 Modified:
   head/lib/liblzma/config.h
 
 Modified: head/lib/liblzma/config.h
 ==============================================================================
 --- head/lib/liblzma/config.h	Tue Feb  1 10:25:48 2011	(r218165)
 +++ head/lib/liblzma/config.h	Tue Feb  1 10:28:05 2011	(r218166)
 @@ -66,7 +66,6 @@
  #define SIZEOF_SIZE_T 8
  #define STDC_HEADERS 1
  #define TUKLIB_CPUCORES_SYSCTL 1
 -#define TUKLIB_FAST_UNALIGNED_ACCESS 1
  #define TUKLIB_PHYSMEM_SYSCONF 1
  #ifndef _ALL_SOURCE
  # define _ALL_SOURCE 1
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/154310: commit references a PR
Date: Sat,  5 Feb 2011 11:33:00 +0000 (UTC)

 Author: mm
 Date: Sat Feb  5 11:32:53 2011
 New Revision: 218317
 URL: http://svn.freebsd.org/changeset/base/218317
 
 Log:
   MFC r218166:
   
   Reintroduce bugfix from r210103 and fix xz on strong-aligned architectures.
   This fix was accidentially reverted with the 5.0.0 update in r215187.
   
   PR:		bin/154310
   Submitted by:	Michael Moll <kvedulv@kvedulv.de>
 
 Modified:
   stable/8/lib/liblzma/config.h
 Directory Properties:
   stable/8/lib/liblzma/   (props changed)
 
 Modified: stable/8/lib/liblzma/config.h
 ==============================================================================
 --- stable/8/lib/liblzma/config.h	Sat Feb  5 11:12:11 2011	(r218316)
 +++ stable/8/lib/liblzma/config.h	Sat Feb  5 11:32:53 2011	(r218317)
 @@ -66,7 +66,6 @@
  #define SIZEOF_SIZE_T 8
  #define STDC_HEADERS 1
  #define TUKLIB_CPUCORES_SYSCTL 1
 -#define TUKLIB_FAST_UNALIGNED_ACCESS 1
  #define TUKLIB_PHYSMEM_SYSCONF 1
  #ifndef _ALL_SOURCE
  # define _ALL_SOURCE 1
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/154310: commit references a PR
Date: Tue,  8 Feb 2011 15:05:52 +0000 (UTC)

 Author: mm
 Date: Tue Feb  8 15:05:47 2011
 New Revision: 218445
 URL: http://svn.freebsd.org/changeset/base/218445
 
 Log:
   MFC r218166:
   
   Reintroduce bugfix from r210103 and fix xz on strong-aligned architectures.
   This fix was accidentially reverted with the 5.0.0 update in r215187.
   
   PR:		bin/154310
   Submitted by:	Michael Moll <kvedulv@kvedulv.de>
   Approved by:	re (kensmith)
 
 Modified:
   releng/8.2/lib/liblzma/config.h
 Directory Properties:
   releng/8.2/lib/liblzma/   (props changed)
 
 Modified: releng/8.2/lib/liblzma/config.h
 ==============================================================================
 --- releng/8.2/lib/liblzma/config.h	Tue Feb  8 15:03:13 2011	(r218444)
 +++ releng/8.2/lib/liblzma/config.h	Tue Feb  8 15:05:47 2011	(r218445)
 @@ -66,7 +66,6 @@
  #define SIZEOF_SIZE_T 8
  #define STDC_HEADERS 1
  #define TUKLIB_CPUCORES_SYSCTL 1
 -#define TUKLIB_FAST_UNALIGNED_ACCESS 1
  #define TUKLIB_PHYSMEM_SYSCONF 1
  #ifndef _ALL_SOURCE
  # define _ALL_SOURCE 1
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
Responsible-Changed-From-To: freebsd-bugs->mm 
Responsible-Changed-By: mm 
Responsible-Changed-When: Tue Feb 8 15:43:11 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154310 
State-Changed-From-To: open->closed 
State-Changed-By: mm 
State-Changed-When: Tue Feb 8 15:43:30 UTC 2011 
State-Changed-Why:  
Fixed in head, releng/8 and releng/8.2. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=154310 
>Unformatted:
