From leres@ee.lbl.gov  Tue Jan  4 00:14:18 2011
Return-Path: <leres@ee.lbl.gov>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E5F31106564A
	for <freebsd-gnats-submit@freebsd.org>; Tue,  4 Jan 2011 00:14:18 +0000 (UTC)
	(envelope-from leres@ee.lbl.gov)
Received: from fun.ee.lbl.gov (fun.ee.lbl.gov [IPv6:2001:400:610:102::ca])
	by mx1.freebsd.org (Postfix) with ESMTP id CCE698FC08
	for <freebsd-gnats-submit@freebsd.org>; Tue,  4 Jan 2011 00:14:18 +0000 (UTC)
Received: from hot.ee.lbl.gov (hot.ee.lbl.gov [IPv6:2001:400:610:102::cb])
	(authenticated bits=0)
	by fun.ee.lbl.gov (8.14.4/8.14.4) with ESMTP id p040EFhs023560
	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO)
	for <freebsd-gnats-submit@freebsd.org>; Mon, 3 Jan 2011 16:14:15 -0800 (PST)
Message-Id: <4D226657.4010503@ee.lbl.gov>
Date: Mon, 03 Jan 2011 16:14:15 -0800
From: Craig Leres <leres@ee.lbl.gov>
To: freebsd-gnats-submit@freebsd.org
Subject: [PATCH] libexec/comsat/comsat.c: gratuitous newline

>Number:         153667
>Category:       bin
>Synopsis:       [PATCH] comsat(8): libexec/comsat/comsat.c: gratuitous newline
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 04 00:20:06 UTC 2011
>Closed-Date:    Sun Jul 03 07:27:26 UTC 2011
>Last-Modified:  Sun Jul 03 07:27:26 UTC 2011
>Originator:     Craig Leres
>Release:        FreeBSD 8.1-RELEASE amd64
>Organization:
Lawrence Berkeley National Laboratory
>Environment:
	FreeBSD hot.ee.lbl.gov 8.1-RELEASE FreeBSD 8.1-RELEASE #4 r8: Wed Dec 1
11:41:54 PST 2010
leres@ss.ee.lbl.gov:/usr/src/8.1-RELEASE/sys/amd64/compile/LBLSMPIPV6  amd64

>Description:
     There is a gratuitous newline in a debugging syslog format in
     comsat.c.

>How-To-Repeat:
>Fix:
 This is a multi-part message in MIME format.
 --------------020501070908030102000902
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
     Patch attached.
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.11 (FreeBSD)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
 
 iEYEARECAAYFAk0iZlcACgkQWxlAhAje3JvBywCfa8THYLpwQpfilZCu2wqCTFrr
 Br8AnRFqvVRt440vIE6npUZrbgnwVaAP
 =ey9S
 -----END PGP SIGNATURE-----
 
 --------------020501070908030102000902
 Content-Type: text/plain;
  name="patch-comsat.c"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="patch-comsat.c"
 
 --- comsat.c.virgin	2011-01-03 15:58:20.000000000 -0800
 +++ comsat.c	2011-01-03 16:05:36.000000000 -0800
 @@ -219,7 +219,7 @@
  		dsyslog(LOG_DEBUG, "%s: wrong mode on %s", utp->ut_name, tty);
  		return;
  	}
 -	dsyslog(LOG_DEBUG, "notify %s on %s\n", utp->ut_name, tty);
 +	dsyslog(LOG_DEBUG, "notify %s on %s", utp->ut_name, tty);
  	switch (fork()) {
  	case -1:
  		syslog(LOG_NOTICE, "fork failed (%m)");
 
 --------------020501070908030102000902
 Content-Type: application/octet-stream;
  name="patch-comsat.c.sig"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment;
  filename="patch-comsat.c.sig"
 
 iEYEABECAAYFAk0iZlcACgkQWxlAhAje3JuFdwCdGhXZi6VL+717wvA0/D38ouoyv+8An37g
 RRKs+7hxNzPLz927CL4BZMKe
 --------------020501070908030102000902--
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->jh 
Responsible-Changed-By: jh 
Responsible-Changed-When: Tue Jun 7 16:11:46 UTC 2011 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153667 
State-Changed-From-To: open->patched 
State-Changed-By: jh 
State-Changed-When: Tue Jun 7 16:25:29 UTC 2011 
State-Changed-Why:  
Patched in head (r222825). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153667 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/153667: commit references a PR
Date: Tue,  7 Jun 2011 16:23:40 +0000 (UTC)

 Author: jh
 Date: Tue Jun  7 16:23:27 2011
 New Revision: 222825
 URL: http://svn.freebsd.org/changeset/base/222825
 
 Log:
   Remove a gratuitous newline. This should be a non-functional change.
   
   PR:		bin/153667
   Submitted by:	Craig Leres
   MFC after:	1 week
 
 Modified:
   head/libexec/comsat/comsat.c
 
 Modified: head/libexec/comsat/comsat.c
 ==============================================================================
 --- head/libexec/comsat/comsat.c	Tue Jun  7 15:40:17 2011	(r222824)
 +++ head/libexec/comsat/comsat.c	Tue Jun  7 16:23:27 2011	(r222825)
 @@ -180,7 +180,7 @@ notify(struct utmpx *utp, char file[], o
  		dsyslog(LOG_DEBUG, "%s: wrong mode on %s", utp->ut_user, tty);
  		return;
  	}
 -	dsyslog(LOG_DEBUG, "notify %s on %s\n", utp->ut_user, tty);
 +	dsyslog(LOG_DEBUG, "notify %s on %s", utp->ut_user, tty);
  	switch (fork()) {
  	case -1:
  		syslog(LOG_NOTICE, "fork failed (%m)");
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/153667: commit references a PR
Date: Sun,  3 Jul 2011 07:15:14 +0000 (UTC)

 Author: jh
 Date: Sun Jul  3 07:14:48 2011
 New Revision: 223733
 URL: http://svn.freebsd.org/changeset/base/223733
 
 Log:
   MFC r222825: Remove a gratuitous newline.
   
   PR:		bin/153667
 
 Modified:
   stable/8/libexec/comsat/comsat.c
 Directory Properties:
   stable/8/libexec/comsat/   (props changed)
 
 Modified: stable/8/libexec/comsat/comsat.c
 ==============================================================================
 --- stable/8/libexec/comsat/comsat.c	Sat Jul  2 23:42:04 2011	(r223732)
 +++ stable/8/libexec/comsat/comsat.c	Sun Jul  3 07:14:48 2011	(r223733)
 @@ -219,7 +219,7 @@ notify(struct utmp *utp, char file[], of
  		dsyslog(LOG_DEBUG, "%s: wrong mode on %s", utp->ut_name, tty);
  		return;
  	}
 -	dsyslog(LOG_DEBUG, "notify %s on %s\n", utp->ut_name, tty);
 +	dsyslog(LOG_DEBUG, "notify %s on %s", utp->ut_name, tty);
  	switch (fork()) {
  	case -1:
  		syslog(LOG_NOTICE, "fork failed (%m)");
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/153667: commit references a PR
Date: Sun,  3 Jul 2011 07:17:11 +0000 (UTC)

 Author: jh
 Date: Sun Jul  3 07:16:59 2011
 New Revision: 223734
 URL: http://svn.freebsd.org/changeset/base/223734
 
 Log:
   MFC r222825: Remove a gratuitous newline.
   
   PR:		bin/153667
 
 Modified:
   stable/7/libexec/comsat/comsat.c
 Directory Properties:
   stable/7/libexec/comsat/   (props changed)
 
 Modified: stable/7/libexec/comsat/comsat.c
 ==============================================================================
 --- stable/7/libexec/comsat/comsat.c	Sun Jul  3 07:14:48 2011	(r223733)
 +++ stable/7/libexec/comsat/comsat.c	Sun Jul  3 07:16:59 2011	(r223734)
 @@ -215,7 +215,7 @@ notify(struct utmp *utp, char file[], of
  		dsyslog(LOG_DEBUG, "%s: wrong mode on %s", utp->ut_name, tty);
  		return;
  	}
 -	dsyslog(LOG_DEBUG, "notify %s on %s\n", utp->ut_name, tty);
 +	dsyslog(LOG_DEBUG, "notify %s on %s", utp->ut_name, tty);
  	if (fork())
  		return;
  	(void)signal(SIGALRM, SIG_DFL);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: jh 
State-Changed-When: Sun Jul 3 07:27:25 UTC 2011 
State-Changed-Why:  
Fixed in head, stable/8 and stable/7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153667 
>Unformatted:
