From mwlucas@bewilderbeast.blackhelicopters.org  Tue Dec 14 17:10:52 2010
Return-Path: <mwlucas@bewilderbeast.blackhelicopters.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 39C7F106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 14 Dec 2010 17:10:52 +0000 (UTC)
	(envelope-from mwlucas@bewilderbeast.blackhelicopters.org)
Received: from bewilderbeast.blackhelicopters.org (bewilderbeast.blackhelicopters.org [198.22.63.8])
	by mx1.freebsd.org (Postfix) with ESMTP id C74548FC13
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 14 Dec 2010 17:10:51 +0000 (UTC)
Received: from bewilderbeast.blackhelicopters.org (localhost [127.0.0.1])
	by bewilderbeast.blackhelicopters.org (8.14.4/8.14.4) with ESMTP id oBEGelKK041713
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 14 Dec 2010 11:40:47 -0500 (EST)
	(envelope-from mwlucas@bewilderbeast.blackhelicopters.org)
Received: (from mwlucas@localhost)
	by bewilderbeast.blackhelicopters.org (8.14.4/8.14.4/Submit) id oBEGelgh041712;
	Tue, 14 Dec 2010 11:40:47 -0500 (EST)
	(envelope-from mwlucas)
Message-Id: <201012141640.oBEGelgh041712@bewilderbeast.blackhelicopters.org>
Date: Tue, 14 Dec 2010 11:40:47 -0500 (EST)
From: Michael W Lucas <mwlucas@blackhelicopters.org>
Reply-To: Michael W Lucas <mwlucas@blackhelicopters.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: net-mgmt/bsnmp-ucd build fails
X-Send-Pr-Version: 3.113
X-GNATS-Notify: to.my.trociny@gmail.com

>Number:         153153
>Category:       bin
>Synopsis:       net-mgmt/bsnmp-ucd build fails
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    trociny
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 14 17:20:07 UTC 2010
>Closed-Date:    Tue Jan 03 21:10:14 UTC 2012
>Last-Modified:  Tue Jan 03 21:10:14 UTC 2012
>Originator:     Michael W Lucas
>Release:        FreeBSD 9.0-CURRENT amd64
>Organization:
n/a
>Environment:

FreeBSD ns5.domain.com 9.0-CURRENT FreeBSD 9.0-CURRENT #0: Mon Dec 13 22:45:25 EST 2010     mwlucas@ns5.domain.com:/usr/obj/usr/src/sys/GENERIC  amd64

freshly installed system, only LDAP ports installed

>Description:

make all install clean dies with:

libtool: compile:  cc -c -O2 -pipe -fno-strict-aliasing -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wbad-function-cast -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -std=c99 snmp_ucd.c  -fPIC -DPIC -o .libs/snmp_ucd.o
In file included from snmp_ucd.h:33,
                 from snmp_ucd.c:30:
/usr/include/bsnmp/snmpmod.h:359: error: expected specifier-qualifier-list before 'SLIST_ENTRY'
cc1: warnings being treated as errors
/usr/include/bsnmp/snmpmod.h:362: warning: data definition has no type or storage class
/usr/include/bsnmp/snmpmod.h:362: warning: parameter names (without types) in function declaration
/usr/include/bsnmp/snmpmod.h:386: error: expected specifier-qualifier-list before 'SLIST_ENTRY'
/usr/include/bsnmp/snmpmod.h:390: warning: data definition has no type or storage class
/usr/include/bsnmp/snmpmod.h:390: warning: parameter names (without types) in function declaration
/usr/include/bsnmp/snmpmod.h:390: warning: redundant redeclaration of 'SLIST_HEAD'
/usr/include/bsnmp/snmpmod.h:362: warning: previous declaration of 'SLIST_HEAD' was here
/usr/include/bsnmp/snmpmod.h:394: error: field 'group_users' has incomplete type
/usr/include/bsnmp/snmpmod.h:395: error: expected specifier-qualifier-list before 'SLIST_ENTRY'
/usr/include/bsnmp/snmpmod.h:398: warning: data definition has no type or storage class
/usr/include/bsnmp/snmpmod.h:398: warning: parameter names (without types) in function declaration
/usr/include/bsnmp/snmpmod.h:398: warning: redundant redeclaration of 'SLIST_HEAD'
/usr/include/bsnmp/snmpmod.h:390: warning: previous declaration of 'SLIST_HEAD' was here
/usr/include/bsnmp/snmpmod.h:412: error: expected specifier-qualifier-list before 'TAILQ_ENTRY'
/usr/include/bsnmp/snmpmod.h:415: warning: data definition has no type or storage class
/usr/include/bsnmp/snmpmod.h:415: warning: parameter names (without types) in function declaration
/usr/include/bsnmp/snmpmod.h:424: error: expected specifier-qualifier-list before 'SLIST_ENTRY'
/usr/include/bsnmp/snmpmod.h:427: warning: data definition has no type or storage class
/usr/include/bsnmp/snmpmod.h:427: warning: parameter names (without types) in function declaration
/usr/include/bsnmp/snmpmod.h:427: warning: redundant redeclaration of 'SLIST_HEAD'
/usr/include/bsnmp/snmpmod.h:398: warning: previous declaration of 'SLIST_HEAD' was here
/usr/include/bsnmp/snmpmod.h:433: error: expected specifier-qualifier-list before 'SLIST_ENTRY'
/usr/include/bsnmp/snmpmod.h:436: warning: data definition has no type or storage class
/usr/include/bsnmp/snmpmod.h:436: warning: parameter names (without types) in function declaration
/usr/include/bsnmp/snmpmod.h:436: warning: redundant redeclaration of 'SLIST_HEAD'
/usr/include/bsnmp/snmpmod.h:427: warning: previous declaration of 'SLIST_HEAD' was here
*** Error code 1

Stop in /tmp/ports/usr/ports/net-mgmt/bsnmp-ucd/work/bsnmp-ucd-0.3.2.
*** Error code 1



>How-To-Repeat:

cd /usr/ports/net-mgmt/bsnmp-ucd
make all install clean

>Fix:




>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Dec 14 17:20:14 UTC 2010 
State-Changed-Why:  
Awaiting maintainers feedback (via the GNATS Auto Assign Tool) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153153 

From: Edwin Groothuis <edwin@FreeBSD.org>
To: to.my.trociny@gmail.com
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/153153: net-mgmt/bsnmp-ucd build fails
Date: Tue, 14 Dec 2010 17:20:11 UT

 Maintainer of net-mgmt/bsnmp-ucd,
 
 Please note that PR ports/153153 has just been submitted.
 
 If it contains a patch for an upgrade, an enhancement or a bug fix
 you agree on, reply to this email stating that you approve the patch
 and a committer will take care of it.
 
 The full text of the PR can be found at:
     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153153
 
 -- 
 Edwin Groothuis via the GNATS Auto Assign Tool
 edwin@FreeBSD.org

From: Mikolaj Golub <to.my.trociny@gmail.com>
To: bug-followup@FreeBSD.org
Cc: Michael W Lucas <mwlucas@blackhelicopters.org>, Shteryana Shopova <syrinx@FreeBSD.org>
Subject: Re: ports/153153: net-mgmt/bsnmp-ucd build fails
Date: Tue, 14 Dec 2010 22:44:46 +0200

 --=-=-=
 
 This rather looks like an issue with bsnmp.
 
 Shteryana, could you please look at the attached patch?
 
 -- 
 Mikolaj Golub
 
 
 --=-=-=
 Content-Type: text/x-patch
 Content-Disposition: inline; filename=snmpmod.h.patch
 
 Index: contrib/bsnmp/snmpd/snmpmod.h
 ===================================================================
 --- contrib/bsnmp/snmpd/snmpmod.h	(revision 216439)
 +++ contrib/bsnmp/snmpd/snmpmod.h	(working copy)
 @@ -33,6 +33,7 @@
  #ifndef snmpmod_h_
  #define snmpmod_h_
  
 +#include <sys/queue.h>
  #include <sys/types.h>
  #include <sys/socket.h>
  #include <net/if.h>
 
 --=-=-=--
Responsible-Changed-From-To: freebsd-ports-bugs->syrinx 
Responsible-Changed-By: arved 
Responsible-Changed-When: Tue Dec 28 13:39:40 UTC 2010 
Responsible-Changed-Why:  
PR contains patch for bsnmp. 

Over to bsnmp maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153153 

From: Mikolaj Golub <to.my.trociny@gmail.com>
To: bug-followup@FreeBSD.org
Cc: mwlucas@blackhelicopters.org, syrinx@freebsd.org
Subject: Re: bin/153153: net-mgmt/bsnmp-ucd build fails
Date: Fri, 18 Mar 2011 00:50:39 +0200

 --=-=-=
 
 A as a workaround bsnmp-ucd can be patched. See the attached patch.
 -- 
 Mikolaj Golub
 
 
 --=-=-=
 Content-Disposition: attachment; filename=bsnmp-ucd.port.patch.txt
 
 diff -rpu net-mgmt/bsnmp-ucd.orig/Makefile net-mgmt/bsnmp-ucd/Makefile
 --- net-mgmt/bsnmp-ucd.orig/Makefile	2011-03-17 23:47:55.056447025 +0200
 +++ net-mgmt/bsnmp-ucd/Makefile	2011-03-18 00:43:16.680805913 +0200
 @@ -7,6 +7,7 @@
  
  PORTNAME=	bsnmp-ucd
  PORTVERSION=	0.3.2
 +PORTREVISION=	1
  CATEGORIES=	net-mgmt
  MASTER_SITES=	${MASTER_SITE_GOOGLE_CODE}
  
 @@ -18,6 +19,9 @@ USE_AUTOTOOLS=	libtool:env
  
  MAN8=		bsnmp-ucd.8
  
 +post-patch:
 +	${REINPLACE_CMD} -e '32,32 s/^.*/#include <sys\/queue.h>/' ${WRKSRC}/snmp_ucd.h
 +
  .include <bsd.port.pre.mk>
  
  .if ${OSVERSION} < 601000
 
 --=-=-=--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/153153: commit references a PR
Date: Thu, 17 Mar 2011 23:35:38 +0000 (UTC)

 pav         2011-03-17 23:35:25 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-mgmt/bsnmp-ucd   Makefile 
   Log:
   - Fix build on -CURRENT
   
   PR:             ports/153153
   Submitted by:   Mikolaj Golub <to.my.trociny@gmail.com> (maintainer)
   
   Revision  Changes    Path
   1.11      +3 -6      ports/net-mgmt/bsnmp-ucd/Makefile
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
Responsible-Changed-From-To: syrinx->trociny 
Responsible-Changed-By: trociny 
Responsible-Changed-When: Sun Dec 11 17:09:35 UTC 2011 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153153 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/153153: commit references a PR
Date: Sun, 11 Dec 2011 17:10:47 +0000 (UTC)

 Author: trociny
 Date: Sun Dec 11 17:10:33 2011
 New Revision: 228411
 URL: http://svn.freebsd.org/changeset/base/228411
 
 Log:
   Include sys/queue.h: snmpmod.h uses TAILQ.
   
   PR:		bin/153153
   MFC after:	2 weeks
 
 Modified:
   head/contrib/bsnmp/snmpd/snmpmod.h
 
 Modified: head/contrib/bsnmp/snmpd/snmpmod.h
 ==============================================================================
 --- head/contrib/bsnmp/snmpd/snmpmod.h	Sun Dec 11 16:57:27 2011	(r228410)
 +++ head/contrib/bsnmp/snmpd/snmpmod.h	Sun Dec 11 17:10:33 2011	(r228411)
 @@ -40,6 +40,7 @@
  #define snmpmod_h_
  
  #include <sys/types.h>
 +#include <sys/queue.h>
  #include <sys/socket.h>
  #include <net/if.h>
  #include <netinet/in.h>
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: feedback->patched 
State-Changed-By: trociny 
State-Changed-When: Sun Dec 11 18:33:57 UTC 2011 
State-Changed-Why:  


http://www.freebsd.org/cgi/query-pr.cgi?pr=153153 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/153153: commit references a PR
Date: Tue,  3 Jan 2012 20:53:36 +0000 (UTC)

 Author: trociny
 Date: Tue Jan  3 20:53:16 2012
 New Revision: 229426
 URL: http://svn.freebsd.org/changeset/base/229426
 
 Log:
   MFC r228411:
   
   Include sys/queue.h: snmpmod.h uses TAILQ.
   
   PR:		bin/153153
 
 Modified:
   stable/9/contrib/bsnmp/snmpd/snmpmod.h
 Directory Properties:
   stable/9/contrib/bsnmp/   (props changed)
 
 Modified: stable/9/contrib/bsnmp/snmpd/snmpmod.h
 ==============================================================================
 --- stable/9/contrib/bsnmp/snmpd/snmpmod.h	Tue Jan  3 20:53:07 2012	(r229425)
 +++ stable/9/contrib/bsnmp/snmpd/snmpmod.h	Tue Jan  3 20:53:16 2012	(r229426)
 @@ -40,6 +40,7 @@
  #define snmpmod_h_
  
  #include <sys/types.h>
 +#include <sys/queue.h>
  #include <sys/socket.h>
  #include <net/if.h>
  #include <netinet/in.h>
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: trociny 
State-Changed-When: Tue Jan 3 21:06:54 UTC 2012 
State-Changed-Why:  
The fix has been merged to stable/9. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=153153 
>Unformatted:
