From citrin@citrin.ru  Thu Dec  2 15:29:49 2010
Return-Path: <citrin@citrin.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D075C10656A4
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  2 Dec 2010 15:29:49 +0000 (UTC)
	(envelope-from citrin@citrin.ru)
Received: from mail.vega.ru (mail.vega.ru [90.156.167.5])
	by mx1.freebsd.org (Postfix) with ESMTP id 847758FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  2 Dec 2010 15:29:49 +0000 (UTC)
Received: from monitoring.int.vega.ru ([10.25.1.153])
	by mail.vega.ru with esmtps (TLSv1:AES256-SHA:256)
	(Exim 4.72 (FreeBSD))
	(envelope-from <citrin@citrin.ru>)
	id 1POB6R-000G1I-CZ
	for FreeBSD-gnats-submit@freebsd.org; Thu, 02 Dec 2010 18:29:47 +0300
Received: from monitoring.int.vega.ru (monitoring.int.vega.ru [10.25.1.153])
	by monitoring.int.vega.ru (8.14.4/8.14.4) with ESMTP id oB2FTlCD065858
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 2 Dec 2010 15:29:47 GMT
	(envelope-from citrin@citrin.ru)
Received: (from ayuzhaninov@localhost)
	by monitoring.int.vega.ru (8.14.4/8.14.4/Submit) id oB2FTlx9065857;
	Thu, 2 Dec 2010 15:29:47 GMT
	(envelope-from citrin@citrin.ru)
Message-Id: <201012021529.oB2FTlx9065857@monitoring.int.vega.ru>
Date: Thu, 2 Dec 2010 15:29:47 GMT
From: Anton Yuzhaninov <citrin@citrin.ru>
Reply-To: Anton Yuzhaninov <citrin@citrin.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] decode semget(2) flags in kdump(1)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         152781
>Category:       bin
>Synopsis:       [patch] decode semget(2) flags in kdump(1)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Dec 02 15:30:14 UTC 2010
>Closed-Date:    Fri Dec 17 19:49:23 UTC 2010
>Last-Modified:  Fri Dec 17 19:50:09 UTC 2010
>Originator:     Anton Yuzhaninov
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
Openstat.ru
>Environment:
System: FreeBSD citrin.office.vega.ru 9.0-CURRENT FreeBSD 9.0-CURRENT #2 r215543M: Mon Nov 22 19:38:30 MSK 2010 root@citrin.office.vega.ru:/usr/obj/usr/src/sys/NK i386
>Description:
kdump(1) decode falgs in syscalls aguments, but decode not all semget(2) flags.
>How-To-Repeat:

1. Run code
semget(IPC_PRIVATE, 3, IPC_CREAT | IPC_EXCL | SEM_R | SEM_A);
semget(IPC_PRIVATE, 3, SEM_R | SEM_A);
under ktrace(1)

2.
> kdump -n | fgrep semget
 87823 a.out    CALL  semget(0,0x3,0x780)
 87823 a.out    RET   semget 0x60000
 87823 a.out    CALL  semget(0,0x3,0x180)
 87823 a.out    RET   semget 0x30001
kdump -n show 2 semget(2) syscall with differend flags, all right.

> kdump | fgrep semget
 87823 a.out    CALL  semget(0,0x3,SEM_R|SEM_A)
 87823 a.out    RET   semget 393216/0x60000
 87823 a.out    CALL  semget(0,0x3,SEM_R|SEM_A)
 87823 a.out    RET   semget 196609/0x30001

Whitout -n same flags shown - it is a bug.

Whith attached path correct flags shown:
> kdump | fgrep semget
 87823 a.out    CALL  semget(0,0x3,IPC_CREAT|IPC_EXCL|SEM_R|SEM_A)
 87823 a.out    RET   semget 393216/0x60000
 87823 a.out    CALL  semget(0,0x3,SEM_R|SEM_A)
 87823 a.out    RET   semget 196609/0x30001

>Fix:
--- mksubr.patch begins here ---
Index: usr.bin/kdump/mksubr
===================================================================
--- usr.bin/kdump/mksubr	(revision 216121)
+++ usr.bin/kdump/mksubr	(working copy)
@@ -254,6 +254,8 @@
 void
 semgetname (int flag) {
 	int	or = 0;
+	if_print_or(flag, IPC_CREAT, or);
+	if_print_or(flag, IPC_EXCL, or);
 	if_print_or(flag, SEM_R, or);
 	if_print_or(flag, SEM_A, or);
 	if_print_or(flag, (SEM_R>>3), or);
--- mksubr.patch ends here ---

>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/152781: commit references a PR
Date: Thu,  2 Dec 2010 18:24:28 +0000 (UTC)

 Author: delphij
 Date: Thu Dec  2 18:24:22 2010
 New Revision: 216130
 URL: http://svn.freebsd.org/changeset/base/216130
 
 Log:
   Decode IPC_CREAT and IPC_EXCL for semget(2).
   
   PR:		bin/152781
   Submitted by:	Anton Yuzhaninov <citrin citrin ru>
   MFC after:	2 weeks
 
 Modified:
   head/usr.bin/kdump/mksubr
 
 Modified: head/usr.bin/kdump/mksubr
 ==============================================================================
 --- head/usr.bin/kdump/mksubr	Thu Dec  2 18:01:18 2010	(r216129)
 +++ head/usr.bin/kdump/mksubr	Thu Dec  2 18:24:22 2010	(r216130)
 @@ -254,6 +254,8 @@ shmctlname (int cmd) {
  void
  semgetname (int flag) {
  	int	or = 0;
 +	if_print_or(flag, IPC_CREAT, or);
 +	if_print_or(flag, IPC_EXCL, or);
  	if_print_or(flag, SEM_R, or);
  	if_print_or(flag, SEM_A, or);
  	if_print_or(flag, (SEM_R>>3), or);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: delphij 
State-Changed-When: Thu Dec 2 18:43:10 UTC 2010 
State-Changed-Why:  
Patch applied against -CURRENT, MFC reminder. 


Responsible-Changed-From-To: freebsd-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Thu Dec 2 18:43:10 UTC 2010 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152781 
State-Changed-From-To: patched->closed 
State-Changed-By: delphij 
State-Changed-When: Fri Dec 17 19:49:03 UTC 2010 
State-Changed-Why:  
MFC'ed to 8-STABLE, thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152781 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/152781: commit references a PR
Date: Fri, 17 Dec 2010 19:49:02 +0000 (UTC)

 Author: delphij
 Date: Fri Dec 17 19:48:54 2010
 New Revision: 216506
 URL: http://svn.freebsd.org/changeset/base/216506
 
 Log:
   MFC r216130:
   
   Decode IPC_CREAT and IPC_EXCL for semget(2).
   
   PR:		bin/152781
   Submitted by:	Anton Yuzhaninov <citrin citrin ru>
   Approved by:	re (kib)
 
 Modified:
   stable/8/usr.bin/kdump/mksubr
 Directory Properties:
   stable/8/usr.bin/kdump/   (props changed)
 
 Modified: stable/8/usr.bin/kdump/mksubr
 ==============================================================================
 --- stable/8/usr.bin/kdump/mksubr	Fri Dec 17 18:22:50 2010	(r216505)
 +++ stable/8/usr.bin/kdump/mksubr	Fri Dec 17 19:48:54 2010	(r216506)
 @@ -252,6 +252,8 @@ shmctlname (int cmd) {
  void
  semgetname (int flag) {
  	int	or = 0;
 +	if_print_or(flag, IPC_CREAT, or);
 +	if_print_or(flag, IPC_EXCL, or);
  	if_print_or(flag, SEM_R, or);
  	if_print_or(flag, SEM_A, or);
  	if_print_or(flag, (SEM_R>>3), or);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
