From rfg@tristatelogic.com  Thu Nov 11 05:54:17 2010
Return-Path: <rfg@tristatelogic.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3E8DB106566B
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Nov 2010 05:54:17 +0000 (UTC)
	(envelope-from rfg@tristatelogic.com)
Received: from outgoing.tristatelogic.com (segfault.tristatelogic.com [69.62.255.118])
	by mx1.freebsd.org (Postfix) with ESMTP id 20A388FC18
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Nov 2010 05:54:16 +0000 (UTC)
Received: by segfault.tristatelogic.com (Postfix, from userid 1237)
	id 20E8BBDC35; Wed, 10 Nov 2010 21:54:15 -0800 (PST)
Message-Id: <20101111055415.20E8BBDC35@segfault.tristatelogic.com>
Date: Wed, 10 Nov 2010 21:54:15 -0800 (PST)
From: Ronald F.Guilmette <rfg@tristatelogic.com>
Reply-To: Ronald F.Guilmette <rfg@tristatelogic.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Useless code in script.c (part 1)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         152131
>Category:       bin
>Synopsis:       script(1): [patch] Useless code in script.c (part 1)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 11 06:00:22 UTC 2010
>Closed-Date:    Sat May 11 22:59:04 UTC 2013
>Last-Modified:  Sat May 11 22:59:04 UTC 2013
>Originator:     Ronald F. Guilmette
>Release:        FreeBSD 7.0-RELEASE i386
>Organization:
Infinite Monkeys & Co.
>Environment:
System: FreeBSD segfault.tristatelogic.com 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Tue Aug 5 02:38:40 PDT 2008 root@segfault.monkeys.com:/usr/src/sys/i386/compile/rfg20080805 i386

>Description:
	script.c does pointless zero-length writes to its child (shell)
	process.  Also, an EOF on stdin should probably terminate everything.

>How-To-Repeat:
	Look at the code.
>Fix:

*** script.c.orig	2004-02-15 09:30:13.000000000 -0800
--- script.c	2010-11-10 21:49:21.000000000 -0800
***************
*** 179,186 ****
  		if (n > 0 && FD_ISSET(STDIN_FILENO, &rfd)) {
  			cc = read(STDIN_FILENO, ibuf, BUFSIZ);
! 			if (cc < 0)
  				break;
- 			if (cc == 0)
- 				(void)write(master, ibuf, 0);
  			if (cc > 0) {
  				(void)write(master, ibuf, cc);
--- 179,184 ----
  		if (n > 0 && FD_ISSET(STDIN_FILENO, &rfd)) {
  			cc = read(STDIN_FILENO, ibuf, BUFSIZ);
! 			if (cc <= 0)
  				break;
  			if (cc > 0) {
  				(void)write(master, ibuf, cc);
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Sat May 11 22:59:02 UTC 2013 
State-Changed-Why:  
it seems this was fixed a long time ago, the patch applies now, but in 
reverse ;) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=152131 
>Unformatted:
