From nobody@FreeBSD.org  Fri Oct  8 19:00:46 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CA7A81065675
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Oct 2010 19:00:46 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id BAA698FC22
	for <freebsd-gnats-submit@FreeBSD.org>; Fri,  8 Oct 2010 19:00:46 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o98J0kjt024644
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 8 Oct 2010 19:00:46 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o98J0k3V024643;
	Fri, 8 Oct 2010 19:00:46 GMT
	(envelope-from nobody)
Message-Id: <201010081900.o98J0k3V024643@www.freebsd.org>
Date: Fri, 8 Oct 2010 19:00:46 GMT
From: Simon Walton <simonw@matteworld.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: mount_nfs won't recognize readahead
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         151321
>Category:       bin
>Synopsis:       mount_nfs(8) won't recognize readahead
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    jh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 08 19:10:04 UTC 2010
>Closed-Date:    Sun Nov 27 11:35:35 UTC 2011
>Last-Modified:  Sun Nov 27 11:35:35 UTC 2011
>Originator:     Simon Walton
>Release:        8.1
>Organization:
>Environment:
FreeBSD mongo 8.1-RELEASE FreeBSD 8.1-RELEASE #1: Thu Oct  7 18:25:36 PDT 2010
>Description:
Mount_nfs won't recognize any form of the readahead parameter:

mongo# mount_nfs -a 2 m-6:/mnt/dodo /cdrom
-a deprecated, use -o readhead=<value>
mount_nfs: /cdrom, mount option <readahead> is unknown: Invalid argument
mongo# mount_nfs -o readahead=2 m-6:/mnt/dodo /cdrom
mount_nfs: /cdrom, mount option <readahead> is unknown: Invalid argument
mongo# mount_nfs -o readhead=2 m-6:/mnt/dodo /cdrom
mount_nfs: /cdrom, mount option <readhead> is unknown: Invalid argument

The mount operation is unsuccessful in all cases.

In previous releases this option was a significant performance increase
for us.

>How-To-Repeat:
mount_nfs -o readahead=2 ...

>Fix:


>Release-Note:
>Audit-Trail:

From: Jaakko Heinonen <jh@FreeBSD.org>
To: Simon Walton <simonw@matteworld.com>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/151321: mount_nfs won't recognize readahead
Date: Sun, 10 Oct 2010 14:35:20 +0300

 Hi,
 
 On 2010-10-08, Simon Walton wrote:
 > mongo# mount_nfs -a 2 m-6:/mnt/dodo /cdrom
 > -a deprecated, use -o readhead=<value>
 > mount_nfs: /cdrom, mount option <readahead> is unknown: Invalid argument
 > mongo# mount_nfs -o readahead=2 m-6:/mnt/dodo /cdrom
 > mount_nfs: /cdrom, mount option <readahead> is unknown: Invalid argument
 > mongo# mount_nfs -o readhead=2 m-6:/mnt/dodo /cdrom
 > mount_nfs: /cdrom, mount option <readhead> is unknown: Invalid argument
 > 
 > The mount operation is unsuccessful in all cases.
 
 Could you try this patch?
 
 %%%
 Index: sys/nfsclient/nfs_vfsops.c
 ===================================================================
 --- sys/nfsclient/nfs_vfsops.c	(revision 213666)
 +++ sys/nfsclient/nfs_vfsops.c	(working copy)
 @@ -777,10 +777,10 @@ static const char *nfs_opts[] = { "from"
      "noatime", "noexec", "suiddir", "nosuid", "nosymfollow", "union",
      "noclusterr", "noclusterw", "multilabel", "acls", "force", "update",
      "async", "dumbtimer", "noconn", "nolockd", "intr", "rdirplus", "resvport",
 -    "readdirsize", "soft", "hard", "mntudp", "tcp", "udp", "wsize", "rsize",
 -    "retrans", "acregmin", "acregmax", "acdirmin", "acdirmax", 
 -    "deadthresh", "hostname", "timeout", "addr", "fh", "nfsv3", "sec",
 -    "maxgroups", "principal", "negnametimeo",
 +    "readdirsize", "readahead", "soft", "hard", "mntudp", "tcp", "udp",
 +    "wsize", "rsize", "retrans", "acregmin", "acregmax", "acdirmin",
 +    "acdirmax", "deadthresh", "hostname", "timeout", "addr", "fh",
 +    "nfsv3", "sec", "maxgroups", "principal", "negnametimeo",
      NULL };
  
  /*
 %%%
 
 -- 
 Jaakko
State-Changed-From-To: open->feedback 
State-Changed-By: jh 
State-Changed-When: Tue Oct 19 15:07:51 UTC 2010 
State-Changed-Why:  
Note that submitter has been asked for feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151321 

From: Simon Walton <simonw@matteworld.com>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
Cc:  
Subject: Re: bin/151321: mount_nfs won't recognize readahead
Date: Tue, 26 Oct 2010 09:50:51 -0700

 Thanks. The patch works fine - both the -a and -o readahead forms
 of the option mount the filesys.
 
 For completeness I guess the mount_nfs warning should say
 "use -o readahead=<value>" instead of "use -o readhead=<value>".
 
 Simon
 
State-Changed-From-To: feedback->open 
State-Changed-By: jh 
State-Changed-When: Tue Oct 26 18:05:01 UTC 2010 
State-Changed-Why:  
Feedback received. 


Responsible-Changed-From-To: freebsd-bugs->jh 
Responsible-Changed-By: jh 
Responsible-Changed-When: Tue Oct 26 18:05:01 UTC 2010 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151321 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/151321: commit references a PR
Date: Wed, 27 Oct 2010 14:08:43 +0000 (UTC)

 Author: jh
 Date: Wed Oct 27 14:08:37 2010
 New Revision: 214418
 URL: http://svn.freebsd.org/changeset/base/214418
 
 Log:
   Add missing "readahead" to the nfs_opts list.
   
   PR:		151321
   Tested by:	Simon Walton
   MFC after:	2 weeks
 
 Modified:
   head/sys/nfsclient/nfs_vfsops.c
 
 Modified: head/sys/nfsclient/nfs_vfsops.c
 ==============================================================================
 --- head/sys/nfsclient/nfs_vfsops.c	Wed Oct 27 13:38:40 2010	(r214417)
 +++ head/sys/nfsclient/nfs_vfsops.c	Wed Oct 27 14:08:37 2010	(r214418)
 @@ -779,10 +779,10 @@ static const char *nfs_opts[] = { "from"
      "noatime", "noexec", "suiddir", "nosuid", "nosymfollow", "union",
      "noclusterr", "noclusterw", "multilabel", "acls", "force", "update",
      "async", "dumbtimer", "noconn", "nolockd", "intr", "rdirplus", "resvport",
 -    "readdirsize", "soft", "hard", "mntudp", "tcp", "udp", "wsize", "rsize",
 -    "retrans", "acregmin", "acregmax", "acdirmin", "acdirmax", 
 -    "deadthresh", "hostname", "timeout", "addr", "fh", "nfsv3", "sec",
 -    "maxgroups", "principal", "negnametimeo",
 +    "readahead", "readdirsize", "soft", "hard", "mntudp", "tcp", "udp",
 +    "wsize", "rsize", "retrans", "acregmin", "acregmax", "acdirmin",
 +    "acdirmax", "deadthresh", "hostname", "timeout", "addr", "fh", "nfsv3",
 +    "sec", "maxgroups", "principal", "negnametimeo",
      NULL };
  
  /*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/151321: commit references a PR
Date: Wed, 27 Oct 2010 14:11:17 +0000 (UTC)

 Author: jh
 Date: Wed Oct 27 14:11:11 2010
 New Revision: 214419
 URL: http://svn.freebsd.org/changeset/base/214419
 
 Log:
   Correct a typo.
   
   PR:		151321
   Submitted by:	Simon Walton
   MFC after:	3 days
 
 Modified:
   head/sbin/mount_nfs/mount_nfs.c
 
 Modified: head/sbin/mount_nfs/mount_nfs.c
 ==============================================================================
 --- head/sbin/mount_nfs/mount_nfs.c	Wed Oct 27 14:08:37 2010	(r214418)
 +++ head/sbin/mount_nfs/mount_nfs.c	Wed Oct 27 14:11:11 2010	(r214419)
 @@ -177,7 +177,7 @@ main(int argc, char *argv[])
  			mountmode = V3;
  			break;
  		case 'a':
 -			printf("-a deprecated, use -o readhead=<value>\n");
 +			printf("-a deprecated, use -o readahead=<value>\n");
  			build_iovec(&iov, &iovlen, "readahead", optarg, (size_t)-1);
  			break;
  		case 'b':
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->feedback 
State-Changed-By: jh 
State-Changed-When: Wed Oct 27 14:27:45 UTC 2010 
State-Changed-Why:  
Fixed in head (r214418 and r214419). Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151321 
State-Changed-From-To: feedback->patched 
State-Changed-By: jh 
State-Changed-When: Wed Oct 27 14:33:01 UTC 2010 
State-Changed-Why:  
Correct the state. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151321 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/151321: commit references a PR
Date: Mon,  1 Nov 2010 06:19:49 +0000 (UTC)

 Author: jh
 Date: Mon Nov  1 06:19:44 2010
 New Revision: 214619
 URL: http://svn.freebsd.org/changeset/base/214619
 
 Log:
   MFC r214419: Correct a typo.
   
   PR:		151321
 
 Modified:
   stable/8/sbin/mount_nfs/mount_nfs.c
 Directory Properties:
   stable/8/sbin/mount_nfs/   (props changed)
 
 Modified: stable/8/sbin/mount_nfs/mount_nfs.c
 ==============================================================================
 --- stable/8/sbin/mount_nfs/mount_nfs.c	Mon Nov  1 06:17:02 2010	(r214618)
 +++ stable/8/sbin/mount_nfs/mount_nfs.c	Mon Nov  1 06:19:44 2010	(r214619)
 @@ -177,7 +177,7 @@ main(int argc, char *argv[])
  			mountmode = V3;
  			break;
  		case 'a':
 -			printf("-a deprecated, use -o readhead=<value>\n");
 +			printf("-a deprecated, use -o readahead=<value>\n");
  			build_iovec(&iov, &iovlen, "readahead", optarg, (size_t)-1);
  			break;
  		case 'b':
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/151321: commit references a PR
Date: Wed, 10 Nov 2010 17:17:46 +0000 (UTC)

 Author: jh
 Date: Wed Nov 10 17:17:38 2010
 New Revision: 215091
 URL: http://svn.freebsd.org/changeset/base/215091
 
 Log:
   MFC r214418: Add missing "readahead" to the nfs_opts list.
   
   PR:		151321
 
 Modified:
   stable/8/sys/nfsclient/nfs_vfsops.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
   stable/8/sys/dev/xen/xenpci/   (props changed)
 
 Modified: stable/8/sys/nfsclient/nfs_vfsops.c
 ==============================================================================
 --- stable/8/sys/nfsclient/nfs_vfsops.c	Wed Nov 10 16:42:36 2010	(r215090)
 +++ stable/8/sys/nfsclient/nfs_vfsops.c	Wed Nov 10 17:17:38 2010	(r215091)
 @@ -779,10 +779,10 @@ static const char *nfs_opts[] = { "from"
      "noatime", "noexec", "suiddir", "nosuid", "nosymfollow", "union",
      "noclusterr", "noclusterw", "multilabel", "acls", "force", "update",
      "async", "dumbtimer", "noconn", "nolockd", "intr", "rdirplus", "resvport",
 -    "readdirsize", "soft", "hard", "mntudp", "tcp", "udp", "wsize", "rsize",
 -    "retrans", "acregmin", "acregmax", "acdirmin", "acdirmax", 
 -    "deadthresh", "hostname", "timeout", "addr", "fh", "nfsv3", "sec",
 -    "maxgroups", "principal", "negnametimeo",
 +    "readahead", "readdirsize", "soft", "hard", "mntudp", "tcp", "udp",
 +    "wsize", "rsize", "retrans", "acregmin", "acregmax", "acdirmin",
 +    "acdirmax", "deadthresh", "hostname", "timeout", "addr", "fh", "nfsv3",
 +    "sec", "maxgroups", "principal", "negnametimeo",
      NULL };
  
  /*
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: jh 
State-Changed-When: Sun Nov 27 11:35:34 UTC 2011 
State-Changed-Why:  
Fixed in head, stable/9 and stable/8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=151321 
>Unformatted:
