From culot@0xd0.org  Mon Sep 27 12:30:57 2010
Return-Path: <culot@0xd0.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4A4FD106566C
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Sep 2010 12:30:57 +0000 (UTC)
	(envelope-from culot@0xd0.org)
Received: from 0xd0.org (0xd0.org [91.121.92.146])
	by mx1.freebsd.org (Postfix) with ESMTP id E2D388FC18
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Sep 2010 12:30:56 +0000 (UTC)
Received: from 0xd0.org (doudou.0xd0.org [172.16.0.254])
	by 0xd0.org (8.14.4/8.14.4) with ESMTP id o8RCUC5P015449
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 27 Sep 2010 14:30:12 +0200 (CEST)
	(envelope-from culot@0xd0.org)
Received: (from culot@localhost)
	by 0xd0.org (8.14.4/8.14.4/Submit) id o8RCUBEA015448;
	Mon, 27 Sep 2010 14:30:11 +0200 (CEST)
	(envelope-from culot)
Message-Id: <201009271230.o8RCUBEA015448@0xd0.org>
Date: Mon, 27 Sep 2010 14:30:11 +0200 (CEST)
From: Frederic Culot <frederic@culot.org>
Reply-To: Frederic Culot <frederic@culot.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: top(1): mention 'jid' as a possible sort order
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         150992
>Category:       bin
>Synopsis:       [patch] top(1): mention 'jid' as a possible sort order
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pluknet
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 27 12:40:01 UTC 2010
>Closed-Date:    Wed Nov 17 09:51:35 UTC 2010
>Last-Modified:  Wed Nov 17 09:51:35 UTC 2010
>Originator:     Frederic Culot
>Release:        FreeBSD 8.1-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD 0xd0.org 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:36:49 UTC 2010 root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
Sorting by jail ID is supported by top(1) but not mentioned when user
presses '?' to obtain online help screen.
The attached patch adds the 'jid' possible sort order to this help screen.
>How-To-Repeat:
>Fix:
--- /usr/src/contrib/top/commands.c.bak	2010-09-27 14:14:55.000000000 +0200
+++ /usr/src/contrib/top/commands.c	2010-09-27 14:15:14.000000000 +0200
@@ -80,7 +80,7 @@
 #ifdef ORDER
 	if (displaymode == DISP_CPU)
 		fputs("\
-o       - specify sort order (pri, size, res, cpu, time, threads)\n", stdout);
+o       - specify sort order (pri, size, res, cpu, time, threads, jid)\n", stdout);
 	else
 		fputs("\
 o       - specify sort order (vcsw, ivcsw, read, write, fault, total)\n", stdout);
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->pluknet 
Responsible-Changed-By: pluknet 
Responsible-Changed-When: Fri Nov 12 16:43:44 UTC 2010 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150992 
State-Changed-From-To: open->patched 
State-Changed-By: pluknet 
State-Changed-When: Fri Nov 12 16:53:31 UTC 2010 
State-Changed-Why:  
Fixed in HEAD with a minor change. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150992 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/150992: commit references a PR
Date: Fri, 12 Nov 2010 16:50:16 +0000 (UTC)

 Author: pluknet
 Date: Fri Nov 12 16:50:11 2010
 New Revision: 215186
 URL: http://svn.freebsd.org/changeset/base/215186
 
 Log:
   Add 'jid' as a possible sort order to the help screen.
   
   PR:		bin/150992
   Submitted by:	Frederic Culot <frederic at culot dot org>
   Approved by:	avg (mentor)
   MFC after:	5 days
 
 Modified:
   head/contrib/top/commands.c
 
 Modified: head/contrib/top/commands.c
 ==============================================================================
 --- head/contrib/top/commands.c	Fri Nov 12 15:52:27 2010	(r215185)
 +++ head/contrib/top/commands.c	Fri Nov 12 16:50:11 2010	(r215186)
 @@ -80,10 +80,12 @@ n or #  - change number of processes to 
  #ifdef ORDER
  	if (displaymode == DISP_CPU)
  		fputs("\
 -o       - specify sort order (pri, size, res, cpu, time, threads)\n", stdout);
 +o       - specify sort order (pri, size, res, cpu, time, threads, jid)\n",
 +	    stdout);
  	else
  		fputs("\
 -o       - specify sort order (vcsw, ivcsw, read, write, fault, total)\n", stdout);
 +o       - specify sort order (vcsw, ivcsw, read, write, fault, total, jid)\n",
 +	    stdout);
  #endif
  	fputs("\
  r       - renice a process\n\
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/150992: commit references a PR
Date: Wed, 17 Nov 2010 09:48:25 +0000 (UTC)

 Author: pluknet
 Date: Wed Nov 17 09:48:18 2010
 New Revision: 215421
 URL: http://svn.freebsd.org/changeset/base/215421
 
 Log:
   MFC r215186:
   
   Add 'jid' as a possible sort order to the help screen.
   
   PR:		bin/150992
   Submitted by:	Frederic Culot <frederic at culot dot org>
   Approved by:	avg (mentor)
 
 Modified:
   stable/8/contrib/top/commands.c
 Directory Properties:
   stable/8/contrib/top/   (props changed)
   stable/8/contrib/top/install-sh   (props changed)
 
 Modified: stable/8/contrib/top/commands.c
 ==============================================================================
 --- stable/8/contrib/top/commands.c	Wed Nov 17 09:32:39 2010	(r215420)
 +++ stable/8/contrib/top/commands.c	Wed Nov 17 09:48:18 2010	(r215421)
 @@ -80,10 +80,12 @@ n or #  - change number of processes to 
  #ifdef ORDER
  	if (displaymode == DISP_CPU)
  		fputs("\
 -o       - specify sort order (pri, size, res, cpu, time, threads)\n", stdout);
 +o       - specify sort order (pri, size, res, cpu, time, threads, jid)\n",
 +	    stdout);
  	else
  		fputs("\
 -o       - specify sort order (vcsw, ivcsw, read, write, fault, total)\n", stdout);
 +o       - specify sort order (vcsw, ivcsw, read, write, fault, total, jid)\n",
 +	    stdout);
  #endif
  	fputs("\
  r       - renice a process\n\
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/150992: commit references a PR
Date: Wed, 17 Nov 2010 09:49:55 +0000 (UTC)

 Author: pluknet
 Date: Wed Nov 17 09:49:51 2010
 New Revision: 215422
 URL: http://svn.freebsd.org/changeset/base/215422
 
 Log:
   MFC r215186:
   
   Add 'jid' as a possible sort order to the help screen.
   
   PR:		bin/150992
   Submitted by:	Frederic Culot <frederic at culot dot org>
   Approved by:	avg (mentor)
 
 Modified:
   stable/7/contrib/top/commands.c
 Directory Properties:
   stable/7/contrib/top/   (props changed)
 
 Modified: stable/7/contrib/top/commands.c
 ==============================================================================
 --- stable/7/contrib/top/commands.c	Wed Nov 17 09:48:18 2010	(r215421)
 +++ stable/7/contrib/top/commands.c	Wed Nov 17 09:49:51 2010	(r215422)
 @@ -80,10 +80,12 @@ n or #  - change number of processes to 
  #ifdef ORDER
  	if (displaymode == DISP_CPU)
  		fputs("\
 -o       - specify sort order (pri, size, res, cpu, time, threads)\n", stdout);
 +o       - specify sort order (pri, size, res, cpu, time, threads, jid)\n",
 +	    stdout);
  	else
  		fputs("\
 -o       - specify sort order (vcsw, ivcsw, read, write, fault, total)\n", stdout);
 +o       - specify sort order (vcsw, ivcsw, read, write, fault, total, jid)\n",
 +	    stdout);
  #endif
  	fputs("\
  r       - renice a process\n\
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: pluknet 
State-Changed-When: Wed Nov 17 09:51:02 UTC 2010 
State-Changed-Why:  
Merged to 8 and 7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=150992 
>Unformatted:
