From nobody@FreeBSD.org  Wed Jun 30 18:54:31 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7FE43106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Jun 2010 18:54:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6FDFE8FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Jun 2010 18:54:31 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o5UIsV6r041367
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Jun 2010 18:54:31 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o5UIsV3H041352;
	Wed, 30 Jun 2010 18:54:31 GMT
	(envelope-from nobody)
Message-Id: <201006301854.o5UIsV3H041352@www.freebsd.org>
Date: Wed, 30 Jun 2010 18:54:31 GMT
From: Josh Paetzel <jpaetzel@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
Subject: sysinstall creats partitions of the wrong size
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         148266
>Category:       bin
>Synopsis:       sysinstall(8) creates partitions of the wrong size
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brucec
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun 30 19:00:20 UTC 2010
>Closed-Date:    Thu Jul 22 17:37:18 UTC 2010
>Last-Modified:  Thu Jul 22 17:40:02 UTC 2010
>Originator:     Josh Paetzel
>Release:        9.0-20100629 amd64
>Organization:
iXsystems
>Environment:
FreeBSD  9.0-20100629-SNAP FreeBSD 9.0-20100629-SNAP #0: Tue Jun 29 15:30:02 UTC 2010     root@ix.tcbug.org:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
Installing from an ISO created with make release from 2010-06-29, in the sysinstall partition editor, if you use G to specify a partition size, then any subsequent partitions created with the number of blocks for the size use the previous partition's size.

I discovered this by installing a box with a 1G /, 2G swap, 2G /tmp, 2G /var and then using the default number of blocks for /usr, and ended up with a 2G
/usr.  My initial reaction to this was I had typod in using sysinstall (The disk filled up in use and that's when I discovered I had a 2G /usr) but after trying a reinstall I discovered it's actually caused by sysinstall using the wrong size.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->brucec  
Responsible-Changed-By: brucec 
Responsible-Changed-When: Mon Jul 5 04:00:53 UTC 2010 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148266 
State-Changed-From-To: open->closed  
State-Changed-By: brucec 
State-Changed-When: Thu Jul 22 17:36:13 UTC 2010 
State-Changed-Why:  
Fixed in r210381. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=148266 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/148266: commit references a PR
Date: Thu, 22 Jul 2010 17:35:45 +0000 (UTC)

 Author: brucec
 Date: Thu Jul 22 17:35:36 2010
 New Revision: 210381
 URL: http://svn.freebsd.org/changeset/base/210381
 
 Log:
   If a size suffix isn't entered, just use the value entered. This fixes
   a bug caused by r209235 where entering a number of blocks after
   previously entering a size in MB/GB would result in the size of the
   previous partition being used.
   
   PR:	bin/148266
   Submitted by:	jpaetzel
   Approved by:	rrs (mentor)
 
 Modified:
   head/usr.sbin/sysinstall/label.c
 
 Modified: head/usr.sbin/sysinstall/label.c
 ==============================================================================
 --- head/usr.sbin/sysinstall/label.c	Thu Jul 22 17:23:43 2010	(r210380)
 +++ head/usr.sbin/sysinstall/label.c	Thu Jul 22 17:35:36 2010	(r210381)
 @@ -1036,7 +1036,10 @@ diskLabel(Device *dev)
  #endif
  		    else
  			size = (daddr_t) dsize;
 +		} else {
 +			size = (daddr_t) dsize;
  		}
 +
  		if (size < FS_MIN_SIZE) {
  		    msgConfirm("The minimum filesystem size is %dMB", FS_MIN_SIZE / ONE_MEG);
  		    clear_wins();
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
