From nobody@FreeBSD.org  Fri Jun 18 19:28:36 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8865A1065674
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 18 Jun 2010 19:28:36 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 778E48FC15
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 18 Jun 2010 19:28:36 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o5IJSa6A027182
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 18 Jun 2010 19:28:36 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o5IJSail027181;
	Fri, 18 Jun 2010 19:28:36 GMT
	(envelope-from nobody)
Message-Id: <201006181928.o5IJSail027181@www.freebsd.org>
Date: Fri, 18 Jun 2010 19:28:36 GMT
From: Nicholas Mills <nlmills@g.clemson.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] sysinstall(8): sysinstall crashes when installing new distributions
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         147980
>Category:       bin
>Synopsis:       [patch] sysinstall(8): sysinstall crashes when installing new distributions
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    brucec
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 18 19:30:06 UTC 2010
>Closed-Date:    Fri Jun 25 10:44:27 UTC 2010
>Last-Modified:  Fri Jun 25 10:44:27 UTC 2010
>Originator:     Nicholas Mills
>Release:        8.1-RC1
>Organization:
>Environment:
FreeBSD freebsd.localdomain 8.1-RC1 FreeBSD 8.1-RC1 #0: Mon Jun 14 14:44:53 UTC 2010    root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC    i386
>Description:
Sysinstall crashes when attempting to install a new distribution over the network. The crash occurs right after selecting "Yes" to the "Running multi-user, assume that the network is already configured?" screen.
>How-To-Repeat:
Run sysinstall on a freshly-installed system. Attempt to install any distribution over the network and select "Yes" to the "Running multi-user, assume that the network is already configured?" screen.
>Fix:
This crash occurs when tcpip.c:tcpDeviceSelect references uninitialized data. The solution is to initialize the data to a default value (see attached patch).

Patch attached with submission follows:

--- tcpip.c.old	2010-06-05 20:19:28.000000000 -0400
+++ tcpip.c	2010-06-05 20:19:11.000000000 -0400
@@ -732,6 +732,9 @@
 	return (NULL);
     }
 
+    devs = deviceFind(NULL, DEVICE_TYPE_NETWORK);
+    cnt = deviceCount(devs); 
+
     if ((!RunningAsInit) && (variable_check("NETWORK_CONFIGURED=NO") != TRUE)) {
 	if (!msgYesNo("Running multi-user, assume that the network is already configured?"))
 	    return devs[0];


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->brucec  
Responsible-Changed-By: brucec 
Responsible-Changed-When: Fri Jun 25 00:59:43 UTC 2010 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147980 

From: Garrett Cooper <yanefbsd@gmail.com>
To: bug-followup@FreeBSD.org, nlmills@g.clemson.edu
Cc: Randi Harper <randi@freebsd.org>
Subject: Re: bin/147980: [patch] sysinstall(8): sysinstall crashes when 
	installing new distributions
Date: Thu, 24 Jun 2010 19:34:49 -0700

 Wasn't this already fixed in 8.1 and 8-STABLE?
 Thanks,
 -Garrett

From: Randi Harper <randi@freebsd.org>
To: Garrett Cooper <yanefbsd@gmail.com>
Cc: bug-followup@freebsd.org, nlmills@g.clemson.edu
Subject: Re: bin/147980: [patch] sysinstall(8): sysinstall crashes when 
	installing new distributions
Date: Thu, 24 Jun 2010 20:03:49 -0700

 Yes. It was MFCed at about the same time that the bug was filed.
 
 -- randi
 
 
 
 On Thu, Jun 24, 2010 at 7:34 PM, Garrett Cooper <yanefbsd@gmail.com> wrote:
 > Wasn't this already fixed in 8.1 and 8-STABLE?
 > Thanks,
 > -Garrett
 >
State-Changed-From-To: open->closed  
State-Changed-By: brucec 
State-Changed-When: Fri Jun 25 10:43:52 UTC 2010 
State-Changed-Why:  
Fixed in 8.1 and head. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147980 
>Unformatted:
