From alex323@gmail.com  Tue Jun 15 19:22:32 2010
Return-Path: <alex323@gmail.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A5F631065672
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Jun 2010 19:22:32 +0000 (UTC)
	(envelope-from alex323@gmail.com)
Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 58B848FC16
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Jun 2010 19:22:31 +0000 (UTC)
Received: by vws20 with SMTP id 20so7273283vws.13
        for <FreeBSD-gnats-submit@freebsd.org>; Tue, 15 Jun 2010 12:22:31 -0700 (PDT)
Received: by 10.220.89.142 with SMTP id e14mr4091321vcm.194.1276628136810;
        Tue, 15 Jun 2010 11:55:36 -0700 (PDT)
Received: from localhost (ool-44c14b8e.dyn.optonline.net [68.193.75.142])
        by mx.google.com with ESMTPS id c4sm6224665vcb.44.2010.06.15.11.55.35
        (version=TLSv1/SSLv3 cipher=RC4-MD5);
        Tue, 15 Jun 2010 11:55:35 -0700 (PDT)
Message-Id: <20100615145533.020e2090@gmail.com>
Date: Tue, 15 Jun 2010 14:55:33 -0400
From: Alex <alex323@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Subject: Invalid extension type displayed with setkey

>Number:         147887
>Category:       bin
>Synopsis:       [patch] Invalid extension type displayed with setkey(8)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bz
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 15 19:30:00 UTC 2010
>Closed-Date:    Mon Sep 03 12:06:34 UTC 2012
>Last-Modified:  Mon Oct  1 15:40:05 UTC 2012
>Originator:     Alex
>Release:        FreeBSD 8.1-PRERELEASE amd64
>Organization:
>Environment:
System: FreeBSD orion 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #4: Sun Jun
13 20:18:56 EDT 2010 alex@orion:/usr/obj/usr/src/sys/ORION amd64

>Description:
After setting up an ESP tunnel with racoon2, setkey -D displays
"Invalid extension type" in place of the actual SAD entries that would
otherwise be displayed. This is caused by libipsec.

>How-To-Repeat:
Set up a racoon2 IKE2 exchange and look at the output from setkey -D.

>Fix:
See attached patch.

--- orig/pfkey.c	2010-06-15 14:53:12.000000000 -0400
+++ pfkey.c	2010-06-15 14:51:04.000000000 -0400
@@ -1776,6 +1776,11 @@
 		case SADB_EXT_SPIRANGE:
 		case SADB_X_EXT_POLICY:
 		case SADB_X_EXT_SA2:
+		case SADB_X_EXT_NAT_T_TYPE:
+		case SADB_X_EXT_NAT_T_SPORT:
+		case SADB_X_EXT_NAT_T_DPORT:
+		case SADB_X_EXT_NAT_T_OAI:
+		case SADB_X_EXT_NAT_T_OAR:
 			mhp[ext->sadb_ext_type] =3D (caddr_t)ext;
 			break;
 		default:

>Release-Note:
>Audit-Trail:

From: Vadym Chepkov <vchepkov@gmail.com>
To: bug-followup@FreeBSD.org
Cc: alex323@gmail.com
Subject: Re: bin/147887: [patch] Invalid extension type displayed with setkey(8)
Date: Sun, 26 Jun 2011 09:13:00 -0400

 Hi,
 
 This bug was opened more then a year ago. Any chance this patch will =
 find it way into stable tree?
 
 Thank you,
 Vadym=

From: David Gilbert <dgilbert@eicat.ca>
To: bug-followup@FreeBSD.org, alex323@gmail.com
Cc:  
Subject: Re: bin/147887: [patch] Invalid extension type displayed with setkey(8)
Date: Tue, 28 Aug 2012 01:02:39 -0400

 This patch fixes things for me on FreeBSD-8.2-p10
State-Changed-From-To: open->patched 
State-Changed-By: bz 
State-Changed-When: Mon Sep 3 11:47:32 UTC 2012 
State-Changed-Why:  
I patched this a while ago; hopefully not just HEAD. 
Need to investigate.  Sorry wasn't aware of the PR. 


Responsible-Changed-From-To: freebsd-bugs->bz 
Responsible-Changed-By: bz 
Responsible-Changed-When: Mon Sep 3 11:47:32 UTC 2012 
Responsible-Changed-Why:  
Take given I had work on this earlier this year. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147887 
State-Changed-From-To: patched->closed 
State-Changed-By: bz 
State-Changed-When: Mon Sep 3 12:06:04 UTC 2012 
State-Changed-Why:  
Things have been fixed already;  thanks for reporting and 
sorry for not nowing about it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=147887 

From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: alex323@gmail.com, David Gilbert <dgilbert@eicat.ca>, 
    Vadym Chepkov <vchepkov@gmail.com>
Subject: Re: bin/147887: [patch] Invalid extension type displayed with
 setkey(8)
Date: Mon, 3 Sep 2012 12:05:08 +0000 (UTC)

 On Mon, 3 Sep 2012, bz@FreeBSD.org wrote:
 
 This was fixed in
 HEAD r231532 Sat Feb 11 20:43:01 2012 UTC
 9    r235696 Sun May 20 20:25:22 2012 UTC
 8    r235697 Sun May 20 20:25:57 2012 UTC
 
 Sorry, I hadn't been aware of the PR.
 
 /bz
 
 -- 
 Bjoern A. Zeeb                                 You have to have visions!
           Stop bit received. Insert coin for new address family.

From: Vadym Chepkov <vchepkov@gmail.com>
To: "Bjoern A. Zeeb" <bz@freebsd.org>
Cc: bug-followup@freebsd.org, alex323@gmail.com, 
	David Gilbert <dgilbert@eicat.ca>
Subject: Re: bin/147887: [patch] Invalid extension type displayed with setkey(8)
Date: Mon, 1 Oct 2012 10:38:49 -0400

 Bjoern,
 
 I have upgraded to 8.3, unfortunately the problem still exists:
 
 # setkey -D
 Invalid extension type
 Invalid extension type
 Invalid extension type
 Invalid extension type
 
 # /usr/local/sbin/setkey -D|wc -l
       44
 
 ipsec-tools-0.8.0_3 KAME racoon IKE daemon, ipsec-tools version
 
 
 Thanks,
 Vadym
 
 On Mon, Sep 3, 2012 at 8:05 AM, Bjoern A. Zeeb <bz@freebsd.org> wrote:
 > On Mon, 3 Sep 2012, bz@FreeBSD.org wrote:
 >
 > This was fixed in
 > HEAD r231532 Sat Feb 11 20:43:01 2012 UTC
 > 9    r235696 Sun May 20 20:25:22 2012 UTC
 > 8    r235697 Sun May 20 20:25:57 2012 UTC
 >
 > Sorry, I hadn't been aware of the PR.
 >
 > /bz
 >
 > --
 > Bjoern A. Zeeb                                 You have to have visions!
 >          Stop bit received. Insert coin for new address family.

From: "Bjoern A. Zeeb" <bz@freebsd.org>
To: Vadym Chepkov <vchepkov@gmail.com>
Cc: bug-followup@freebsd.org, alex323@gmail.com, 
    David Gilbert <dgilbert@eicat.ca>
Subject: Re: bin/147887: [patch] Invalid extension type displayed with
 setkey(8)
Date: Mon, 1 Oct 2012 14:52:43 +0000 (UTC)

 On Mon, 1 Oct 2012, Vadym Chepkov wrote:
 
 > Bjoern,
 >
 > I have upgraded to 8.3, unfortunately the problem still exists:
 
 8.3 was released in APril 2012: http://www.freebsd.org/releases/
 
 stable/8 was fixed on May 20 2012.
 
 Sorry I cannot help with time and going backwards;-)
 
 /bz

From: Vadym Chepkov <vchepkov@gmail.com>
To: Bjoern A. Zeeb <bz@FreeBSD.org>
Cc: bug-followup@freebsd.org,
 alex323@gmail.com,
 David Gilbert <dgilbert@eicat.ca>
Subject: Re: bin/147887: [patch] Invalid extension type displayed with setkey(8)
Date: Mon, 1 Oct 2012 11:24:08 -0400

 I should have been more specific, sorry.
 I did buildworld for this tag:
 
 *default release=cvs tag=RELENG_8_3
 
 So I have 8.3-RELEASE-p4
 
 Do I need to use RELENG_8 instead?
 
 Thanks,
 Vadym
 
 
 On Oct 1, 2012, at 10:52 AM, Bjoern A. Zeeb wrote:
 
 > On Mon, 1 Oct 2012, Vadym Chepkov wrote:
 > 
 >> Bjoern,
 >> 
 >> I have upgraded to 8.3, unfortunately the problem still exists:
 > 
 > 8.3 was released in APril 2012: http://www.freebsd.org/releases/
 > 
 > stable/8 was fixed on May 20 2012.
 > 
 > Sorry I cannot help with time and going backwards;-)
 > 
 > /bz
 

From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
To: Vadym Chepkov <vchepkov@gmail.com>
Cc: bug-followup@freebsd.org, alex323@gmail.com, 
    David Gilbert <dgilbert@eicat.ca>
Subject: Re: bin/147887: [patch] Invalid extension type displayed with
 setkey(8)
Date: Mon, 1 Oct 2012 15:36:49 +0000 (UTC)

 On Mon, 1 Oct 2012, Vadym Chepkov wrote:
 
 > I should have been more specific, sorry.
 > I did buildworld for this tag:
 >
 > *default release=cvs tag=RELENG_8_3
 >
 > So I have 8.3-RELEASE-p4
 >
 > Do I need to use RELENG_8 instead?
 
 Yes or you can apply the changes formerly mentioned by SNV revision
 numbers ot your current tree and rebuild with those.
 
 /bz
>Unformatted:
