From adamw@holonet.net Mon Oct 25 21:59:41 1999
Return-Path: <adamw@holonet.net>
Received: from tulum.brsys.com (tulum.brsys.com [216.15.105.2])
	by hub.freebsd.org (Postfix) with ESMTP id C87A9153CE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 25 Oct 1999 21:59:29 -0700 (PDT)
	(envelope-from adamw@holonet.net)
Received: from luchar.first.world (ifmxoak.informix.com [192.147.88.2]) by tulum.brsys.com (8.8.8/8.6.12) with SMTP id WAA18260 for <FreeBSD-gnats-submit@freebsd.org>; Mon, 25 Oct 1999 22:06:57 -0700 (PDT)
Message-Id: <99102521580300.31547@luchar.first.world>
Date: Mon, 25 Oct 1999 21:49:34 -0700
From: Adam Wight <adamw@holonet.net>
Reply-To: adamw@holonet.net
To: FreeBSD-gnats-submit@freebsd.org
Subject: pccardd patch

>Number:         14533
>Category:       bin
>Synopsis:       pccardd improperly assigns irqs
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    imp
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 25 22:00:01 PDT 1999
>Closed-Date:    Mon Jun 4 11:17:26 MDT 2001
>Last-Modified:  Mon Jun 04 11:18:02 MDT 2001
>Originator:     Adam Wight
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
>Environment:

>Description:
	pccardd sets the default irq mask for cards to the irq of the pcic
instead of the configured irq that the resource file (pccard.conf) suggests.

>How-To-Repeat:

>Fix:
Index: cardd.c
===================================================================
RCS file: /usr/cvs/src/usr.sbin/pccard/pccardd/cardd.c,v
retrieving revision 1.41
diff -u -r1.41 cardd.c
--- cardd.c     1999/08/28 01:17:35     1.41
+++ cardd.c     1999/10/26 04:49:26
@@ -559,7 +559,7 @@
        }
        strcpy(drv.name, drvp->kernel);
        drv.unit = drvp->unit;
-       drv.irqmask = 1 << sp->irq;
+       drv.irqmask = 1 << sp->config->irq;
        drv.flags = sp->config->flags;
        if (sp->flags & MEM_ASSIGNED) {
                drv.mem = sp->mem.addr;

>Release-Note:
>Audit-Trail:

From: Nate Williams <nate@mt.sri.com>
To: adamw@holonet.net
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/14533: pccardd patch
Date: Tue, 26 Oct 1999 09:15:20 -0600

 > >Number:         14533
 > >Category:       bin
 > >Synopsis:       pccardd improperly assigns irqs
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       medium
 > >Responsible:    freebsd-bugs
 > >State:          open
 > >Quarter:        
 > >Keywords:       
 > >Date-Required:
 > >Class:          change-request
 > >Submitter-Id:   current-users
 > >Arrival-Date:   Mon Oct 25 22:00:01 PDT 1999
 > >Closed-Date:
 > >Last-Modified:
 > >Originator:     Adam Wight
 > >Release:        FreeBSD 4.0-CURRENT i386
 > >Organization:
 > >Environment:
 > 
 > >Description:
 > 	pccardd sets the default irq mask for cards to the irq of the pcic
 > instead of the configured irq that the resource file (pccard.conf) suggests.
 > 
 
 This is necessary to avoid many races for suspend/remove.
 
 > 
 > >Fix:
 > Index: cardd.c
 > ===================================================================
 > RCS file: /usr/cvs/src/usr.sbin/pccard/pccardd/cardd.c,v
 > retrieving revision 1.41
 > diff -u -r1.41 cardd.c
 > --- cardd.c     1999/08/28 01:17:35     1.41
 > +++ cardd.c     1999/10/26 04:49:26
 > @@ -559,7 +559,7 @@
 >         }
 >         strcpy(drv.name, drvp->kernel);
 >         drv.unit = drvp->unit;
 > -       drv.irqmask = 1 << sp->irq;
 > +       drv.irqmask = 1 << sp->config->irq;
 >         drv.flags = sp->config->flags;
 >         if (sp->flags & MEM_ASSIGNED) {
 >                 drv.mem = sp->mem.addr;
 > 
 > >Release-Note:
 > >Audit-Trail:
 > >Unformatted:
 > 
 > 
 > To Unsubscribe: send mail to majordomo@FreeBSD.org
 > with "unsubscribe freebsd-bugs" in the body of the message
 > 
 
Responsible-Changed-From-To: freebsd-bugs->imp 
Responsible-Changed-By: imp 
Responsible-Changed-When: Mon May 15 23:12:26 MDT 2000 
Responsible-Changed-Why:  
I think this has been corrected witht he MFPAO. 
State-Changed-From-To: open->closed 
State-Changed-By: imp 
State-Changed-When: Mon Jun 4 11:17:26 MDT 2001 
State-Changed-Why:  
No longer relevant with new interrupt passing mechanism. 


http://www.FreeBSD.org/cgi/query-pr.cgi?pr=14533 
>Unformatted:
