From nobody@FreeBSD.org  Mon Feb 15 23:36:12 2010
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1EE69106566C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 15 Feb 2010 23:36:12 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 0DBD58FC12
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 15 Feb 2010 23:36:12 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o1FNaBi2015050
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 15 Feb 2010 23:36:11 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id o1FNaBR3015049;
	Mon, 15 Feb 2010 23:36:11 GMT
	(envelope-from nobody)
Message-Id: <201002152336.o1FNaBR3015049@www.freebsd.org>
Date: Mon, 15 Feb 2010 23:36:11 GMT
From: NathanWard <freebsdbugs@daork.net>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Version string in userland ppp broken
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         143976
>Category:       bin
>Synopsis:       Version string in userland ppp broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jkim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Feb 15 23:40:02 UTC 2010
>Closed-Date:    Mon Mar 22 21:02:59 UTC 2010
>Last-Modified:  Mon Mar 22 21:02:59 UTC 2010
>Originator:     NathanWard
>Release:        7.2-RELEASE
>Organization:
Braintrust Ltd.
>Environment:
FreeBSD fbsdng1.braintrust.co.nz 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Fri May  1 08:49:13 UTC 2009     root@walker.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
>Description:
When examining LCP messages transmitted by the userland ppp daemon in FreeBSD, LCP identification messages are sent. These messages contain a freeform string to show what software and version are run on a certain LCP stack.

Here is a dump of one such message:
0000:  c0 21 0c 02 00 2e ea 6b 80 28 75 73 65 72 2d 70  .!.....k.(user-p
0010:  70 70 20 33 2e 34 2e 32 20 28 62 75 69 6c 74 20  pp 3.4.2 (built 
0020:  43 4f 4d 50 49 4c 41 54 49 4f 4e 44 41 54 45 29  COMPILATIONDATE)

Note the COMPILATIONDATE component - my suspicion is a broken macro somewhere.
>How-To-Repeat:
Capture LCP messages sent by the userland ppp daemon.
These messages are only sent after the remote end responds to the initial CONFREQ - pointing ppp at a dummy serial interface will not cause these messages to be sent.

/etc/ppp/ppp.conf
server:
 set ifaddr 10.0.0.1 10.0.0.2 255.255.255.255
 set dial
 set device "!nc -l 127.0.0.1 5000"
client:
 set ifaddr 10.0.0.2 10.0.0.1 255.255.255.255
 set dial
 set device "!nc 127.0.0.1 5000"

Then run the following in different terminals:
1) tcpdump -s1514 -xX -i lo0 port 5000
2) ppp server
then type open
3) ppp client
then type open

>Fix:


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->jkim 
Responsible-Changed-By: jkim 
Responsible-Changed-When: Tue Feb 16 00:49:03 UTC 2010 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143976 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/143976: commit references a PR
Date: Tue, 16 Feb 2010 01:07:20 +0000 (UTC)

 Author: jkim
 Date: Tue Feb 16 01:07:06 2010
 New Revision: 203943
 URL: http://svn.freebsd.org/changeset/base/203943
 
 Log:
   Remove COMPILATIONDATE from the default section.  This string is no longer
   being substituted since r162063.
   
   PR:		bin/143976
   MFC after:	1 month
 
 Modified:
   head/etc/ppp/ppp.conf
 
 Modified: head/etc/ppp/ppp.conf
 ==============================================================================
 --- head/etc/ppp/ppp.conf	Tue Feb 16 00:23:22 2010	(r203942)
 +++ head/etc/ppp/ppp.conf	Tue Feb 16 01:07:06 2010	(r203943)
 @@ -10,7 +10,7 @@
  
  default:
   set log Phase Chat LCP IPCP CCP tun command
 - ident user-ppp VERSION (built COMPILATIONDATE)
 + ident user-ppp VERSION
  
   # Ensure that "device" references the correct serial port
   # for your modem. (cuau0 = COM1, cuau1 = COM2)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: jkim 
State-Changed-When: Mon Mar 22 21:01:59 UTC 2010 
State-Changed-Why:  
The fix was MFC'd to 6, 7, and 8.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=143976 
>Unformatted:
