From nobody@FreeBSD.org  Mon Dec 21 12:29:33 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F07941065679
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Dec 2009 12:29:33 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id E08678FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Dec 2009 12:29:33 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nBLCTXhW016477
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Dec 2009 12:29:33 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nBLCTXQt016476;
	Mon, 21 Dec 2009 12:29:33 GMT
	(envelope-from nobody)
Message-Id: <200912211229.nBLCTXQt016476@www.freebsd.org>
Date: Mon, 21 Dec 2009 12:29:33 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Memory leak in usr.bin/finger/finger.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         141836
>Category:       bin
>Synopsis:       Memory leak in usr.bin/finger/finger.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 21 12:30:07 UTC 2009
>Closed-Date:    Mon Jan 04 01:16:37 UTC 2010
>Last-Modified:  Mon Jan  4 01:20:05 UTC 2010
>Originator:     Henning Petersen
>Release:        Freebsd-current
>Organization:
>Environment:
>Description:
Memory leak found with cppcheck.
>How-To-Repeat:

>Fix:
diff -u -r1.38 finger.c
--- src/usr.bin/finger/finger.c	11 Apr 2007 20:32:09 -0000	1.38
+++ src/usr.bin/finger/finger.c	21 Dec 2009 09:54:37 -0000
@@ -373,6 +373,7 @@
 		    printf("\n");
 	}
 
+	free(used);
 	if (entries == 0)
 		return;


Patch attached with submission follows:

Index: src/usr.bin/finger/finger.c
===================================================================
RCS file: /usr/ncvs/src/usr.bin/finger/finger.c,v
retrieving revision 1.38
diff -u -r1.38 finger.c
--- src/usr.bin/finger/finger.c	11 Apr 2007 20:32:09 -0000	1.38
+++ src/usr.bin/finger/finger.c	21 Dec 2009 09:54:37 -0000
@@ -373,6 +373,7 @@
 		    printf("\n");
 	}
 
+	free(used);
 	if (entries == 0)
 		return;
 


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: delphij 
State-Changed-When: Mon Dec 21 19:15:40 UTC 2009 
State-Changed-Why:  
Committed against -HEAD, MFC reminder. 


Responsible-Changed-From-To: freebsd-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Mon Dec 21 19:15:40 UTC 2009 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141836 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/141836: commit references a PR
Date: Mon, 21 Dec 2009 19:17:13 +0000 (UTC)

 Author: delphij
 Date: Mon Dec 21 19:15:30 2009
 New Revision: 200793
 URL: http://svn.freebsd.org/changeset/base/200793
 
 Log:
   Plug a memory leak.
   
   PR:		bin/141836
   Submitted by:	Henning Petersen <henning.petersen at t-online.de>
   MFC after:	2 weeks
 
 Modified:
   head/usr.bin/finger/finger.c
 
 Modified: head/usr.bin/finger/finger.c
 ==============================================================================
 --- head/usr.bin/finger/finger.c	Mon Dec 21 18:56:55 2009	(r200792)
 +++ head/usr.bin/finger/finger.c	Mon Dec 21 19:15:30 2009	(r200793)
 @@ -373,6 +373,7 @@ net:	for (p = nargv; *p;) {
  		    printf("\n");
  	}
  
 +	free(used);
  	if (entries == 0)
  		return;
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/141836: commit references a PR
Date: Mon,  4 Jan 2010 01:07:48 +0000 (UTC)

 Author: delphij
 Date: Mon Jan  4 01:07:32 2010
 New Revision: 201457
 URL: http://svn.freebsd.org/changeset/base/201457
 
 Log:
   MFC r200793:
   
   Plug a memory leak.
   
   PR:		bin/141836
   Submitted by:	Henning Petersen <henning.petersen at t-online.de>
 
 Modified:
   stable/8/usr.bin/finger/finger.c
 Directory Properties:
   stable/8/usr.bin/finger/   (props changed)
 
 Modified: stable/8/usr.bin/finger/finger.c
 ==============================================================================
 --- stable/8/usr.bin/finger/finger.c	Mon Jan  4 00:49:04 2010	(r201456)
 +++ stable/8/usr.bin/finger/finger.c	Mon Jan  4 01:07:32 2010	(r201457)
 @@ -373,6 +373,7 @@ net:	for (p = nargv; *p;) {
  		    printf("\n");
  	}
  
 +	free(used);
  	if (entries == 0)
  		return;
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: delphij 
State-Changed-When: Mon Jan 4 01:16:05 UTC 2010 
State-Changed-Why:  
Patch applied against 6,7,8-STABLE branches. 
Thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141836 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/141836: commit references a PR
Date: Mon,  4 Jan 2010 01:13:22 +0000 (UTC)

 Author: delphij
 Date: Mon Jan  4 01:13:03 2010
 New Revision: 201460
 URL: http://svn.freebsd.org/changeset/base/201460
 
 Log:
   MFC r200793:
   
   Plug a memory leak.
   
   PR:		bin/141836
   Submitted by:	Henning Petersen <henning.petersen at t-online.de>
   MFC after:	2 weeks
 
 Modified:
   stable/6/usr.bin/finger/finger.c
 Directory Properties:
   stable/6/usr.bin/finger/   (props changed)
 
 Modified: stable/6/usr.bin/finger/finger.c
 ==============================================================================
 --- stable/6/usr.bin/finger/finger.c	Mon Jan  4 01:09:59 2010	(r201459)
 +++ stable/6/usr.bin/finger/finger.c	Mon Jan  4 01:13:03 2010	(r201460)
 @@ -373,6 +373,7 @@ net:	for (p = nargv; *p;) {
  		    printf("\n");
  	}
  
 +	free(used);
  	if (entries == 0)
  		return;
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/141836: commit references a PR
Date: Mon,  4 Jan 2010 01:13:37 +0000 (UTC)

 Author: delphij
 Date: Mon Jan  4 01:13:05 2010
 New Revision: 201461
 URL: http://svn.freebsd.org/changeset/base/201461
 
 Log:
   MFC r200793:
   
   Plug a memory leak.
   
   PR:		bin/141836
   Submitted by:	Henning Petersen <henning.petersen at t-online.de>
   MFC after:	2 weeks
 
 Modified:
   stable/7/usr.bin/finger/finger.c
 Directory Properties:
   stable/7/usr.bin/finger/   (props changed)
 
 Modified: stable/7/usr.bin/finger/finger.c
 ==============================================================================
 --- stable/7/usr.bin/finger/finger.c	Mon Jan  4 01:13:03 2010	(r201460)
 +++ stable/7/usr.bin/finger/finger.c	Mon Jan  4 01:13:05 2010	(r201461)
 @@ -373,6 +373,7 @@ net:	for (p = nargv; *p;) {
  		    printf("\n");
  	}
  
 +	free(used);
  	if (entries == 0)
  		return;
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
