From nobody@FreeBSD.org  Mon Dec 21 12:26:40 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EEEF4106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Dec 2009 12:26:40 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id DE89F8FC16
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Dec 2009 12:26:40 +0000 (UTC)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id nBLCQeo4016113
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 21 Dec 2009 12:26:40 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id nBLCQeMY016112;
	Mon, 21 Dec 2009 12:26:40 GMT
	(envelope-from nobody)
Message-Id: <200912211226.nBLCQeMY016112@www.freebsd.org>
Date: Mon, 21 Dec 2009 12:26:40 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Memory leak in bin/pax/sel_subs.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         141835
>Category:       bin
>Synopsis:       Memory leak in bin/pax/sel_subs.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 21 12:30:06 UTC 2009
>Closed-Date:    Mon Jan 04 01:17:12 UTC 2010
>Last-Modified:  Mon Jan  4 01:20:08 UTC 2010
>Originator:     Henning Petersen
>Release:        Freebsd-current
>Organization:
>Environment:
>Description:
Memory leak found with cppcheck.
>How-To-Repeat:

>Fix:
diff -u -r1.21 sel_subs.c
--- src/bin/pax/sel_subs.c	25 May 2007 17:53:38 -0000	1.21
+++ src/bin/pax/sel_subs.c	21 Dec 2009 08:52:55 -0000
@@ -396,6 +396,7 @@
 			default:
 				paxwarn(1, "Bad option %c with time range %s",
 				    *flgpt, str);
+				free(pt);
 				goto out;
 			}
 			++flgpt;


Patch attached with submission follows:

Index: src/bin/pax/sel_subs.c
===================================================================
RCS file: /usr/ncvs/src/bin/pax/sel_subs.c,v
retrieving revision 1.21
diff -u -r1.21 sel_subs.c
--- src/bin/pax/sel_subs.c	25 May 2007 17:53:38 -0000	1.21
+++ src/bin/pax/sel_subs.c	21 Dec 2009 08:52:55 -0000
@@ -396,6 +396,7 @@
 			default:
 				paxwarn(1, "Bad option %c with time range %s",
 				    *flgpt, str);
+				free(pt);
 				goto out;
 			}
 			++flgpt;


>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: delphij 
State-Changed-When: Mon Dec 21 19:18:34 UTC 2009 
State-Changed-Why:  
Patch applied against -HEAD, MFC reminder. 


Responsible-Changed-From-To: freebsd-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Mon Dec 21 19:18:34 UTC 2009 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141835 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/141835: commit references a PR
Date: Mon, 21 Dec 2009 19:18:40 +0000 (UTC)

 Author: delphij
 Date: Mon Dec 21 19:18:27 2009
 New Revision: 200794
 URL: http://svn.freebsd.org/changeset/base/200794
 
 Log:
   Plug a memory leak.
   
   PR:		bin/141835
   Submitted by:	Henning Petersen <henning.petersen t-online.de>
   MFC after:	2 weeks
 
 Modified:
   head/bin/pax/sel_subs.c
 
 Modified: head/bin/pax/sel_subs.c
 ==============================================================================
 --- head/bin/pax/sel_subs.c	Mon Dec 21 19:15:30 2009	(r200793)
 +++ head/bin/pax/sel_subs.c	Mon Dec 21 19:18:27 2009	(r200794)
 @@ -396,6 +396,7 @@ trng_add(char *str)
  			default:
  				paxwarn(1, "Bad option %c with time range %s",
  				    *flgpt, str);
 +				free(pt);
  				goto out;
  			}
  			++flgpt;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/141835: commit references a PR
Date: Mon,  4 Jan 2010 01:08:35 +0000 (UTC)

 Author: delphij
 Date: Mon Jan  4 01:08:27 2010
 New Revision: 201458
 URL: http://svn.freebsd.org/changeset/base/201458
 
 Log:
   Plug a memory leak.
   
   PR:		bin/141835
   Submitted by:	Henning Petersen <henning.petersen t-online.de>
 
 Modified:
   stable/8/bin/pax/sel_subs.c
 Directory Properties:
   stable/8/bin/pax/   (props changed)
 
 Modified: stable/8/bin/pax/sel_subs.c
 ==============================================================================
 --- stable/8/bin/pax/sel_subs.c	Mon Jan  4 01:07:32 2010	(r201457)
 +++ stable/8/bin/pax/sel_subs.c	Mon Jan  4 01:08:27 2010	(r201458)
 @@ -396,6 +396,7 @@ trng_add(char *str)
  			default:
  				paxwarn(1, "Bad option %c with time range %s",
  				    *flgpt, str);
 +				free(pt);
  				goto out;
  			}
  			++flgpt;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: delphij 
State-Changed-When: Mon Jan 4 01:16:51 UTC 2010 
State-Changed-Why:  
Patch applied against 6,7,8-STABLE, thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=141835 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/141835: commit references a PR
Date: Mon,  4 Jan 2010 01:14:36 +0000 (UTC)

 Author: delphij
 Date: Mon Jan  4 01:14:18 2010
 New Revision: 201462
 URL: http://svn.freebsd.org/changeset/base/201462
 
 Log:
   MFC r200794:
   
   Plug a memory leak.
   
   PR:		bin/141835
   Submitted by:	Henning Petersen <henning.petersen t-online.de>
   MFC after:	2 weeks
 
 Modified:
   stable/6/bin/pax/sel_subs.c
 Directory Properties:
   stable/6/bin/pax/   (props changed)
 
 Modified: stable/6/bin/pax/sel_subs.c
 ==============================================================================
 --- stable/6/bin/pax/sel_subs.c	Mon Jan  4 01:13:05 2010	(r201461)
 +++ stable/6/bin/pax/sel_subs.c	Mon Jan  4 01:14:18 2010	(r201462)
 @@ -396,6 +396,7 @@ trng_add(char *str)
  			default:
  				paxwarn(1, "Bad option %c with time range %s",
  				    *flgpt, str);
 +				free(pt);
  				goto out;
  			}
  			++flgpt;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/141835: commit references a PR
Date: Mon,  4 Jan 2010 01:14:44 +0000 (UTC)

 Author: delphij
 Date: Mon Jan  4 01:14:21 2010
 New Revision: 201463
 URL: http://svn.freebsd.org/changeset/base/201463
 
 Log:
   MFC r200794:
   
   Plug a memory leak.
   
   PR:		bin/141835
   Submitted by:	Henning Petersen <henning.petersen t-online.de>
   MFC after:	2 weeks
 
 Modified:
   stable/7/bin/pax/sel_subs.c
 Directory Properties:
   stable/7/bin/pax/   (props changed)
 
 Modified: stable/7/bin/pax/sel_subs.c
 ==============================================================================
 --- stable/7/bin/pax/sel_subs.c	Mon Jan  4 01:14:18 2010	(r201462)
 +++ stable/7/bin/pax/sel_subs.c	Mon Jan  4 01:14:21 2010	(r201463)
 @@ -396,6 +396,7 @@ trng_add(char *str)
  			default:
  				paxwarn(1, "Bad option %c with time range %s",
  				    *flgpt, str);
 +				free(pt);
  				goto out;
  			}
  			++flgpt;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
