From uqs@spoerlein.net  Thu Oct 29 13:01:18 2009
Return-Path: <uqs@spoerlein.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 642DC1065670
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 29 Oct 2009 13:01:18 +0000 (UTC)
	(envelope-from uqs@spoerlein.net)
Received: from acme.spoerlein.net (cl-43.dus-01.de.sixxs.net [IPv6:2a01:198:200:2a::2])
	by mx1.freebsd.org (Postfix) with ESMTP id CD4F38FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 29 Oct 2009 13:01:17 +0000 (UTC)
Received: from roadrunner.spoerlein.net (pD9E5C041.dip.t-dialin.net [217.229.192.65])
	by acme.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9TD1FWr045913
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 29 Oct 2009 14:01:16 +0100 (CET)
	(envelope-from uqs@spoerlein.net)
Received: from roadrunner.spoerlein.net (localhost [127.0.0.1])
	by roadrunner.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9TD10tZ009389
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 29 Oct 2009 14:01:00 +0100 (CET)
	(envelope-from uqs@roadrunner.spoerlein.net)
Received: (from uqs@localhost)
	by roadrunner.spoerlein.net (8.14.3/8.14.3/Submit) id n9TD10uC009388;
	Thu, 29 Oct 2009 14:01:00 +0100 (CET)
	(envelope-from uqs)
Message-Id: <200910291301.n9TD10uC009388@roadrunner.spoerlein.net>
Date: Thu, 29 Oct 2009 14:01:00 +0100 (CET)
From: Ulrich Spoerlein <uqs@spoerlein.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: routed(8) increase to WARNS=3
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         140081
>Category:       bin
>Synopsis:       [patch] routed(8) increase to WARNS=3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    uqs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Oct 29 13:10:00 UTC 2009
>Closed-Date:    Sat Feb 27 10:40:24 UTC 2010
>Last-Modified:  Sat Feb 27 10:40:24 UTC 2010
>Originator:     Ulrich Spoerlein
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
>Environment:
	
>Description:
- Bump WARNS, also for rtquery subdir
>How-To-Repeat:
	
>Fix:

	

--- routed.diff begins here ---
diff -r 603a0689809d -r 2d930e159d74 sbin/routed/Makefile
--- a/sbin/routed/Makefile	Thu Oct 29 12:23:33 2009 +0100
+++ b/sbin/routed/Makefile	Thu Oct 29 13:59:58 2009 +0100
@@ -8,7 +8,7 @@
 LDADD=	-lmd
 DPADD=	${LIBMD}
 .if ${MACHINE_ARCH} != "i386" && ${MACHINE_ARCH} != "amd64" 
-WARNS?=	0
+WARNS?=	3
 .endif
 
 .include <bsd.prog.mk>
diff -r 603a0689809d -r 2d930e159d74 sbin/routed/if.c
--- a/sbin/routed/if.c	Thu Oct 29 12:23:33 2009 +0100
+++ b/sbin/routed/if.c	Thu Oct 29 13:59:58 2009 +0100
@@ -29,6 +29,8 @@
  * $FreeBSD$
  */
 
+#include <stdint.h>
+
 #include "defs.h"
 #include "pathnames.h"
 
@@ -948,9 +950,9 @@
 				} else if (now.tv_sec>(ifp->int_data.ts
 						       + CHECK_BAD_INTERVAL)) {
 					trace_act("interface %s has been off"
-						  " %ld seconds; forget it",
+						  " %jd seconds; forget it",
 						  ifp->int_name,
-						  (long)now.tv_sec-
+						  (intmax_t)now.tv_sec-
 						      ifp->int_data.ts);
 					ifdel(ifp);
 				}
diff -r 603a0689809d -r 2d930e159d74 sbin/routed/rtquery/Makefile
--- a/sbin/routed/rtquery/Makefile	Thu Oct 29 12:23:33 2009 +0100
+++ b/sbin/routed/rtquery/Makefile	Thu Oct 29 13:59:58 2009 +0100
@@ -6,6 +6,6 @@
 MAN=	rtquery.8
 LDADD=	-lmd
 DPADD=	${LIBMD}
-WARNS?=	0
+WARNS?=	3
 
 .include <bsd.prog.mk>
--- routed.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->uqs 
Responsible-Changed-By: uqs 
Responsible-Changed-When: Thu Feb 4 08:59:11 UTC 2010 
Responsible-Changed-Why:  
Take my own PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140081 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/140081: commit references a PR
Date: Sat, 27 Feb 2010 10:17:37 +0000 (UTC)

 Author: uqs
 Date: Sat Feb 27 10:17:27 2010
 New Revision: 204405
 URL: http://svn.freebsd.org/changeset/base/204405
 
 Log:
   routed(8)/rtquery(8) bump/demote to WARNS=3 for all archs
   
   - The MACHINE_ARCH check is not exhaustive (missing at least powerpc),
     and generally not worth maintaining.
   - While here, fix whitespace and ordering of the Makefile
   
   PR:		bin/140081
   Approved by:	ed (co-mentor)
 
 Modified:
   head/sbin/routed/Makefile
   head/sbin/routed/if.c
   head/sbin/routed/rtquery/Makefile
 
 Modified: head/sbin/routed/Makefile
 ==============================================================================
 --- head/sbin/routed/Makefile	Sat Feb 27 10:16:14 2010	(r204404)
 +++ head/sbin/routed/Makefile	Sat Feb 27 10:17:27 2010	(r204405)
 @@ -1,14 +1,13 @@
  # Make `routed` for FreeBSD
  # $FreeBSD$
  
 -PROG=   routed
 -SRCS=   if.c input.c main.c output.c parms.c radix.c rdisc.c table.c trace.c
 -MAN=   routed.8
 -SUBDIR= rtquery
 -LDADD=	-lmd
 +PROG=	routed
 +MAN=	routed.8
 +SRCS=	if.c input.c main.c output.c parms.c radix.c rdisc.c table.c trace.c
 +WARNS?=	3
  DPADD=	${LIBMD}
 -.if ${MACHINE_ARCH} != "i386" && ${MACHINE_ARCH} != "amd64" 
 -WARNS?=	0
 -.endif
 +LDADD=	-lmd
 +
 +SUBDIR= rtquery
  
  .include <bsd.prog.mk>
 
 Modified: head/sbin/routed/if.c
 ==============================================================================
 --- head/sbin/routed/if.c	Sat Feb 27 10:16:14 2010	(r204404)
 +++ head/sbin/routed/if.c	Sat Feb 27 10:17:27 2010	(r204405)
 @@ -29,6 +29,8 @@
   * $FreeBSD$
   */
  
 +#include <stdint.h>
 +
  #include "defs.h"
  #include "pathnames.h"
  
 @@ -948,9 +950,9 @@ ifinit(void)
  				} else if (now.tv_sec>(ifp->int_data.ts
  						       + CHECK_BAD_INTERVAL)) {
  					trace_act("interface %s has been off"
 -						  " %ld seconds; forget it",
 +						  " %jd seconds; forget it",
  						  ifp->int_name,
 -						  (long)now.tv_sec-
 +						  (intmax_t)now.tv_sec -
  						      ifp->int_data.ts);
  					ifdel(ifp);
  				}
 
 Modified: head/sbin/routed/rtquery/Makefile
 ==============================================================================
 --- head/sbin/routed/rtquery/Makefile	Sat Feb 27 10:16:14 2010	(r204404)
 +++ head/sbin/routed/rtquery/Makefile	Sat Feb 27 10:17:27 2010	(r204405)
 @@ -6,6 +6,6 @@ PROG=	rtquery
  MAN=	rtquery.8
  LDADD=	-lmd
  DPADD=	${LIBMD}
 -WARNS?=	0
 +WARNS?=	3
  
  .include <bsd.prog.mk>
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: uqs 
State-Changed-When: Sat Feb 27 10:40:23 UTC 2010 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140081 
>Unformatted:
