From uqs@spoerlein.net  Tue Oct 27 14:58:15 2009
Return-Path: <uqs@spoerlein.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8D1811065676
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 27 Oct 2009 14:58:15 +0000 (UTC)
	(envelope-from uqs@spoerlein.net)
Received: from acme.spoerlein.net (cl-43.dus-01.de.sixxs.net [IPv6:2a01:198:200:2a::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 260E88FC0C
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 27 Oct 2009 14:58:14 +0000 (UTC)
Received: from acme.spoerlein.net (localhost.spoerlein.net [IPv6:::1])
	by acme.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9REwDZJ085770
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 27 Oct 2009 15:58:13 +0100 (CET)
	(envelope-from uqs@acme.spoerlein.net)
Received: (from uqs@localhost)
	by acme.spoerlein.net (8.14.3/8.14.3/Submit) id n9REwDvr085769;
	Tue, 27 Oct 2009 15:58:13 +0100 (CET)
	(envelope-from uqs)
Message-Id: <200910271458.n9REwDvr085769@acme.spoerlein.net>
Date: Tue, 27 Oct 2009 15:58:13 +0100 (CET)
From: Ulrich Spörlein <uqs@spoerlein.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: umount(8) raise to WARNS=3
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         140017
>Category:       bin
>Synopsis:       [patch] umount(8) raise to WARNS=3
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    delphij
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 27 15:00:05 UTC 2009
>Closed-Date:    Thu Jan 28 02:33:50 UTC 2010
>Last-Modified:  Fri Nov 12 20:55:48 UTC 2010
>Originator:     Ulrich Spoerlein
>Release:        FreeBSD 7.2-STABLE i386
>Organization:
>Environment:
	
>Description:
	
>How-To-Repeat:
	
>Fix:
	
--- umount.patch begins here ---
diff -r b6811768c714 -r 4ac60f34976d sbin/umount/Makefile
--- a/sbin/umount/Makefile	Mon Oct 19 16:54:04 2009 +0200
+++ b/sbin/umount/Makefile	Mon Oct 19 17:02:14 2009 +0200
@@ -4,7 +4,7 @@
 
 PROG=	umount
 SRCS=	umount.c vfslist.c mounttab.c
-WARNS?=	0
+WARNS?=	3
 MAN=	umount.8
 
 MOUNT=	${.CURDIR}/../mount
diff -r b6811768c714 -r 4ac60f34976d sbin/umount/umount.c
--- a/sbin/umount/umount.c	Mon Oct 19 16:54:04 2009 +0200
+++ b/sbin/umount/umount.c	Mon Oct 19 17:02:14 2009 +0200
@@ -255,8 +255,8 @@
 	 * mount table again.
 	 */
 	if (sfs == NULL && (delimp = strrchr(name, '@')) != NULL) {
-		snprintf(buf, sizeof(buf), "%s:%.*s", delimp + 1, delimp - name,
-		    name);
+		snprintf(buf, sizeof(buf), "%s:%.*s", delimp + 1,
+		    (int)(delimp - name), name);
 		len = strlen(buf);
 		while (len > 1 && buf[len - 1] == '/')
 			buf[--len] = '\0';
--- umount.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->delphij 
Responsible-Changed-By: delphij 
Responsible-Changed-When: Sat Dec 26 09:21:25 UTC 2009 
Responsible-Changed-Why:  
Take.  I have a better patch which can raise WARNS?= level to 6. 
Will commit once I get a complete universe build. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140017 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/140017: commit references a PR
Date: Mon, 28 Dec 2009 17:57:52 +0000 (UTC)

 Author: delphij
 Date: Mon Dec 28 17:57:37 2009
 New Revision: 201135
 URL: http://svn.freebsd.org/changeset/base/201135
 
 Log:
   Make umount(8) WARNS=6 clean:
    - Cast delimiter width to integer [1]
    - Solve name conflicts against system header
    - Constify parameters to avoid qualifier conflict
   
   PR:		bin/140017 [1]
   Submitted by:	Ulrich Spörlein <uqs spoerlein net> [1]
   MFC after:	1 month
   Sponsored by:	iXsystems, Inc
 
 Modified:
   head/sbin/umount/Makefile
   head/sbin/umount/umount.c
   head/usr.sbin/rpc.umntall/mounttab.c
 
 Modified: head/sbin/umount/Makefile
 ==============================================================================
 --- head/sbin/umount/Makefile	Mon Dec 28 15:35:39 2009	(r201134)
 +++ head/sbin/umount/Makefile	Mon Dec 28 17:57:37 2009	(r201135)
 @@ -4,7 +4,6 @@
  
  PROG=	umount
  SRCS=	umount.c vfslist.c mounttab.c
 -WARNS?=	0
  MAN=	umount.8
  
  MOUNT=	${.CURDIR}/../mount
 
 Modified: head/sbin/umount/umount.c
 ==============================================================================
 --- head/sbin/umount/umount.c	Mon Dec 28 15:35:39 2009	(r201134)
 +++ head/sbin/umount/umount.c	Mon Dec 28 17:57:37 2009	(r201135)
 @@ -75,7 +75,7 @@ char   **makevfslist (const char *);
  size_t	 mntinfo (struct statfs **);
  int	 namematch (struct addrinfo *);
  int	 parsehexfsid(const char *hex, fsid_t *fsid);
 -int	 sacmp (struct sockaddr *, struct sockaddr *);
 +int	 sacmp (void *, void *);
  int	 umountall (char **);
  int	 checkname (char *, char **);
  int	 umountfs(struct statfs *sfs);
 @@ -225,7 +225,7 @@ umountall(char **typelist)
   * Do magic checks on mountpoint/device/fsid, and then call unmount(2).
   */
  int
 -checkname(char *name, char **typelist)
 +checkname(char *mntname, char **typelist)
  {
  	char buf[MAXPATHLEN];
  	struct statfs sfsbuf;
 @@ -238,25 +238,25 @@ checkname(char *name, char **typelist)
  	/*
  	 * 1. Check if the name exists in the mounttable.
  	 */
 -	sfs = checkmntlist(name);
 +	sfs = checkmntlist(mntname);
  	/*
  	 * 2. Remove trailing slashes if there are any. After that
  	 * we look up the name in the mounttable again.
  	 */
  	if (sfs == NULL) {
 -		len = strlen(name);
 -		while (len > 1 && name[len - 1] == '/')
 -			name[--len] = '\0';
 -		sfs = checkmntlist(name);
 +		len = strlen(mntname);
 +		while (len > 1 && mntname[len - 1] == '/')
 +			mntname[--len] = '\0';
 +		sfs = checkmntlist(mntname);
  	}
  	/*
  	 * 3. Check if the deprecated NFS syntax with an '@' has been used
  	 * and translate it to the ':' syntax. Look up the name in the
  	 * mount table again.
  	 */
 -	if (sfs == NULL && (delimp = strrchr(name, '@')) != NULL) {
 -		snprintf(buf, sizeof(buf), "%s:%.*s", delimp + 1, delimp - name,
 -		    name);
 +	if (sfs == NULL && (delimp = strrchr(mntname, '@')) != NULL) {
 +		snprintf(buf, sizeof(buf), "%s:%.*s", delimp + 1,
 +		    (int)(delimp - mntname), mntname);
  		len = strlen(buf);
  		while (len > 1 && buf[len - 1] == '/')
  			buf[--len] = '\0';
 @@ -271,28 +271,28 @@ checkname(char *name, char **typelist)
  	 * mount list and reality.
  	 * We also do this if an ambiguous mount point was specified.
  	 */
 -	if (sfs == NULL || (getmntentry(NULL, name, NULL, FIND) != NULL &&
 -	    getmntentry(NULL, name, NULL, CHECKUNIQUE) == NULL)) {
 -		if (statfs(name, &sfsbuf) != 0) {
 -			warn("%s: statfs", name);
 -		} else if (stat(name, &sb) != 0) {
 -			warn("%s: stat", name);
 +	if (sfs == NULL || (getmntentry(NULL, mntname, NULL, FIND) != NULL &&
 +	    getmntentry(NULL, mntname, NULL, CHECKUNIQUE) == NULL)) {
 +		if (statfs(mntname, &sfsbuf) != 0) {
 +			warn("%s: statfs", mntname);
 +		} else if (stat(mntname, &sb) != 0) {
 +			warn("%s: stat", mntname);
  		} else if (S_ISDIR(sb.st_mode)) {
 -			/* Check that `name' is the root directory. */
 +			/* Check that `mntname' is the root directory. */
  			dev = sb.st_dev;
 -			snprintf(buf, sizeof(buf), "%s/..", name);
 +			snprintf(buf, sizeof(buf), "%s/..", mntname);
  			if (stat(buf, &sb) != 0) {
  				warn("%s: stat", buf);
  			} else if (sb.st_dev == dev) {
  				warnx("%s: not a file system root directory",
 -				    name);
 +				    mntname);
  				return (1);
  			} else
  				sfs = &sfsbuf;
  		}
  	}
  	if (sfs == NULL) {
 -		warnx("%s: unknown file system", name);
 +		warnx("%s: unknown file system", mntname);
  		return (1);
  	}
  	if (checkvfsname(sfs->f_fstypename, typelist))
 @@ -469,15 +469,16 @@ getmntentry(const char *fromname, const 
  }
  
  int
 -sacmp(struct sockaddr *sa1, struct sockaddr *sa2)
 +sacmp(void *sa1, void *sa2)
  {
  	void *p1, *p2;
  	int len;
  
 -	if (sa1->sa_family != sa2->sa_family)
 +	if (((struct sockaddr *)sa1)->sa_family !=
 +	    ((struct sockaddr *)sa2)->sa_family)
  		return (1);
  
 -	switch (sa1->sa_family) {
 +	switch (((struct sockaddr *)sa1)->sa_family) {
  	case AF_INET:
  		p1 = &((struct sockaddr_in *)sa1)->sin_addr;
  		p2 = &((struct sockaddr_in *)sa2)->sin_addr;
 @@ -520,18 +521,18 @@ namematch(struct addrinfo *ai)
  }
  
  struct statfs *
 -checkmntlist(char *name)
 +checkmntlist(char *mntname)
  {
  	struct statfs *sfs;
  	fsid_t fsid;
  
  	sfs = NULL;
 -	if (parsehexfsid(name, &fsid) == 0)
 +	if (parsehexfsid(mntname, &fsid) == 0)
  		sfs = getmntentry(NULL, NULL, &fsid, FIND);
  	if (sfs == NULL)
 -		sfs = getmntentry(NULL, name, NULL, FIND);
 +		sfs = getmntentry(NULL, mntname, NULL, FIND);
  	if (sfs == NULL)
 -		sfs = getmntentry(name, NULL, NULL, FIND);
 +		sfs = getmntentry(mntname, NULL, NULL, FIND);
  	return (sfs);
  }
  
 
 Modified: head/usr.sbin/rpc.umntall/mounttab.c
 ==============================================================================
 --- head/usr.sbin/rpc.umntall/mounttab.c	Mon Dec 28 15:35:39 2009	(r201134)
 +++ head/usr.sbin/rpc.umntall/mounttab.c	Mon Dec 28 17:57:37 2009	(r201135)
 @@ -45,7 +45,7 @@ __FBSDID("$FreeBSD$");
  
  struct mtablist *mtabhead;
  
 -static void badline(char *field, char *bad);
 +static void badline(const char *field, const char *bad);
  
  /*
   * Add an entry to PATH_MOUNTTAB for each mounted NFS filesystem,
 @@ -69,12 +69,12 @@ add_mtab(char *hostp, char *dirp) {
   * Read mounttab line for line and return struct mtablist.
   */
  int
 -read_mtab() {
 +read_mtab(void) {
  	struct mtablist **mtabpp, *mtabp;
  	char *hostp, *dirp, *cp;
  	char str[STRSIZ];
  	char *timep, *endp;
 -	time_t time;
 +	time_t actiontime;
  	u_long ultmp;
  	FILE *mtabfile;
  
 @@ -86,7 +86,7 @@ read_mtab() {
  			return (0);
  		}
  	}
 -	time = 0;
 +	actiontime = 0;
  	mtabpp = &mtabhead;
  	while (fgets(str, STRSIZ, mtabfile) != NULL) {
  		cp = str;
 @@ -113,13 +113,13 @@ read_mtab() {
  			badline("time", timep);
  			continue;
  		}
 -		time = ultmp;
 +		actiontime = ultmp;
  		if ((mtabp = malloc(sizeof (struct mtablist))) == NULL) {
  			syslog(LOG_ERR, "malloc");
  			fclose(mtabfile);
  			return (0);
  		}
 -		mtabp->mtab_time = time;
 +		mtabp->mtab_time = actiontime;
  		memmove(mtabp->mtab_host, hostp, MNTNAMLEN);
  		mtabp->mtab_host[MNTNAMLEN - 1] = '\0';
  		memmove(mtabp->mtab_dirp, dirp, MNTPATHLEN);
 @@ -218,7 +218,7 @@ free_mtab() {
   * Print bad lines to syslog.
   */
  static void
 -badline(char *field, char *bad) {
 +badline(const char *field, const char *bad) {
  	syslog(LOG_ERR, "bad mounttab %s field '%s'", field,
  	    (bad == NULL) ? "<null>" : bad);
  }
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: delphij 
State-Changed-When: Mon Dec 28 18:21:02 UTC 2009 
State-Changed-Why:  
An enhanced patch applied against -HEAD. 

MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140017 
State-Changed-From-To: patched->closed 
State-Changed-By: delphij 
State-Changed-When: Thu Jan 28 02:33:31 UTC 2010 
State-Changed-Why:  
Patch applied against 8-STABLE, thanks for your submission! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140017 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/140017: commit references a PR
Date: Thu, 28 Jan 2010 02:33:29 +0000 (UTC)

 Author: delphij
 Date: Thu Jan 28 02:33:20 2010
 New Revision: 203105
 URL: http://svn.freebsd.org/changeset/base/203105
 
 Log:
   MFC r200135:
   
   Make umount(8) WARNS=6 clean:
    - Cast delimiter width to integer [1]
    - Solve name conflicts against system header
    - Constify parameters to avoid qualifier conflict
   
   PR:		bin/140017 [1]
   Submitted by:	Ulrich Spörlein <uqs spoerlein net> [1]
   Sponsored by:	iXsystems, Inc
 
 Modified:
   stable/8/sbin/umount/Makefile
   stable/8/sbin/umount/umount.c
   stable/8/usr.sbin/rpc.umntall/mounttab.c
 Directory Properties:
   stable/8/sbin/umount/   (props changed)
   stable/8/usr.sbin/rpc.umntall/   (props changed)
 
 Modified: stable/8/sbin/umount/Makefile
 ==============================================================================
 --- stable/8/sbin/umount/Makefile	Thu Jan 28 02:14:45 2010	(r203104)
 +++ stable/8/sbin/umount/Makefile	Thu Jan 28 02:33:20 2010	(r203105)
 @@ -4,7 +4,6 @@
  
  PROG=	umount
  SRCS=	umount.c vfslist.c mounttab.c
 -WARNS?=	0
  MAN=	umount.8
  
  MOUNT=	${.CURDIR}/../mount
 
 Modified: stable/8/sbin/umount/umount.c
 ==============================================================================
 --- stable/8/sbin/umount/umount.c	Thu Jan 28 02:14:45 2010	(r203104)
 +++ stable/8/sbin/umount/umount.c	Thu Jan 28 02:33:20 2010	(r203105)
 @@ -75,7 +75,7 @@ char   **makevfslist (const char *);
  size_t	 mntinfo (struct statfs **);
  int	 namematch (struct addrinfo *);
  int	 parsehexfsid(const char *hex, fsid_t *fsid);
 -int	 sacmp (struct sockaddr *, struct sockaddr *);
 +int	 sacmp (void *, void *);
  int	 umountall (char **);
  int	 checkname (char *, char **);
  int	 umountfs(struct statfs *sfs);
 @@ -225,7 +225,7 @@ umountall(char **typelist)
   * Do magic checks on mountpoint/device/fsid, and then call unmount(2).
   */
  int
 -checkname(char *name, char **typelist)
 +checkname(char *mntname, char **typelist)
  {
  	char buf[MAXPATHLEN];
  	struct statfs sfsbuf;
 @@ -238,25 +238,25 @@ checkname(char *name, char **typelist)
  	/*
  	 * 1. Check if the name exists in the mounttable.
  	 */
 -	sfs = checkmntlist(name);
 +	sfs = checkmntlist(mntname);
  	/*
  	 * 2. Remove trailing slashes if there are any. After that
  	 * we look up the name in the mounttable again.
  	 */
  	if (sfs == NULL) {
 -		len = strlen(name);
 -		while (len > 1 && name[len - 1] == '/')
 -			name[--len] = '\0';
 -		sfs = checkmntlist(name);
 +		len = strlen(mntname);
 +		while (len > 1 && mntname[len - 1] == '/')
 +			mntname[--len] = '\0';
 +		sfs = checkmntlist(mntname);
  	}
  	/*
  	 * 3. Check if the deprecated NFS syntax with an '@' has been used
  	 * and translate it to the ':' syntax. Look up the name in the
  	 * mount table again.
  	 */
 -	if (sfs == NULL && (delimp = strrchr(name, '@')) != NULL) {
 -		snprintf(buf, sizeof(buf), "%s:%.*s", delimp + 1, delimp - name,
 -		    name);
 +	if (sfs == NULL && (delimp = strrchr(mntname, '@')) != NULL) {
 +		snprintf(buf, sizeof(buf), "%s:%.*s", delimp + 1,
 +		    (int)(delimp - mntname), mntname);
  		len = strlen(buf);
  		while (len > 1 && buf[len - 1] == '/')
  			buf[--len] = '\0';
 @@ -271,28 +271,28 @@ checkname(char *name, char **typelist)
  	 * mount list and reality.
  	 * We also do this if an ambiguous mount point was specified.
  	 */
 -	if (sfs == NULL || (getmntentry(NULL, name, NULL, FIND) != NULL &&
 -	    getmntentry(NULL, name, NULL, CHECKUNIQUE) == NULL)) {
 -		if (statfs(name, &sfsbuf) != 0) {
 -			warn("%s: statfs", name);
 -		} else if (stat(name, &sb) != 0) {
 -			warn("%s: stat", name);
 +	if (sfs == NULL || (getmntentry(NULL, mntname, NULL, FIND) != NULL &&
 +	    getmntentry(NULL, mntname, NULL, CHECKUNIQUE) == NULL)) {
 +		if (statfs(mntname, &sfsbuf) != 0) {
 +			warn("%s: statfs", mntname);
 +		} else if (stat(mntname, &sb) != 0) {
 +			warn("%s: stat", mntname);
  		} else if (S_ISDIR(sb.st_mode)) {
 -			/* Check that `name' is the root directory. */
 +			/* Check that `mntname' is the root directory. */
  			dev = sb.st_dev;
 -			snprintf(buf, sizeof(buf), "%s/..", name);
 +			snprintf(buf, sizeof(buf), "%s/..", mntname);
  			if (stat(buf, &sb) != 0) {
  				warn("%s: stat", buf);
  			} else if (sb.st_dev == dev) {
  				warnx("%s: not a file system root directory",
 -				    name);
 +				    mntname);
  				return (1);
  			} else
  				sfs = &sfsbuf;
  		}
  	}
  	if (sfs == NULL) {
 -		warnx("%s: unknown file system", name);
 +		warnx("%s: unknown file system", mntname);
  		return (1);
  	}
  	if (checkvfsname(sfs->f_fstypename, typelist))
 @@ -469,15 +469,16 @@ getmntentry(const char *fromname, const 
  }
  
  int
 -sacmp(struct sockaddr *sa1, struct sockaddr *sa2)
 +sacmp(void *sa1, void *sa2)
  {
  	void *p1, *p2;
  	int len;
  
 -	if (sa1->sa_family != sa2->sa_family)
 +	if (((struct sockaddr *)sa1)->sa_family !=
 +	    ((struct sockaddr *)sa2)->sa_family)
  		return (1);
  
 -	switch (sa1->sa_family) {
 +	switch (((struct sockaddr *)sa1)->sa_family) {
  	case AF_INET:
  		p1 = &((struct sockaddr_in *)sa1)->sin_addr;
  		p2 = &((struct sockaddr_in *)sa2)->sin_addr;
 @@ -520,18 +521,18 @@ namematch(struct addrinfo *ai)
  }
  
  struct statfs *
 -checkmntlist(char *name)
 +checkmntlist(char *mntname)
  {
  	struct statfs *sfs;
  	fsid_t fsid;
  
  	sfs = NULL;
 -	if (parsehexfsid(name, &fsid) == 0)
 +	if (parsehexfsid(mntname, &fsid) == 0)
  		sfs = getmntentry(NULL, NULL, &fsid, FIND);
  	if (sfs == NULL)
 -		sfs = getmntentry(NULL, name, NULL, FIND);
 +		sfs = getmntentry(NULL, mntname, NULL, FIND);
  	if (sfs == NULL)
 -		sfs = getmntentry(name, NULL, NULL, FIND);
 +		sfs = getmntentry(mntname, NULL, NULL, FIND);
  	return (sfs);
  }
  
 
 Modified: stable/8/usr.sbin/rpc.umntall/mounttab.c
 ==============================================================================
 --- stable/8/usr.sbin/rpc.umntall/mounttab.c	Thu Jan 28 02:14:45 2010	(r203104)
 +++ stable/8/usr.sbin/rpc.umntall/mounttab.c	Thu Jan 28 02:33:20 2010	(r203105)
 @@ -45,7 +45,7 @@ __FBSDID("$FreeBSD$");
  
  struct mtablist *mtabhead;
  
 -static void badline(char *field, char *bad);
 +static void badline(const char *field, const char *bad);
  
  /*
   * Add an entry to PATH_MOUNTTAB for each mounted NFS filesystem,
 @@ -69,12 +69,12 @@ add_mtab(char *hostp, char *dirp) {
   * Read mounttab line for line and return struct mtablist.
   */
  int
 -read_mtab() {
 +read_mtab(void) {
  	struct mtablist **mtabpp, *mtabp;
  	char *hostp, *dirp, *cp;
  	char str[STRSIZ];
  	char *timep, *endp;
 -	time_t time;
 +	time_t actiontime;
  	u_long ultmp;
  	FILE *mtabfile;
  
 @@ -86,7 +86,7 @@ read_mtab() {
  			return (0);
  		}
  	}
 -	time = 0;
 +	actiontime = 0;
  	mtabpp = &mtabhead;
  	while (fgets(str, STRSIZ, mtabfile) != NULL) {
  		cp = str;
 @@ -113,13 +113,13 @@ read_mtab() {
  			badline("time", timep);
  			continue;
  		}
 -		time = ultmp;
 +		actiontime = ultmp;
  		if ((mtabp = malloc(sizeof (struct mtablist))) == NULL) {
  			syslog(LOG_ERR, "malloc");
  			fclose(mtabfile);
  			return (0);
  		}
 -		mtabp->mtab_time = time;
 +		mtabp->mtab_time = actiontime;
  		memmove(mtabp->mtab_host, hostp, MNTNAMLEN);
  		mtabp->mtab_host[MNTNAMLEN - 1] = '\0';
  		memmove(mtabp->mtab_dirp, dirp, MNTPATHLEN);
 @@ -218,7 +218,7 @@ free_mtab() {
   * Print bad lines to syslog.
   */
  static void
 -badline(char *field, char *bad) {
 +badline(const char *field, const char *bad) {
  	syslog(LOG_ERR, "bad mounttab %s field '%s'", field,
  	    (bad == NULL) ? "<null>" : bad);
  }
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
