From uqs@spoerlein.net  Mon Oct 26 20:09:50 2009
Return-Path: <uqs@spoerlein.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9FDD31065670
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Oct 2009 20:09:50 +0000 (UTC)
	(envelope-from uqs@spoerlein.net)
Received: from acme.spoerlein.net (cl-43.dus-01.de.sixxs.net [IPv6:2a01:198:200:2a::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 207498FC14
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Oct 2009 20:09:49 +0000 (UTC)
Received: from roadrunner.spoerlein.net (pD9E5C51D.dip.t-dialin.net [217.229.197.29])
	by acme.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9QK9iY5063462
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Oct 2009 21:09:48 +0100 (CET)
	(envelope-from uqs@spoerlein.net)
Received: from roadrunner.spoerlein.net (localhost [127.0.0.1])
	by roadrunner.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9QJ0AmP024264
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 26 Oct 2009 20:00:10 +0100 (CET)
	(envelope-from uqs@roadrunner.spoerlein.net)
Received: (from uqs@localhost)
	by roadrunner.spoerlein.net (8.14.3/8.14.3/Submit) id n9QJ09Iu024263;
	Mon, 26 Oct 2009 20:00:10 +0100 (CET)
	(envelope-from uqs)
Message-Id: <200910261900.n9QJ09Iu024263@roadrunner.spoerlein.net>
Date: Mon, 26 Oct 2009 20:00:10 +0100 (CET)
From: Ulrich Spoerlein <uqs@spoerlein.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: mount_ntfs(8) WARNS6 cleanup
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         140000
>Category:       bin
>Synopsis:       [patch] mount_ntfs(8) WARNS6 cleanup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    uqs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 26 20:10:02 UTC 2009
>Closed-Date:    Sat Feb 27 10:40:15 UTC 2010
>Last-Modified:  Sat Feb 27 10:40:15 UTC 2010
>Originator:     Ulrich Spoerlein
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
>Environment:
	
>Description:
Bump to WARNS=6 after ANSI cleanup
>How-To-Repeat:
	
>Fix:

	

--- mount_ntfs.diff begins here ---
diff -r 118f7806d635 -r 5558195fb93d sbin/mount_ntfs/Makefile
--- a/sbin/mount_ntfs/Makefile	Mon Oct 26 19:51:42 2009 +0100
+++ b/sbin/mount_ntfs/Makefile	Mon Oct 26 19:57:23 2009 +0100
@@ -9,8 +9,7 @@
 LDADD=	-lkiconv
 
 MOUNT=	${.CURDIR}/../mount
-CFLAGS+=-I${MOUNT}
-WARNS?=	0
+CFLAGS+= -I${MOUNT}
 
 # Needs to be dynamically linked for optional dlopen() access to
 # userland libiconv
diff -r 118f7806d635 -r 5558195fb93d sbin/mount_ntfs/mount_ntfs.c
--- a/sbin/mount_ntfs/mount_ntfs.c	Mon Oct 26 19:51:42 2009 +0100
+++ b/sbin/mount_ntfs/mount_ntfs.c	Mon Oct 26 19:57:23 2009 +0100
@@ -69,9 +69,7 @@
 static int	set_charset(struct ntfs_args *);
 
 int
-main(argc, argv)
-	int argc;
-	char **argv;
+main(int argc, char *argv[])
 {
 	struct ntfs_args args;
 	struct stat sb;
@@ -193,8 +191,7 @@
 }
 
 gid_t
-a_gid(s)
-	char *s;
+a_gid(char *s)
 {
 	struct group *gr;
 	char *gname;
@@ -213,8 +210,7 @@
 }
 
 uid_t
-a_uid(s)
-	char *s;
+a_uid(char *s)
 {
 	struct passwd *pw;
 	char *uname;
@@ -233,8 +229,7 @@
 }
 
 mode_t
-a_mask(s)
-	char *s;
+a_mask(char *s)
 {
 	int done, rv=0;
 	char *ep;
@@ -250,7 +245,7 @@
 }
 
 void
-usage()
+usage(void)
 {
 #ifdef TRANSITION_PERIOD_HACK
 	fprintf(stderr, "%s\n%s\n",
--- mount_ntfs.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->uqs 
Responsible-Changed-By: uqs 
Responsible-Changed-When: Thu Feb 4 08:24:13 UTC 2010 
Responsible-Changed-Why:  
Take my own PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140000 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/140000: commit references a PR
Date: Sat, 27 Feb 2010 10:16:28 +0000 (UTC)

 Author: uqs
 Date: Sat Feb 27 10:16:14 2010
 New Revision: 204404
 URL: http://svn.freebsd.org/changeset/base/204404
 
 Log:
   mount_ntfs(8): make WARNS=6 clean
   
   PR:		bin/140000
   Approved by:	ed (co-mentor)
 
 Modified:
   head/sbin/mount_ntfs/Makefile
   head/sbin/mount_ntfs/mount_ntfs.c
 
 Modified: head/sbin/mount_ntfs/Makefile
 ==============================================================================
 --- head/sbin/mount_ntfs/Makefile	Sat Feb 27 10:14:59 2010	(r204403)
 +++ head/sbin/mount_ntfs/Makefile	Sat Feb 27 10:16:14 2010	(r204404)
 @@ -9,8 +9,7 @@ DPADD=	${LIBKICONV}
  LDADD=	-lkiconv
  
  MOUNT=	${.CURDIR}/../mount
 -CFLAGS+=-I${MOUNT}
 -WARNS?=	0
 +CFLAGS+= -I${MOUNT}
  
  # Needs to be dynamically linked for optional dlopen() access to
  # userland libiconv
 
 Modified: head/sbin/mount_ntfs/mount_ntfs.c
 ==============================================================================
 --- head/sbin/mount_ntfs/mount_ntfs.c	Sat Feb 27 10:14:59 2010	(r204403)
 +++ head/sbin/mount_ntfs/mount_ntfs.c	Sat Feb 27 10:16:14 2010	(r204404)
 @@ -69,9 +69,7 @@ static void	usage(void) __dead2;
  static int	set_charset(struct ntfs_args *);
  
  int
 -main(argc, argv)
 -	int argc;
 -	char **argv;
 +main(int argc, char *argv[])
  {
  	struct ntfs_args args;
  	struct stat sb;
 @@ -193,8 +191,7 @@ main(argc, argv)
  }
  
  gid_t
 -a_gid(s)
 -	char *s;
 +a_gid(char *s)
  {
  	struct group *gr;
  	char *gname;
 @@ -213,8 +210,7 @@ a_gid(s)
  }
  
  uid_t
 -a_uid(s)
 -	char *s;
 +a_uid(char *s)
  {
  	struct passwd *pw;
  	char *uname;
 @@ -233,8 +229,7 @@ a_uid(s)
  }
  
  mode_t
 -a_mask(s)
 -	char *s;
 +a_mask(char *s)
  {
  	int done, rv=0;
  	char *ep;
 @@ -250,7 +245,7 @@ a_mask(s)
  }
  
  void
 -usage()
 +usage(void)
  {
  #ifdef TRANSITION_PERIOD_HACK
  	fprintf(stderr, "%s\n%s\n",
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: uqs 
State-Changed-When: Sat Feb 27 10:40:14 UTC 2010 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=140000 
>Unformatted:
