From uqs@spoerlein.net  Mon Oct 26 18:54:52 2009
Return-Path: <uqs@spoerlein.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B83F11065679
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Oct 2009 18:54:52 +0000 (UTC)
	(envelope-from uqs@spoerlein.net)
Received: from acme.spoerlein.net (cl-43.dus-01.de.sixxs.net [IPv6:2a01:198:200:2a::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 37A228FC0A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Oct 2009 18:54:52 +0000 (UTC)
Received: from roadrunner.spoerlein.net (pD9E5C51D.dip.t-dialin.net [217.229.197.29])
	by acme.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9QIsnmh061711
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Oct 2009 19:54:51 +0100 (CET)
	(envelope-from uqs@spoerlein.net)
Received: from roadrunner.spoerlein.net (localhost [127.0.0.1])
	by roadrunner.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9QIseO6016428
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 26 Oct 2009 19:54:40 +0100 (CET)
	(envelope-from uqs@roadrunner.spoerlein.net)
Received: (from uqs@localhost)
	by roadrunner.spoerlein.net (8.14.3/8.14.3/Submit) id n9QIsese016410;
	Mon, 26 Oct 2009 19:54:40 +0100 (CET)
	(envelope-from uqs)
Message-Id: <200910261854.n9QIsese016410@roadrunner.spoerlein.net>
Date: Mon, 26 Oct 2009 19:54:40 +0100 (CET)
From: Ulrich Spoerlein <uqs@spoerlein.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: mount_hpfs(8): WARNS6 cleanup
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         139995
>Category:       bin
>Synopsis:       [patch] mount_hpfs(8): WARNS6 cleanup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    uqs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 26 19:00:05 UTC 2009
>Closed-Date:    Sat Feb 27 10:40:04 UTC 2010
>Last-Modified:  Sat Feb 27 10:40:04 UTC 2010
>Originator:     Ulrich Spoerlein
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
>Environment:
	
>Description:
ANSIfy, set WARNS=6, profit!
>How-To-Repeat:
	
>Fix:

--- mount_hpfs.diff begins here ---
diff -r bf8c6ec4b2b6 -r 118f7806d635 sbin/mount_hpfs/Makefile
--- a/sbin/mount_hpfs/Makefile	Mon Oct 26 19:31:00 2009 +0100
+++ b/sbin/mount_hpfs/Makefile	Mon Oct 26 19:51:42 2009 +0100
@@ -7,8 +7,7 @@
 MAN=	mount_hpfs.8
 
 MOUNT=	${.CURDIR}/../mount
-CFLAGS+=-I${MOUNT} -DHPFS
-WARNS?=	0
+CFLAGS+= -I${MOUNT} -DHPFS
 
 .PATH:	${MOUNT}
 
diff -r bf8c6ec4b2b6 -r 118f7806d635 sbin/mount_hpfs/mount_hpfs.c
--- a/sbin/mount_hpfs/mount_hpfs.c	Mon Oct 26 19:31:00 2009 +0100
+++ b/sbin/mount_hpfs/mount_hpfs.c	Mon Oct 26 19:51:42 2009 +0100
@@ -60,9 +60,7 @@
 static void	load_u2wtable(struct hpfs_args *, char *);
 
 int
-main(argc, argv)
-	int argc;
-	char **argv;
+main(int argc, char *argv[])
 {
 	struct hpfs_args args;
 	struct stat sb;
@@ -150,8 +148,7 @@
 }
 
 gid_t
-a_gid(s)
-	char *s;
+a_gid(char *s)
 {
 	struct group *gr;
 	char *gname;
@@ -170,8 +167,7 @@
 }
 
 uid_t
-a_uid(s)
-	char *s;
+a_uid(char *s)
 {
 	struct passwd *pw;
 	char *uname;
@@ -190,8 +186,7 @@
 }
 
 mode_t
-a_mask(s)
-	char *s;
+a_mask(char *s)
 {
 	int done, rv=0;
 	char *ep;
@@ -207,16 +202,14 @@
 }
 
 void
-usage()
+usage(void)
 {
 	fprintf(stderr, "usage: mount_hpfs [-u user] [-g group] [-m mask] bdev dir\n");
 	exit(EX_USAGE);
 }
 
 void
-load_u2wtable (pargs, name)
-	struct hpfs_args *pargs;
-	char *name;
+load_u2wtable (struct hpfs_args *pargs, char *name)
 {
 	FILE *f;
 	int i, code;
--- mount_hpfs.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->uqs 
Responsible-Changed-By: uqs 
Responsible-Changed-When: Thu Feb 4 08:23:44 UTC 2010 
Responsible-Changed-Why:  
Take my own PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139995 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/139995: commit references a PR
Date: Sat, 27 Feb 2010 10:15:14 +0000 (UTC)

 Author: uqs
 Date: Sat Feb 27 10:14:59 2010
 New Revision: 204403
 URL: http://svn.freebsd.org/changeset/base/204403
 
 Log:
   mount_hpfs(8): make WARNS=6 clean
   
   PR:		bin/139995
   Approved by:	ed (co-mentor)
 
 Modified:
   head/sbin/mount_hpfs/Makefile
   head/sbin/mount_hpfs/mount_hpfs.c
 
 Modified: head/sbin/mount_hpfs/Makefile
 ==============================================================================
 --- head/sbin/mount_hpfs/Makefile	Sat Feb 27 07:12:25 2010	(r204402)
 +++ head/sbin/mount_hpfs/Makefile	Sat Feb 27 10:14:59 2010	(r204403)
 @@ -7,8 +7,7 @@ SRCS=	mount_hpfs.c getmntopts.c
  MAN=	mount_hpfs.8
  
  MOUNT=	${.CURDIR}/../mount
 -CFLAGS+=-I${MOUNT} -DHPFS
 -WARNS?=	0
 +CFLAGS+= -I${MOUNT} -DHPFS
  
  .PATH:	${MOUNT}
  
 
 Modified: head/sbin/mount_hpfs/mount_hpfs.c
 ==============================================================================
 --- head/sbin/mount_hpfs/mount_hpfs.c	Sat Feb 27 07:12:25 2010	(r204402)
 +++ head/sbin/mount_hpfs/mount_hpfs.c	Sat Feb 27 10:14:59 2010	(r204403)
 @@ -60,9 +60,7 @@ static void	usage(void) __dead2;
  static void	load_u2wtable(struct hpfs_args *, char *);
  
  int
 -main(argc, argv)
 -	int argc;
 -	char **argv;
 +main(int argc, char *argv[])
  {
  	struct hpfs_args args;
  	struct stat sb;
 @@ -150,8 +148,7 @@ main(argc, argv)
  }
  
  gid_t
 -a_gid(s)
 -	char *s;
 +a_gid(char *s)
  {
  	struct group *gr;
  	char *gname;
 @@ -170,8 +167,7 @@ a_gid(s)
  }
  
  uid_t
 -a_uid(s)
 -	char *s;
 +a_uid(char *s)
  {
  	struct passwd *pw;
  	char *uname;
 @@ -190,8 +186,7 @@ a_uid(s)
  }
  
  mode_t
 -a_mask(s)
 -	char *s;
 +a_mask(char *s)
  {
  	int done, rv=0;
  	char *ep;
 @@ -207,16 +202,14 @@ a_mask(s)
  }
  
  void
 -usage()
 +usage(void)
  {
  	fprintf(stderr, "usage: mount_hpfs [-u user] [-g group] [-m mask] bdev dir\n");
  	exit(EX_USAGE);
  }
  
  void
 -load_u2wtable (pargs, name)
 -	struct hpfs_args *pargs;
 -	char *name;
 +load_u2wtable (struct hpfs_args *pargs, char *name)
  {
  	FILE *f;
  	int i, code;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->closed 
State-Changed-By: uqs 
State-Changed-When: Sat Feb 27 10:40:02 UTC 2010 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139995 
>Unformatted:
