From uqs@spoerlein.net  Sun Oct 25 15:46:17 2009
Return-Path: <uqs@spoerlein.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7E1A61065670;
	Sun, 25 Oct 2009 15:46:17 +0000 (UTC)
	(envelope-from uqs@spoerlein.net)
Received: from acme.spoerlein.net (cl-43.dus-01.de.sixxs.net [IPv6:2a01:198:200:2a::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 0BF638FC13;
	Sun, 25 Oct 2009 15:46:16 +0000 (UTC)
Received: from roadrunner.spoerlein.net (pD9E5E066.dip.t-dialin.net [217.229.224.102])
	by acme.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9PFkEmr026050
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Sun, 25 Oct 2009 16:46:15 +0100 (CET)
	(envelope-from uqs@spoerlein.net)
Received: from roadrunner.spoerlein.net (localhost [127.0.0.1])
	by roadrunner.spoerlein.net (8.14.3/8.14.3) with ESMTP id n9PFk1nH082518
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sun, 25 Oct 2009 16:46:01 +0100 (CET)
	(envelope-from uqs@roadrunner.spoerlein.net)
Received: (from uqs@localhost)
	by roadrunner.spoerlein.net (8.14.3/8.14.3/Submit) id n9PFk11Q082516;
	Sun, 25 Oct 2009 16:46:01 +0100 (CET)
	(envelope-from uqs)
Message-Id: <200910251546.n9PFk11Q082516@roadrunner.spoerlein.net>
Date: Sun, 25 Oct 2009 16:46:01 +0100 (CET)
From: Ulrich Spörlein <uqs@spoerlein.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Marcel Moolenaar <marcel@freebsd.org>
Subject: sbin/geom/class/part: WARNS6 cleanup
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         139970
>Category:       bin
>Synopsis:       gpart(8): WARNS=6 cleanups in bin/geom/class/part
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-geom
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 25 16:00:21 UTC 2009
>Closed-Date:    Mon Oct 26 07:49:48 UTC 2009
>Last-Modified:  Fri Nov 12 20:54:52 UTC 2010
>Originator:     Ulrich Spoerlein
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
>Environment:
	
>Description:
The warning produced by GCC is bogus, but it does not grok the twisted logic.
Plaster over it with an explicit initialization and bump WARNS accordingly
>How-To-Repeat:
	
>Fix:
	

diff -r d1a04723c41c -r dabb79c85f13 sbin/geom/class/part/Makefile
--- a/sbin/geom/class/part/Makefile	Fri Oct 23 15:14:54 2009 +0000
+++ b/sbin/geom/class/part/Makefile	Fri Oct 23 10:34:06 2009 +0200
@@ -6,6 +6,4 @@
 
 LDADD=	-lutil
 
-WARNS?=	4
-
 .include <bsd.lib.mk>
diff -r d1a04723c41c -r dabb79c85f13 sbin/geom/class/part/geom_part.c
--- a/sbin/geom/class/part/geom_part.c	Fri Oct 23 15:14:54 2009 +0000
+++ b/sbin/geom/class/part/geom_part.c	Fri Oct 23 10:34:06 2009 +0200
@@ -192,6 +192,7 @@
 	unsigned long long sector, bestsector;
 
 	bestpp = NULL;
+	bestsector = 0;
 	LIST_FOREACH(pp, &gp->lg_provider, lg_provider) {
 		s = find_provcfg(pp, "start");
 		if (s == NULL) {
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-geom 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Sun Oct 25 20:05:41 UTC 2009 
Responsible-Changed-Why:  
Over to maintainer(s) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139970 
State-Changed-From-To: open->closed 
State-Changed-By: lulf 
State-Changed-When: Mon Oct 26 07:49:14 UTC 2009 
State-Changed-Why:  
- Patch committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=139970 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/139970: commit references a PR
Date: Mon, 26 Oct 2009 07:43:56 +0000 (UTC)

 Author: lulf
 Date: Mon Oct 26 07:43:41 2009
 New Revision: 198478
 URL: http://svn.freebsd.org/changeset/base/198478
 
 Log:
   - Initialize variable in order to avoid GCC warning and enable WARNS=6.
   
   PR:		bin/139970
   Submitted by:	Ulrich Spörlein <uqs -at- spoerlein.net>
 
 Modified:
   head/sbin/geom/class/part/Makefile
   head/sbin/geom/class/part/geom_part.c
 
 Modified: head/sbin/geom/class/part/Makefile
 ==============================================================================
 --- head/sbin/geom/class/part/Makefile	Mon Oct 26 06:51:20 2009	(r198477)
 +++ head/sbin/geom/class/part/Makefile	Mon Oct 26 07:43:41 2009	(r198478)
 @@ -6,6 +6,4 @@ CLASS=	part
  
  LDADD=	-lutil
  
 -WARNS?=	4
 -
  .include <bsd.lib.mk>
 
 Modified: head/sbin/geom/class/part/geom_part.c
 ==============================================================================
 --- head/sbin/geom/class/part/geom_part.c	Mon Oct 26 06:51:20 2009	(r198477)
 +++ head/sbin/geom/class/part/geom_part.c	Mon Oct 26 07:43:41 2009	(r198478)
 @@ -192,6 +192,7 @@ find_provider(struct ggeom *gp, unsigned
  	unsigned long long sector, bestsector;
  
  	bestpp = NULL;
 +	bestsector = 0;
  	LIST_FOREACH(pp, &gp->lg_provider, lg_provider) {
  		s = find_provcfg(pp, "start");
  		if (s == NULL) {
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/139970: commit references a PR
Date: Tue, 22 Jun 2010 18:24:56 +0000 (UTC)

 Author: ae
 Date: Tue Jun 22 18:24:26 2010
 New Revision: 209434
 URL: http://svn.freebsd.org/changeset/base/209434
 
 Log:
   MFC r198478 (by lulf):
   - Initialize variable in order to avoid GCC warning and enable WARNS=6.
   
   PR:		bin/139970
   Submitted by:	Ulrich Spörlein <uqs -at- spoerlein.net>
   Approved by:	kib (mentor)
 
 Modified:
   stable/8/sbin/geom/class/part/Makefile
   stable/8/sbin/geom/class/part/geom_part.c
 Directory Properties:
   stable/8/sbin/geom/   (props changed)
   stable/8/sbin/geom/class/part/   (props changed)
   stable/8/sbin/geom/class/stripe/   (props changed)
 
 Modified: stable/8/sbin/geom/class/part/Makefile
 ==============================================================================
 --- stable/8/sbin/geom/class/part/Makefile	Tue Jun 22 17:45:21 2010	(r209433)
 +++ stable/8/sbin/geom/class/part/Makefile	Tue Jun 22 18:24:26 2010	(r209434)
 @@ -6,6 +6,4 @@ CLASS=	part
  
  LDADD=	-lutil
  
 -WARNS?=	4
 -
  .include <bsd.lib.mk>
 
 Modified: stable/8/sbin/geom/class/part/geom_part.c
 ==============================================================================
 --- stable/8/sbin/geom/class/part/geom_part.c	Tue Jun 22 17:45:21 2010	(r209433)
 +++ stable/8/sbin/geom/class/part/geom_part.c	Tue Jun 22 18:24:26 2010	(r209434)
 @@ -206,6 +206,7 @@ find_provider(struct ggeom *gp, unsigned
  	unsigned long long sector, bestsector;
  
  	bestpp = NULL;
 +	bestsector = 0;
  	LIST_FOREACH(pp, &gp->lg_provider, lg_provider) {
  		s = find_provcfg(pp, "start");
  		if (s == NULL) {
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
