From matusita@jp.FreeBSD.org Thu Sep 23 10:12:25 1999
Return-Path: <matusita@jp.FreeBSD.org>
Received: from martini.ics.es.osaka-u.ac.jp (martini.ics.es.osaka-u.ac.jp [133.1.12.150])
	by hub.freebsd.org (Postfix) with ESMTP
	id 113B415F29; Thu, 23 Sep 1999 10:12:22 -0700 (PDT)
	(envelope-from matusita@jp.FreeBSD.org)
Received: from localhost (localhost [127.0.0.1])
	by martini.ics.es.osaka-u.ac.jp (8.9.3/3.7W/INO-1.0v8-SLAVE) with ESMTP id CAA68731;
	Fri, 24 Sep 1999 02:12:16 +0900 (JST)
Message-Id: <19990924021214U.matusita@jp.FreeBSD.org>
Date: Fri, 24 Sep 1999 02:12:14 +0900
From: Makoto MATSUSHITA <matusita@jp.FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jkh@freebsd.org
Subject: 'make release' fails in some cases
X-Send-Pr-Version: 3.2

>Number:         13919
>Category:       bin
>Synopsis:       'make release' fails in some cases
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 23 10:20:01 PDT 1999
>Closed-Date:    Thu Sep 23 20:19:01 PDT 1999
>Last-Modified:  Thu Sep 23 20:19:56 PDT 1999
>Originator:     Makoto MATSUSHITA
>Release:        FreeBSD 4.0-CURRENT i386
>Organization:
Japan FreeBSD Users' Group
>Environment:

	4.0-CURRENT (and potentially 3.3-STABLE)

>Description:

	target 'release.1' of src/release/Makefile says:

		# Clean out ${_R} and make the directory structure.
		release.1:
			mkdir -p ${_R}
			rm -rf ${_R}/* 2> /dev/null
			-chflags -R noschg ${_R}/.
			rm -rf ${_R}/*

	"mkdir -p, rm -rf, chflags, then rm -rf again" is the common
	way to get clean directory. In this way, the first rm(1) may
	exit with non-zero status; but this Makefile does not consider
	such a situation.

	I dunno when, but current 4.0-RELEASE of ${_R}/stage/trees has
	some schg-ed files (3.3-STABLE does not have such files).

>How-To-Repeat:

	do 'make release' twice.

>Fix:
	
	Ignore exit status of first rm(1), maybe.

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed  
State-Changed-By: cpiazza 
State-Changed-When: Thu Sep 23 20:19:01 PDT 1999 
State-Changed-Why:  
Fixed by jkh in rev 1.514 of release/Makefile.  Thanks for noticing! 
>Unformatted:
