From root@amigo.faf.fa.disney.com Tue Sep 21 11:46:51 1999
Return-Path: <root@amigo.faf.fa.disney.com>
Received: from mail.disney.com (mail.disney.com [204.128.192.15])
	by hub.freebsd.org (Postfix) with ESMTP id 6CE4E14A0B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 21 Sep 1999 11:46:37 -0700 (PDT)
	(envelope-from root@amigo.faf.fa.disney.com)
Received: from pain10.corp.disney.com (root@pain10.corp.disney.com [153.7.110.100])
	by mail.disney.com (8.9.1/8.9.1) with SMTP id LAA26859
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 21 Sep 1999 11:46:36 -0700 (PDT)
Received: from louie.fa.disney.com by pain.corp.disney.com with ESMTP for FreeBSD-gnats-submit@freebsd.org; Tue, 21 Sep 1999 11:46:48 -0700
Received: from snowhite.faf.fa.disney.com (snowhite.faf.fa.disney.com [153.7.115.1])
	by louie.fa.disney.com (8.9.2/8.9.2) with ESMTP id LAA03804
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 21 Sep 1999 11:46:35 -0700 (PDT)
	(envelope-from root@amigo.faf.fa.disney.com)
Received: from amigo.faf.fa.disney.com (amigo.faf.fa.disney.com [153.7.115.94])
	by snowhite.faf.fa.disney.com (8.9.2/8.9.2) with ESMTP id OAA28477
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 21 Sep 1999 14:46:34 -0400 (EDT)
	(envelope-from root@amigo.faf.fa.disney.com)
Received: (from root@localhost)
	by amigo.faf.fa.disney.com (8.9.3/8.9.2) id OAA85260;
	Tue, 21 Sep 1999 14:46:34 -0400 (EDT)
	(envelope-from root@amigo.faf.fa.disney.com)
Message-Id: <199909211846.OAA85260@amigo.faf.fa.disney.com>
Date: Tue, 21 Sep 1999 14:46:34 -0400 (EDT)
From: Jim.Pirzyk@disney.com
Sender: root@amigo.faf.fa.disney.com
Reply-To: Jim.Pirzyk@disney.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: Missing mount options when specifing 'mount -p'
X-Send-Pr-Version: 3.2

>Number:         13882
>Category:       bin
>Synopsis:       mount(8) mount -p is missing the quota options
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 21 11:50:01 PDT 1999
>Closed-Date:    
>Last-Modified:  Wed May 21 20:39:29 UTC 2008
>Originator:     Jim Pirzyk
>Release:        FreeBSD 3.3-RELEASE i386
>Organization:
>Environment:

	Have a filesystem mounted with the quota's options on.  Then mount -p
	will not keep the fstab options displayed

>Description:

	Here is my fstab file:

# Device			Mountpoint	FStype	Options				Dump	Pass#
/dev/wd0s1b		none			swap		sw					0	0
/dev/wd0s1a		/			ufs		rw					1	1
/dev/wd0s1e		/tmp			mfs		rw,nosuid,nodev		2	2
/dev/wcd0c		/cdrom		cd9660	ro,noauto				0	0
/dev/vinum/garage	/export		ufs		rw,nosuid,nodev,userquota 2	2
proc				/proc		procfs	rw					0	0

	Note that /export is mounted with userquota.  When 'mount -p' is run,
	this is the output:

/dev/wd0s1a	/	ufs rw	1 1
mfs:31	/tmp	mfs rw,nosuid,nodev,async	2 2
/dev/vinum/garage	/export	ufs rw,nosuid,nodev	2 2
procfs	/proc	procfs rw	0 0

>How-To-Repeat:

	Mount a filesystem with quotas on, then do a 'mount -p'

>Fix:
	
	


>Release-Note:
>Audit-Trail:

From: "Stephen J. Roznowski" <sjr@home.net>
To: Jim.Pirzyk@disney.com
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/13882: Missing mount options when specifing 'mount -p'
Date: Tue, 21 Sep 1999 23:27:24 -0400 (EDT)

 On 21 Sep, Jim.Pirzyk@disney.com wrote:
 
 >>Fix:
 
 This seems easy to fix (including the other missing options):
 
 --- mount.c.orig	Tue Sep 21 23:17:00 1999
 +++ mount.c	Tue Sep 21 23:21:36 1999
 @@ -721,6 +721,10 @@
  	if (flags & MNT_NOCLUSTERW)	res = catopt(res, "noclusterw");
  	if (flags & MNT_NOSYMFOLLOW)	res = catopt(res, "nosymfollow");
  	if (flags & MNT_SUIDDIR)	res = catopt(res, "suiddir");
 +	if (flags & MOPT_USERQUOTA)	res = catopt(res, "userquota");
 +	if (flags & MOPT_GROUPQUOTA)	res = catopt(res, "groupquota");
 +	if (flags & MOPT_NOCLUSTERR)	res = catopt(res, "noclusterr");
 +	if (flags & MOPT_NOCLUSTERW)	res = catopt(res, "noclusterw");
  
  	return res;
  }
 
 
 

From: "Stephen J. Roznowski" <sjr@home.net>
To: FreeBSD-gnats-submit@FreeBSD.ORG
Cc:  
Subject: Re: bin/13882: Missing mount options when specifing 'mount -p'
Date: Thu, 23 Sep 1999 21:29:15 -0400 (EDT)

 Apparently, the fix wasn't as easy as I thought.... The attached
 patch fixes two missing options, but still doesn't handle
 the quota options.
 
 --- mount.c.orig	Tue Sep 21 23:17:00 1999
 +++ mount.c	Thu Sep 23 21:14:05 1999
 @@ -721,6 +721,8 @@
  	if (flags & MNT_NOCLUSTERW)	res = catopt(res, "noclusterw");
  	if (flags & MNT_NOSYMFOLLOW)	res = catopt(res, "nosymfollow");
  	if (flags & MNT_SUIDDIR)	res = catopt(res, "suiddir");
 +	if (flags & MNT_NOCLUSTERR)	res = catopt(res, "noclusterr");
 +	if (flags & MNT_NOCLUSTERW)	res = catopt(res, "noclusterw");
  
  	return res;
  }
 
 
 
Responsible-Changed-From-To: freebsd-bugs->pirzyk 
Responsible-Changed-By: pirzyk 
Responsible-Changed-When: Thu Jul 19 17:36:42 PDT 2001 
Responsible-Changed-Why:  
my PR 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=13882 
Responsible-Changed-From-To: pirzyk->freebsd-bugs 
Responsible-Changed-By: arved 
Responsible-Changed-When: Fri Apr 23 07:21:04 PDT 2004 
Responsible-Changed-Why:  
jim pirzyk returned his commit bit one year ago 

http://www.freebsd.org/cgi/query-pr.cgi?pr=13882 
>Unformatted:
