From chris@amnesiac.bayofrum.net  Sun Jul 26 14:39:47 2009
Return-Path: <chris@amnesiac.bayofrum.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F17D8106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 26 Jul 2009 14:39:47 +0000 (UTC)
	(envelope-from chris@amnesiac.bayofrum.net)
Received: from amnesiac.bayofrum.net (dyn-62-56-89-27.dslaccess.co.uk [62.56.89.27])
	by mx1.freebsd.org (Postfix) with ESMTP id 159C48FC08
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 26 Jul 2009 14:39:41 +0000 (UTC)
	(envelope-from chris@amnesiac.bayofrum.net)
Received: from amnesiac.bayofrum.net (localhost [127.0.0.1])
	by amnesiac.bayofrum.net (8.14.3/8.14.3) with ESMTP id n6QEdOQI005900
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 26 Jul 2009 15:39:30 +0100 (BST)
	(envelope-from chris@amnesiac.bayofrum.net)
Received: (from chris@localhost)
	by amnesiac.bayofrum.net (8.14.3/8.14.3/Submit) id n6QEdOPR005899;
	Sun, 26 Jul 2009 15:39:24 +0100 (BST)
	(envelope-from chris)
Message-Id: <200907261439.n6QEdOPR005899@amnesiac.bayofrum.net>
Date: Sun, 26 Jul 2009 15:39:24 +0100 (BST)
From: Chris Rees <utisoft@gmail.com>
Reply-To: Chris Rees <utisoft@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Dump cryptic output on reporting progress
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         137156
>Category:       bin
>Synopsis:       [patch] fix dump(8) cryptic output on reporting progress
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-doc
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jul 26 14:40:01 UTC 2009
>Closed-Date:    Sun Mar 13 13:56:44 EST 2011
>Last-Modified:  Sun Mar 13 13:56:44 EST 2011
>Originator:     Chris Rees
>Release:        FreeBSD 7.2-RELEASE i386
>Organization:
bayofrum.net
>Environment:
System: FreeBSD amnesiac.bayofrum.net 7.2-RELEASE FreeBSD 7.2-RELEASE #1: Sun May 3 21:54:38 BST 2009 root@amnesiac.bayofrum.net:/usr/obj/usr/src/sys/AMNESIAC i386

>Description:
	When dump has a large amount of data to process, it gives output like this:

DUMP: finished in 41 seconds, throughput 5475 KBytes/sec

	Wouldn't 'finishes' be more appropriate? I've attached a patch to this effect... It took me a while to understand what it meant, and I still think that 'finished' makes no sense.

>How-To-Repeat:
	Dump a large filesystem
>Fix:

--- dump.diff begins here ---
--- /usr/src/sbin/dump/optr.c	2006-08-06 15:23:50.000000000 +0100
+++ optr.c	2008-06-08 23:16:44.000000000 +0100
@@ -195,10 +195,10 @@
 
 	(void)time(&tnow);
 	if (blockswritten > tapesize) {
-		setproctitle("%s: 99.99%% done, finished soon", disk);
+		setproctitle("%s: 99.99%% done, finishes soon", disk);
 		if (tnow >= tschedule) {
 			tschedule = tnow + 300;
-			msg("99.99%% done, finished soon\n");
+			msg("99.99%% done, finishes soon\n");
 		}
 	} else {
 		deltat = (blockswritten == 0) ? 0 : tstart_writing - tnow +
@@ -211,13 +211,13 @@
 		tdone_str = ctime(&tdone);
 		tdone_str[strlen(tdone_str) - 1] = '\0';
 		setproctitle(
-		    "%s: pass %d: %3.2f%% done, finished in %d:%02d at %s",
+		    "%s: pass %d: %3.2f%% done, finishes in %d:%02d at %s",
 		    disk, passno, percent, hours, mins, tdone_str);
 		if (tnow >= tschedule) {
 			tschedule = tnow + 300;
 			if (blockswritten < 500)
 				return;
-			msg("%3.2f%% done, finished in %d:%02d at %s\n", percent,
+			msg("%3.2f%% done, finishes in %d:%02d at %s\n", percent,
 			    hours, mins, tdone_str);
 		}
 	}
--- dump.diff ends here ---


>Release-Note:
>Audit-Trail:

From: Chris Rees <utisoft@gmail.com>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: bin/137156: [patch] fix dump(8) cryptic output on reporting 
	progress
Date: Sat, 24 Jul 2010 19:46:08 +0100

 Since no-one wants to commit this, perhaps this PR should be closed
 then? I'd hate to have caused yet another hanging report....
 
 Thanks,
 
 Chris
Responsible-Changed-From-To: freebsd-bugs->freebsd-docs 
Responsible-Changed-By: arundel 
Responsible-Changed-When: Sun Nov 14 01:26:12 UTC 2010 
Responsible-Changed-Why:  
Over to freebsd-docs@. Sorry your PR sat idle for so long. I'll see what I can 
do in order to get it committed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137156 
Responsible-Changed-From-To: freebsd-docs->freebsd-doc 
Responsible-Changed-By: arundel 
Responsible-Changed-When: Wed Nov 17 23:14:37 UTC 2010 
Responsible-Changed-Why:  
Fix responsible party. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137156 
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Sun Mar 13 13:56:09 EST 2011 
State-Changed-Why:  
might break amanda; submitter request 

http://www.freebsd.org/cgi/query-pr.cgi?pr=137156 
>Unformatted:
