From wollman@khavrinen.lcs.mit.edu Thu Sep  9 20:50:42 1999
Return-Path: <wollman@khavrinen.lcs.mit.edu>
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by hub.freebsd.org (Postfix) with ESMTP id 6ADB414C37
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  9 Sep 1999 20:50:40 -0700 (PDT)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.9.1/8.9.1) id XAA24216;
	Thu, 9 Sep 1999 23:50:40 -0400 (EDT)
	(envelope-from wollman)
Message-Id: <199909100350.XAA24216@khavrinen.lcs.mit.edu>
Date: Thu, 9 Sep 1999 23:50:40 -0400 (EDT)
From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Reply-To: wollman@khavrinen.lcs.mit.edu
To: FreeBSD-gnats-submit@freebsd.org
Subject: usr.bin/more/Makefile is broken
X-Send-Pr-Version: 3.2

>Number:         13676
>Category:       bin
>Synopsis:       usr.bin/more/Makefile is broken
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep  9 21:00:00 PDT 1999
>Closed-Date:    Fri Sep 10 00:39:57 PDT 1999
>Last-Modified:  Fri Sep 10 01:10:00 PDT 1999
>Originator:     Garrett Wollman
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
MIT Lab for Computer Science
>Environment:

	-current sources as of 8 September 1999

>Description:

	more's Makefile erroneously uses ${ECHO}

>How-To-Repeat:

	cd /usr/src/usr.bin/more; make -s

>Fix:
	
	Index: Makefile
	===================================================================
	RCS file: /home/cvs/src/usr.bin/more/Makefile,v
	retrieving revision 1.8
	diff -u -r1.8 Makefile
	--- Makefile	1999/09/03 22:31:13	1.8
	+++ Makefile	1999/09/10 03:44:56
	@@ -16,12 +16,12 @@
	 EXAMPLES=	default.morerc less.morerc most.morerc
	 
	 defrc.h: default.morerc
	-	@${ECHO} '/* ${.TARGET:T} auto-generated from ${.ALLSRC:T} */' \
	+	echo '/* ${.TARGET:T} auto-generated from ${.ALLSRC:T} */' \
	 	    > ${.TARGET}
	-	@${ECHO} '#define DEFRC "\' >> ${.TARGET}
	+	echo '#define DEFRC "\' >> ${.TARGET}
	 	sed -e 's/\\/\\\\/g' -e 's/\"/\\\"/g' -e 's/$$/\\n\\/' \
	 	    < ${.ALLSRC} >> ${.TARGET}
	-	@${ECHO} \" >> ${.TARGET}
	+	echo \" >> ${.TARGET}
	 
	 beforeinstall:
	 	${INSTALL} ${COPY} -o ${SHAREOWN} -g ${SHAREGRP} -m ${SHAREMODE} \
	
	

>Release-Note:
>Audit-Trail:

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: wollman@khavrinen.lcs.mit.edu
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: bin/13676: usr.bin/more/Makefile is broken 
Date: Fri, 10 Sep 1999 09:26:14 +0200

 On Thu, 09 Sep 1999 23:50:40 -0400, Garrett Wollman wrote:
 
 > 	more's Makefile erroneously uses ${ECHO}
 
 Why is it erroneous?
 
 > 	-	@${ECHO} '#define DEFRC "\' >> ${.TARGET}
 > 	+	echo '#define DEFRC "\' >> ${.TARGET}
 
 Okay, so you want the echo commands to be displayed. What else is wrong
 with using just ${ECHO} ?
 
 Ciao,
 Sheldon.
 
State-Changed-From-To: open->closed 
State-Changed-By: ru 
State-Changed-When: Fri Sep 10 00:39:57 PDT 1999 
State-Changed-Why:  
Identical patch applied. 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: Ruslan Ermilov <ru@ucb.crimea.ua>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/13676: usr.bin/more/Makefile is broken 
Date: Fri, 10 Sep 1999 09:42:22 +0200

 On Fri, 10 Sep 1999 10:38:08 +0300, Ruslan Ermilov wrote:
 
 > Because ${ECHO} == "true" in `make -s' case, see /usr/share/mk/bsd.sys.mk.
 
 Knew there must be something. ;-)
 
 Thanks,
 Sheldon.
 

From: Ruslan Ermilov <ru@ucb.crimea.ua>
To: Sheldon Hearn <sheldonh@uunet.co.za>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/13676: usr.bin/more/Makefile is broken
Date: Fri, 10 Sep 1999 10:47:12 +0300

 On Fri, Sep 10, 1999 at 09:42:22AM +0200, Sheldon Hearn wrote:
 > 
 > 
 > On Fri, 10 Sep 1999 10:38:08 +0300, Ruslan Ermilov wrote:
 > 
 > > Because ${ECHO} == "true" in `make -s' case, see /usr/share/mk/bsd.sys.mk.
 > 
 > Knew there must be something. ;-)
 > 
 Except it is in /usr/share/mk/sys.mk :-!
 
 -- 
 Ruslan Ermilov		Sysadmin and DBA of the
 ru@ucb.crimea.ua	United Commercial Bank,
 ru@FreeBSD.org		FreeBSD committer,
 +380.652.247.647	Simferopol, Ukraine
 
 http://www.FreeBSD.org	The Power To Serve
 http://www.oracle.com	Enabling The Information Age
 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: Ruslan Ermilov <ru@ucb.crimea.ua>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: bin/13676: usr.bin/more/Makefile is broken 
Date: Fri, 10 Sep 1999 09:50:58 +0200

 On Fri, 10 Sep 1999 10:47:12 +0300, Ruslan Ermilov wrote:
 
 > Except it is in /usr/share/mk/sys.mk :-!
 
 Yah? So where does bsd.prog.mk get sucked in via bsd.prog.mk?
 
 Ciao,
 Sheldon.
 
>Unformatted:
