From nobody@FreeBSD.org  Sun Feb  1 10:59:22 2009
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 211BA106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  1 Feb 2009 10:59:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 0F0B88FC0C
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  1 Feb 2009 10:59:22 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n11AxLQi045950
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 1 Feb 2009 10:59:21 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id n11AxLdP045949;
	Sun, 1 Feb 2009 10:59:21 GMT
	(envelope-from nobody)
Message-Id: <200902011059.n11AxLdP045949@www.freebsd.org>
Date: Sun, 1 Feb 2009 10:59:21 GMT
From: Luiz Otavio O Souza <loos.br@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] ppp(8) proxyarp does not work
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         131250
>Category:       bin
>Synopsis:       [patch] ppp(8) proxyarp does not work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brian
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Feb 01 11:00:17 UTC 2009
>Closed-Date:    Tue Jan 29 14:52:27 UTC 2013
>Last-Modified:  Tue Jan 29 14:52:27 UTC 2013
>Originator:     Luiz Otavio O Souza
>Release:        7-STABLE
>Organization:
>Environment:
FreeBSD fw.ad.com.br 7.1-STABLE FreeBSD 7.1-STABLE #7: Wed Jan 14 16:33:00 BRST 2009     root@fw.ad.com.br:/usr/obj/usr/src/sys/FW  i386

>Description:
If you are running the ppp as server (pppoe, pptp and others) the enable proxy option simply doesnt work.

There is a case in the code where ncp_IfaceAddrAdded is not called and the proxyarp set routine never run.

This patch fix this.
>How-To-Repeat:
Setup any ppp server with enable proxy on ppp.conf and try it.
>Fix:
Apply the patch.



Patch attached with submission follows:

--- iface.c.orig	2009-01-31 18:29:21.000000000 -0200
+++ iface.c	2009-01-31 18:28:17.000000000 -0200
@@ -456,6 +456,7 @@
       if (ncprange_equal(&iface->addr[n].ifa, ifa) &&
           ncpaddr_equal(&iface->addr[n].peer, peer)) {
         close(s);
+        ncp_IfaceAddrAdded(ncp, iface->addr + n);
         return 1;	/* Already there */
       }
 


>Release-Note:
>Audit-Trail:

From: Brett Glass <brett@lariat.net>
To: bug-followup@FreeBSD.org, loos.br@gmail.com
Cc:  
Subject: Re: bin/131250: [patch] ppp(8) proxyarp does not work
Date: Mon, 23 Mar 2009 11:49:50 -0600

 Bug verified and patch appears to fix it. Please commit.
 
Responsible-Changed-From-To: freebsd-bugs->bz 
Responsible-Changed-By: bz 
Responsible-Changed-When: Mon Apr 13 16:20:02 UTC 2009 
Responsible-Changed-Why:  
Take and handle ... talked into by re@;) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131250 
State-Changed-From-To: open->patched 
State-Changed-By: bz 
State-Changed-When: Mon Apr 13 17:59:11 UTC 2009 
State-Changed-Why:  
Comitted to HEAD, MFC in a few days. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131250 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/131250: commit references a PR
Date: Mon, 13 Apr 2009 18:18:33 +0000 (UTC)

 Author: bz
 Date: Mon Apr 13 17:57:12 2009
 New Revision: 191006
 URL: http://svn.freebsd.org/changeset/base/191006
 
 Log:
   In case the peer address was already configured on the interface
   we were not properly handling proxy arp. Make sure we (try to) add
   the proxy arp entry/entries in this case as well.
   
   PR:		bin/131250
   Submitted by:	loos.br gmail.com (Luiz Otavio O Souza)
   MFC after:	3 days
 
 Modified:
   head/usr.sbin/ppp/iface.c
 
 Modified: head/usr.sbin/ppp/iface.c
 ==============================================================================
 --- head/usr.sbin/ppp/iface.c	Mon Apr 13 16:23:32 2009	(r191005)
 +++ head/usr.sbin/ppp/iface.c	Mon Apr 13 17:57:12 2009	(r191006)
 @@ -456,6 +456,7 @@ iface_Add(struct iface *iface, struct nc
        if (ncprange_equal(&iface->addr[n].ifa, ifa) &&
            ncpaddr_equal(&iface->addr[n].peer, peer)) {
          close(s);
 +        ncp_IfaceAddrAdded(ncp, iface->addr + n);
          return 1;	/* Already there */
        }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: "Bjoern A. Zeeb" <bz@FreeBSD.org>
To: bug-followup@FreeBSD.org, loos.br@gmail.com
Cc:  
Subject: Re: bin/131250: [patch] ppp(8) proxyarp does not work
Date: Thu, 7 May 2009 03:15:20 +0000 (UTC)

 Hi,
 
 can you try this patch on stable/7 or 7.2-R and report back?
 
 http://people.freebsd.org/~bz/20090506-01-ppp-mfc.diff
 
 -- 
 Bjoern A. Zeeb                      The greatest risk is not taking one.
Responsible-Changed-From-To: bz->brian 
Responsible-Changed-By: bz 
Responsible-Changed-When: Tue Jan 5 14:09:46 UTC 2010 
Responsible-Changed-Why:  
Re-assign to brian; 
he was last looking into these but I do not know of the results. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131250 
State-Changed-From-To: patched->closed 
State-Changed-By: glebius 
State-Changed-When: Tue Jan 29 14:51:39 UTC 2013 
State-Changed-Why:  
Not sure whether merged to stable/8, but fix definitely got into stable/9, 
thus included in 9.0-RELEASE and 9.1-RELEASE. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=131250 
>Unformatted:
