From mvoorhis@eressea.wpi.edu  Mon Nov 24 01:19:47 2008
Return-Path: <mvoorhis@eressea.wpi.edu>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BB221106564A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Nov 2008 01:19:47 +0000 (UTC)
	(envelope-from mvoorhis@eressea.wpi.edu)
Received: from que31.charter.net (que31.charter.net [209.225.8.23])
	by mx1.freebsd.org (Postfix) with ESMTP id 60AEA8FC12
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Nov 2008 01:19:47 +0000 (UTC)
	(envelope-from mvoorhis@eressea.wpi.edu)
Received: from aarprv06.charter.net ([10.20.200.76]) by mta31.charter.net
          (InterMail vM.7.08.03.00 201-2186-126-20070710) with ESMTP
          id <20081124005222.ORPS4798.mta31.charter.net@aarprv06.charter.net>
          for <FreeBSD-gnats-submit@freebsd.org>;
          Sun, 23 Nov 2008 19:52:22 -0500
Received: from eressea.wpi.edu ([97.95.179.37]) by aarprv06.charter.net
          with ESMTP
          id <20081124005221.JOL128.aarprv06.charter.net@eressea.wpi.edu>
          for <FreeBSD-gnats-submit@freebsd.org>;
          Sun, 23 Nov 2008 19:52:21 -0500
Received: from eressea.wpi.edu (localhost [127.0.0.1])
	by eressea.wpi.edu (8.14.3/8.14.3) with ESMTP id mAO0qI9a031976
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 23 Nov 2008 19:52:18 -0500 (EST)
	(envelope-from mvoorhis@eressea.wpi.edu)
Received: (from mvoorhis@localhost)
	by eressea.wpi.edu (8.14.3/8.14.3/Submit) id mAO0qI9V031970;
	Sun, 23 Nov 2008 19:52:18 -0500 (EST)
	(envelope-from mvoorhis)
Message-Id: <200811240052.mAO0qI9V031970@eressea.wpi.edu>
Date: Sun, 23 Nov 2008 19:52:18 -0500 (EST)
From: Mike Voorhis <mvoorhis@cs.wpi.edu>
Reply-To: Mike Voorhis <mvoorhis@cs.wpi.edu>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: dump -W in 8-CURRENT fails to report past dump levels
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         129110
>Category:       bin
>Synopsis:       [patch] dump(1): dump -W in 8-CURRENT fails to report past dump levels
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 24 01:20:00 UTC 2008
>Closed-Date:    Fri May 29 07:30:34 UTC 2009
>Last-Modified:  Fri May 29 07:30:34 UTC 2009
>Originator:     Mike Voorhis
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
>Environment:
 FreeBSD eressea.wpi.edu 8.0-CURRENT FreeBSD 8.0-CURRENT #0: Sat Nov 22 10:01:40 EST 2008 root@eressea.wpi.edu:/large/obj/data/mvoorhis/FreeBSD/src-releng_8/src/sys/ERESSEA8 i386
>Description:
	On a new 8-Current (mine is from 21 November 2008, 16:54),
	dump a filesystem to someplace:

		dump -0Lauf /dev/null /

	Observe that /etc/dumpdates is updated correctly with the
	dumplevel you chose, and the correct date.

	Now run "dump -W" and observe that the dumpdate is there,
	but the dump LEVEL is not reported where it should be.

>How-To-Repeat:
	(see "description")

>Fix:
	In /usr/src/sbin/dump/optr.c (v 1.35) change line 408:

	old:
		"%c %8s\t(%6s) Last dump: Level %c, Date %s\n",

	new:
		"%c %8s\t(%6s) Last dump: Level %d, Date %s\n",

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: brian 
State-Changed-When: Fri May 29 07:23:38 UTC 2009 
State-Changed-Why:  
Fixed in r193022, I'll MFC in 3 weeks. 

Thanks for the patch! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129110 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/129110: commit references a PR
Date: Fri, 29 May 2009 07:26:55 +0000 (UTC)

 Author: brian
 Date: Fri May 29 07:26:44 2009
 New Revision: 193022
 URL: http://svn.freebsd.org/changeset/base/193022
 
 Log:
   Make dump -W show the level correctly.
   
   PR:		129110
   Submitted by:	Mike Voorhis <mvoorhis@cs.wpi.edu>
   MFC after:	3 weeks
 
 Modified:
   head/sbin/dump/optr.c
 
 Modified: head/sbin/dump/optr.c
 ==============================================================================
 --- head/sbin/dump/optr.c	Fri May 29 07:18:31 2009	(r193021)
 +++ head/sbin/dump/optr.c	Fri May 29 07:26:44 2009	(r193022)
 @@ -406,7 +406,7 @@ lastdump(int arg)	/* w ==> just what to 
  		};
  		if (arg != 'w' || dumpme)
  			(void) printf(
 -			    "%c %8s\t(%6s) Last dump: Level %c, Date %s\n",
 +			    "%c %8s\t(%6s) Last dump: Level %d, Date %s\n",
  			    dumpme && (arg != 'w') ? '>' : ' ',
  			    dtwalk->dd_name,
  			    dt ? dt->fs_file : "",
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brian 
State-Changed-When: Fri May 29 07:30:07 UTC 2009 
State-Changed-Why:  
An MFC isn't necessary here after all. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129110 
>Unformatted:
