From nobody@FreeBSD.org  Sun Nov 23 04:16:16 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3D9681065672
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Nov 2008 04:16:16 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 33E708FC08
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Nov 2008 04:16:16 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id mAN4GGWo065665
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 23 Nov 2008 04:16:16 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id mAN4GFdu065664;
	Sun, 23 Nov 2008 04:16:15 GMT
	(envelope-from nobody)
Message-Id: <200811230416.mAN4GFdu065664@www.freebsd.org>
Date: Sun, 23 Nov 2008 04:16:15 GMT
From: Garrett Cooper <yaneurabeya@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Bug in hexsyntax.c:new_syntax -- literal instead of escaped newline used
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         129078
>Category:       bin
>Synopsis:       [patch] hexsyntax(1): Bug in hexsyntax.c:new_syntax -- literal instead of escaped newline used
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Nov 23 04:20:01 UTC 2008
>Closed-Date:    Tue Dec 23 11:00:38 UTC 2008
>Last-Modified:  Sun Feb 03 22:27:49 UTC 2013
>Originator:     Garrett Cooper
>Release:        8-CURRENT
>Organization:
n/a
>Environment:
FreeBSD optimus.gateway.2wire.net 8.0-CURRENT FreeBSD 8.0-CURRENT #5: Thu Nov 20 23:31:07 PST 2008     gcooper@optimus.gateway.2wire.net:/usr/obj/usr/src/sys/OPTIMUS  amd64
>Description:
Found this minor typo bug while trying to correct the other PR's assigned to me related to hexdump.

At first glance it doesn't appear to fix anything, but I could be wrong.
>How-To-Repeat:
Unsure.
>Fix:


Patch attached with submission follows:

Index: hexsyntax.c
===================================================================
--- hexsyntax.c	(revision 185157)
+++ hexsyntax.c	(working copy)
@@ -65,7 +65,8 @@
 		add("\"%08.8_ax  \" 8/1 \"%02x \" \"  \" 8/1 \"%02x \" ");
 		add("\"  |\" 16/1 \"%_p\" \"|\\n\"");
 	}
-	while ((ch = getopt(argc, argv, "bcCde:f:n:os:vx")) != -1)
+	while ((ch = getopt(argc, argv, "bcCde:f:n:os:vx")) != -1) {
+
 		switch (ch) {
 		case 'b':
 			add("\"%07.7_Ax\n\"");
@@ -124,8 +125,10 @@
 			usage();
 		}
 
+	}
+
 	if (!fshead) {
-		add("\"%07.7_Ax\n\"");
+		add("\"%07.7_Ax\\n\"");
 		add("\"%07.7_ax \" 8/2 \"%04x \" \"\\n\"");
 	}
 


>Release-Note:
>Audit-Trail:

From: "Garrett Cooper" <yanegomi@gmail.com>
To: bug-followup@freebsd.org, gcooper@freebsd.org
Cc:  
Subject: Re: misc/129078: Bug in hexsyntax.c:new_syntax -- literal instead of escaped newline used
Date: Sat, 22 Nov 2008 20:43:05 -0800

 ------=_Part_75248_7591384.1227415385345
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Found a few more unescaped tokens.
 -Garrett
 
 ------=_Part_75248_7591384.1227415385345
 Content-Type: text/plain; name=new_syntax_bug.diff.txt
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_fnv7edu41
 Content-Disposition: attachment; filename=new_syntax_bug.diff.txt
 
 SW5kZXg6IGhleHN5bnRheC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGhleHN5bnRheC5jCShyZXZpc2lvbiAx
 ODUxNTcpCisrKyBoZXhzeW50YXguYwkod29ya2luZyBjb3B5KQpAQCAtNjEsMjcgKzYxLDI4IEBA
 CiAJaWYgKChwID0gcmluZGV4KGFyZ3ZbMF0sICdoJykpICE9IE5VTEwgJiYKIAkgICAgc3RyY21w
 KHAsICJoZCIpID09IDApIHsKIAkJLyogIkNhbm9uaWNhbCIgZm9ybWF0LCBpbXBsaWVzIC1DLiAq
 LwotCQlhZGQoIlwiJTA4LjhfQXhcblwiIik7CisJCWFkZCgiXCIlMDguOF9BeFxcblwiIik7CiAJ
 CWFkZCgiXCIlMDguOF9heCAgXCIgOC8xIFwiJTAyeCBcIiBcIiAgXCIgOC8xIFwiJTAyeCBcIiAi
 KTsKIAkJYWRkKCJcIiAgfFwiIDE2LzEgXCIlX3BcIiBcInxcXG5cIiIpOwogCX0KLQl3aGlsZSAo
 KGNoID0gZ2V0b3B0KGFyZ2MsIGFyZ3YsICJiY0NkZTpmOm46b3M6dngiKSkgIT0gLTEpCisJd2hp
 bGUgKChjaCA9IGdldG9wdChhcmdjLCBhcmd2LCAiYmNDZGU6ZjpuOm9zOnZ4IikpICE9IC0xKSB7
 CisKIAkJc3dpdGNoIChjaCkgewogCQljYXNlICdiJzoKLQkJCWFkZCgiXCIlMDcuN19BeFxuXCIi
 KTsKKwkJCWFkZCgiXCIlMDcuN19BeFxcblwiIik7CiAJCQlhZGQoIlwiJTA3LjdfYXggXCIgMTYv
 MSBcIiUwM28gXCIgXCJcXG5cIiIpOwogCQkJYnJlYWs7CiAJCWNhc2UgJ2MnOgotCQkJYWRkKCJc
 IiUwNy43X0F4XG5cIiIpOworCQkJYWRkKCJcIiUwNy43X0F4XFxuXCIiKTsKIAkJCWFkZCgiXCIl
 MDcuN19heCBcIiAxNi8xIFwiJTNfYyBcIiBcIlxcblwiIik7CiAJCQlicmVhazsKIAkJY2FzZSAn
 Qyc6Ci0JCQlhZGQoIlwiJTA4LjhfQXhcblwiIik7CisJCQlhZGQoIlwiJTA4LjhfQXhcXG5cIiIp
 OwogCQkJYWRkKCJcIiUwOC44X2F4ICBcIiA4LzEgXCIlMDJ4IFwiIFwiICBcIiA4LzEgXCIlMDJ4
 IFwiICIpOwogCQkJYWRkKCJcIiAgfFwiIDE2LzEgXCIlX3BcIiBcInxcXG5cIiIpOwogCQkJYnJl
 YWs7CiAJCWNhc2UgJ2QnOgotCQkJYWRkKCJcIiUwNy43X0F4XG5cIiIpOworCQkJYWRkKCJcIiUw
 Ny43X0F4XFxuXCIiKTsKIAkJCWFkZCgiXCIlMDcuN19heCBcIiA4LzIgXCIgICUwNXUgXCIgXCJc
 XG5cIiIpOwogCQkJYnJlYWs7CiAJCWNhc2UgJ2UnOgpAQCAtOTUsNyArOTYsNyBAQAogCQkJCWVy
 cngoMSwgIiVzOiBiYWQgbGVuZ3RoIHZhbHVlIiwgb3B0YXJnKTsKIAkJCWJyZWFrOwogCQljYXNl
 ICdvJzoKLQkJCWFkZCgiXCIlMDcuN19BeFxuXCIiKTsKKwkJCWFkZCgiXCIlMDcuN19BeFxcblwi
 Iik7CiAJCQlhZGQoIlwiJTA3LjdfYXggXCIgOC8yIFwiICUwNm8gXCIgXCJcXG5cIiIpOwogCQkJ
 YnJlYWs7CiAJCWNhc2UgJ3MnOgpAQCAtMTE3LDE1ICsxMTgsMTcgQEAKIAkJCXZmbGFnID0gQUxM
 OwogCQkJYnJlYWs7CiAJCWNhc2UgJ3gnOgotCQkJYWRkKCJcIiUwNy43X0F4XG5cIiIpOworCQkJ
 YWRkKCJcIiUwNy43X0F4XFxuXCIiKTsKIAkJCWFkZCgiXCIlMDcuN19heCBcIiA4LzIgXCIgICAl
 MDR4IFwiIFwiXFxuXCIiKTsKIAkJCWJyZWFrOwogCQljYXNlICc/JzoKIAkJCXVzYWdlKCk7CiAJ
 CX0KIAorCX0KKwogCWlmICghZnNoZWFkKSB7Ci0JCWFkZCgiXCIlMDcuN19BeFxuXCIiKTsKKwkJ
 YWRkKCJcIiUwNy43X0F4XFxuXCIiKTsKIAkJYWRkKCJcIiUwNy43X2F4IFwiIDgvMiBcIiUwNHgg
 XCIgXCJcXG5cIiIpOwogCX0KIAo=
 ------=_Part_75248_7591384.1227415385345--

From: "Garrett Cooper" <yanegomi@gmail.com>
To: bug-followup <bug-followup@freebsd.org>
Cc:  
Subject: Re: bin/129078: [patch] hexsyntax(1): Bug in hexsyntax.c:new_syntax -- literal instead of escaped newline used
Date: Tue, 23 Dec 2008 02:03:00 -0800

 Nuke this PR please. Pilot error on my part.
 Thanks,
 -Garrett
State-Changed-From-To: open->closed 
State-Changed-By: linimon 
State-Changed-When: Tue Dec 23 11:00:28 UTC 2008 
State-Changed-Why:  
Closed at submitter's request. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=129078 
>Unformatted:
