From nobody@FreeBSD.org  Tue Oct 14 15:59:42 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 227D6106569A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Oct 2008 15:59:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 10D348FC1C
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Oct 2008 15:59:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id m9EFxfvr016905
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Oct 2008 15:59:41 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id m9EFxfjk016904;
	Tue, 14 Oct 2008 15:59:41 GMT
	(envelope-from nobody)
Message-Id: <200810141559.m9EFxfjk016904@www.freebsd.org>
Date: Tue, 14 Oct 2008 15:59:41 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Failure in memset .
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         128096
>Category:       bin
>Synopsis:       [patch] nscd(1): Failure in memset .
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bushman
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 14 16:00:08 UTC 2008
>Closed-Date:    Mon Dec 14 15:22:46 UTC 2009
>Last-Modified:  Mon Dec 14 15:22:46 UTC 2009
>Originator:     Henning Petersen
>Release:        current-Freebsd
>Organization:
>Environment:
>Description:

>How-To-Repeat:

>Fix:
--- src/usr.sbin/nscd/agents/services.c	27 Sep 2007 12:30:10 -0000	1.3
+++ src/usr.sbin/nscd/agents/services.c	14 Oct 2008 07:31:06 -0000
@@ -171,7 +171,7 @@
 		if (size > 0) {
 			proto = (char *)malloc(size + 1);
 			assert(proto != NULL);
-			memset(proto, size + 1, 0);
+			memset(proto, 0, size + 1);
 			memcpy(proto, key + sizeof(enum nss_lookup_type) +
 				sizeof(int), size);
 		}


Patch attached with submission follows:

Index: src/usr.sbin/nscd/agents/services.c
===================================================================
RCS file: /usr/ncvs/src/usr.sbin/nscd/agents/services.c,v
retrieving revision 1.3
diff -u -r1.3 services.c
--- src/usr.sbin/nscd/agents/services.c	27 Sep 2007 12:30:10 -0000	1.3
+++ src/usr.sbin/nscd/agents/services.c	14 Oct 2008 07:31:06 -0000
@@ -171,7 +171,7 @@
 		if (size > 0) {
 			proto = (char *)malloc(size + 1);
 			assert(proto != NULL);
-			memset(proto, size + 1, 0);
+			memset(proto, 0, size + 1);
 			memcpy(proto, key + sizeof(enum nss_lookup_type) +
 				sizeof(int), size);
 		}


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->bushman 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Tue Oct 14 17:43:51 UTC 2008 
Responsible-Changed-Why:  
Over to the author of the code. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128096 
State-Changed-From-To: open->closed 
State-Changed-By: sat 
State-Changed-When: Mon Dec 14 15:21:39 UTC 2009 
State-Changed-Why:  
Fixed by delphij in r184186 on 2008-10-23, merged to 7 around then. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128096 
>Unformatted:
