From nobody@FreeBSD.org  Tue Oct 14 15:54:13 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D4374106569E
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Oct 2008 15:54:13 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id C20C78FC33
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Oct 2008 15:54:13 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.3/8.14.3) with ESMTP id m9EFsDCe005524
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 14 Oct 2008 15:54:13 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.3/8.14.3/Submit) id m9EFsD8d005511;
	Tue, 14 Oct 2008 15:54:13 GMT
	(envelope-from nobody)
Message-Id: <200810141554.m9EFsD8d005511@www.freebsd.org>
Date: Tue, 14 Oct 2008 15:54:13 GMT
From: Henning Petersen <henning.petersen@t-online.de>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Sizeof(pointer) bug in usr.bin/xlint/lint1/scan.l .
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         128094
>Category:       bin
>Synopsis:       [patch] lint(1): Sizeof(pointer) bug in usr.bin/xlint/lint1/scan.l .
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    jh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 14 16:00:05 UTC 2008
>Closed-Date:    Mon Mar 15 16:51:01 UTC 2010
>Last-Modified:  Mon Mar 15 16:51:01 UTC 2010
>Originator:     Henning Petersen
>Release:        current-Freebsd
>Organization:
>Environment:
>Description:

>How-To-Repeat:

>Fix:
--- src/usr.bin/xlint/lint1/scan.l	1 Jan 2003 18:13:44 -0000	1.12
+++ src/usr.bin/xlint/lint1/scan.l	14 Oct 2008 06:13:09 -0000
@@ -319,7 +319,7 @@
 		if ((sb = malloc(sizeof (sbuf_t))) == NULL)
 			nomem();
 	}
-	(void)memset(sb, 0, sizeof (sb));
+	(void)memset(sb, 0, sizeof (*sb));
 	return (sb);
 }


Patch attached with submission follows:

Index: src/usr.bin/xlint/lint1/scan.l
===================================================================
RCS file: /usr/ncvs/src/usr.bin/xlint/lint1/scan.l,v
retrieving revision 1.12
diff -u -r1.12 scan.l
--- src/usr.bin/xlint/lint1/scan.l	1 Jan 2003 18:13:44 -0000	1.12
+++ src/usr.bin/xlint/lint1/scan.l	14 Oct 2008 06:13:09 -0000
@@ -319,7 +319,7 @@
 		if ((sb = malloc(sizeof (sbuf_t))) == NULL)
 			nomem();
 	}
-	(void)memset(sb, 0, sizeof (sb));
+	(void)memset(sb, 0, sizeof (*sb));
 	return (sb);
 }
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->jh 
Responsible-Changed-By: jh 
Responsible-Changed-When: Mon Mar 8 16:09:50 UTC 2010 
Responsible-Changed-Why:  
Take. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128094 
State-Changed-From-To: open->patched 
State-Changed-By: jh 
State-Changed-When: Mon Mar 8 16:29:51 UTC 2010 
State-Changed-Why:  
Patched in head (r204872). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128094 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/128094: commit references a PR
Date: Mon,  8 Mar 2010 16:23:46 +0000 (UTC)

 Author: jh
 Date: Mon Mar  8 16:23:32 2010
 New Revision: 204872
 URL: http://svn.freebsd.org/changeset/base/204872
 
 Log:
   Pass the correct size to memset().
   
   PR:		bin/128094
   Submitted by:	Henning Petersen
   MFC after:	1 week
 
 Modified:
   head/usr.bin/xlint/lint1/scan.l
 
 Modified: head/usr.bin/xlint/lint1/scan.l
 ==============================================================================
 --- head/usr.bin/xlint/lint1/scan.l	Mon Mar  8 15:56:18 2010	(r204871)
 +++ head/usr.bin/xlint/lint1/scan.l	Mon Mar  8 16:23:32 2010	(r204872)
 @@ -319,7 +319,7 @@ allocsb(void)
  		if ((sb = malloc(sizeof (sbuf_t))) == NULL)
  			nomem();
  	}
 -	(void)memset(sb, 0, sizeof (sb));
 +	(void)memset(sb, 0, sizeof (*sb));
  	return (sb);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/128094: commit references a PR
Date: Mon, 15 Mar 2010 16:40:01 +0000 (UTC)

 Author: jh
 Date: Mon Mar 15 16:39:52 2010
 New Revision: 205171
 URL: http://svn.freebsd.org/changeset/base/205171
 
 Log:
   MFC r204872: Pass the correct size to memset().
   
   PR:		bin/128094
 
 Modified:
   stable/8/usr.bin/xlint/lint1/scan.l
 Directory Properties:
   stable/8/usr.bin/xlint/   (props changed)
 
 Modified: stable/8/usr.bin/xlint/lint1/scan.l
 ==============================================================================
 --- stable/8/usr.bin/xlint/lint1/scan.l	Mon Mar 15 16:06:52 2010	(r205170)
 +++ stable/8/usr.bin/xlint/lint1/scan.l	Mon Mar 15 16:39:52 2010	(r205171)
 @@ -319,7 +319,7 @@ allocsb(void)
  		if ((sb = malloc(sizeof (sbuf_t))) == NULL)
  			nomem();
  	}
 -	(void)memset(sb, 0, sizeof (sb));
 +	(void)memset(sb, 0, sizeof (*sb));
  	return (sb);
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: jh 
State-Changed-When: Mon Mar 15 16:51:00 UTC 2010 
State-Changed-Why:  
Fixed in head and stable/8. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=128094 
>Unformatted:
