From phk@critter.freebsd.dk  Tue Jun 24 09:47:53 2008
Return-Path: <phk@critter.freebsd.dk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BC30B1065670
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 24 Jun 2008 09:47:53 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D9368FC18
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 24 Jun 2008 09:47:53 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 94FD6170E5
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 24 Jun 2008 09:16:53 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.2/8.14.2) with ESMTP id m5O9Grj9002519
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 24 Jun 2008 09:16:53 GMT
	(envelope-from phk@critter.freebsd.dk)
Received: (from phk@localhost)
	by critter.freebsd.dk (8.14.2/8.14.2/Submit) id m5O9GrX4002518;
	Tue, 24 Jun 2008 09:16:53 GMT
	(envelope-from phk)
Message-Id: <200806240916.m5O9GrX4002518@critter.freebsd.dk>
Date: Tue, 24 Jun 2008 09:16:53 GMT
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Reply-To: Poul-Henning Kamp <phk@critter.freebsd.dk>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: cpio chokes on ".." in path
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         124924
>Category:       bin
>Synopsis:       cpio(1): cpio chokes on ".." in path
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    kientzle
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 24 09:50:04 UTC 2008
>Closed-Date:    Tue Sep 02 06:53:38 UTC 2008
>Last-Modified:  Tue Sep 02 06:53:38 UTC 2008
>Originator:     Poul-Henning Kamp
>Release:        FreeBSD 8.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD critter.freebsd.dk 8.0-CURRENT FreeBSD 8.0-CURRENT #0 @179963M: Mon Jun 23 23:01:36 UTC 2008 root@critter.freebsd.dk:/usr/obj/freebsd/head/sys/C5 i386


	
>Description:

	cpio is broken in -current:

	critter phk> cd /tmp
	critter phk> mkdir A
	critter phk> mkdir B
	critter phk> cd A
	critter phk> touch oo
	critter phk> find . -print | cpio -dump ../B
	cpio: ../B/.: Path contains '..': Unknown error: -1
	cpio: ../B/./oo: Path contains '..': Unknown error: -1


>How-To-Repeat:
	see above
>Fix:

	


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->kientzle 
Responsible-Changed-By: kris 
Responsible-Changed-When: Tue Jun 24 14:43:16 UTC 2008 
Responsible-Changed-Why:  
Assign to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124924 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/124924: commit references a PR
Date: Tue, 24 Jun 2008 15:18:59 +0000 (UTC)

 kientzle    2008-06-24 15:18:40 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.bin/cpio         cpio.c 
   Log:
   SVN rev 179972 on 2008-06-24 15:18:40Z by kientzle
   
   In -p mode, don't gaurd against '..' in paths.  We continue to
   check in -i mode unless --insecure is specified.
   
   PR: bin/124924
   
   Revision  Changes    Path
   1.4       +1 -0      src/usr.bin/cpio/cpio.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/124924: commit references a PR
Date: Sun, 24 Aug 2008 05:14:25 +0000 (UTC)

 kientzle    2008-08-24 05:14:03 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.bin/cpio/test    Makefile 
   Added files:
     usr.bin/cpio/test    test_passthrough_dotdot.c 
   Log:
   SVN rev 182094 on 2008-08-24 05:14:03Z by kientzle
   
   Test for proper handling of "cpio -p .."
   
   PR:             bin/124924
   
   Revision  Changes    Path
   1.3       +1 -0      src/usr.bin/cpio/test/Makefile
   1.1       +87 -0     src/usr.bin/cpio/test/test_passthrough_dotdot.c (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/124924: commit references a PR
Date: Sun, 24 Aug 2008 05:25:20 +0000 (UTC)

 kientzle    2008-08-24 05:24:52 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.bin/cpio/test    test_passthrough_dotdot.c 
   Log:
   SVN rev 182095 on 2008-08-24 05:24:52Z by kientzle
   
   Update the passthrough_dotdot test to reproduce a
   problem reported by Kris Kennaway.
   
   PR:             bin/124924
   
   Revision  Changes    Path
   1.2       +2 -0      src/usr.bin/cpio/test/test_passthrough_dotdot.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/124924: commit references a PR
Date: Sun, 24 Aug 2008 05:42:48 +0000 (UTC)

 kientzle    2008-08-24 05:42:22 UTC
 
   FreeBSD src repository
 
   Modified files:
     lib/libarchive       Makefile archive_write_disk.c 
   Log:
   SVN rev 182097 on 2008-08-24 05:42:22Z by kientzle
   
   Fail copying path/.. only if SECURE_NODOTDOT was specified.
   Since we already warn for any '..' elements in that case,
   the extra "lastdotdot" tracking turns out to be unnecessary.
   
   PR:             bin/124924
   
   Revision  Changes    Path
   1.86      +4 -0      src/lib/libarchive/Makefile
   1.30      +3 -15     src/lib/libarchive/archive_write_disk.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: Tim Kientzle <kientzle@freebsd.org>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: bin/124924: cpio(1): cpio chokes on ".." in path
Date: Sat, 23 Aug 2008 22:25:09 -0700

 Kris Kennaway pointed out another closely-related problem:
 
 pointyhat# find . | cpio -dumpl ../../
 cpio: ../../.: Path contains trailing '..': Unknown error: -1
State-Changed-From-To: open->closed 
State-Changed-By: kientzle 
State-Changed-When: Tue Sep 2 06:51:46 UTC 2008 
State-Changed-Why:  
I believe this is fully resolved as of r182097 of lib/libarchive. 
The libarchive fixes have also been MFCed to 7-STABLE and 6-STABLE. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=124924 
>Unformatted:
