From edwin@mavetju.org  Tue Jun  3 22:38:52 2008
Return-Path: <edwin@mavetju.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 796581065675
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  3 Jun 2008 22:38:52 +0000 (UTC)
	(envelope-from edwin@mavetju.org)
Received: from mail5out.barnet.com.au (mail5.barnet.com.au [202.83.178.78])
	by mx1.freebsd.org (Postfix) with ESMTP id 369008FC15
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  3 Jun 2008 22:38:52 +0000 (UTC)
	(envelope-from edwin@mavetju.org)
Received: by mail5out.barnet.com.au (Postfix, from userid 1001)
	id 68BF82218ADB; Wed,  4 Jun 2008 08:38:51 +1000 (EST)
Received: from mail5auth.barnet.com.au (mail5.barnet.com.au [202.83.178.78])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "mail5auth.barnet.com.au", Issuer "*.barnet.com.au" (verified OK))
	by mail5.barnet.com.au (Postfix) with ESMTP id 2862721B3494
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 Jun 2008 08:38:51 +1000 (EST)
Received: from k7.mavetju (k7.mavetju.org [10.251.1.18])
	by mail5auth.barnet.com.au (Postfix) with ESMTP id C76ED2218ACC
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  4 Jun 2008 08:38:50 +1000 (EST)
Received: by k7.mavetju (Postfix, from userid 1001)
	id 7DA2015C; Wed,  4 Jun 2008 08:38:50 +1000 (EST)
Message-Id: <20080603223850.7DA2015C@k7.mavetju>
Date: Wed,  4 Jun 2008 08:38:50 +1000 (EST)
From: Edwin Groothuis <edwin@mavetju.org>
Reply-To: Edwin Groothuis <edwin@mavetju.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] add BUGS section to rcorder.8 with REQUIRE explanation
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         124251
>Category:       bin
>Synopsis:       [patch] add BUGS section to rcorder.8 with REQUIRE explanation
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mtm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 03 22:40:01 UTC 2008
>Closed-Date:    Tue Mar 09 18:04:34 UTC 2010
>Last-Modified:  Tue Mar 09 18:04:34 UTC 2010
>Originator:     Edwin Groothuis
>Release:        FreeBSD 7.0-RELEASE-p1 i386
>Organization:
-
>Environment:
System: FreeBSD k7.mavetju 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #2: Wed May 28 08:12:56 EST 2008 edwin@k7.mavetju:/usr/src/sys/i386/compile/k7 i386


>Description:
Add the following text to the bugs section:

BUGS
     The ``REQUIRE'' keyword is misleading: It doesn't describe which daemons
     have to be running before a script will be started, it describes after
     which scripts a script has to be started.  For example, if your script
     has a ``REQUIRE'' on ``named'', it will start after the ``named'' script
     has been started, even if the named-daemon itself hasn't been started.

>How-To-Repeat:
>Fix:

Index: rcorder.8
===================================================================
RCS file: /home/ncvs/src/sbin/rcorder/rcorder.8,v
retrieving revision 1.4
diff -u -r1.4 rcorder.8
--- rcorder.8	2 Jul 2004 18:37:52 -0000	1.4
+++ rcorder.8	3 Jun 2008 22:37:27 -0000
@@ -152,6 +152,20 @@
 A set of files has a circular dependency which was detected while
 processing the stated file.
 .El
+.Sh BUGS
+The
+.Dq Li REQUIRE
+keyword is misleading:
+It doesn't describe which daemons have to be running before a script
+will be started, it describes after which scripts a script has to
+be started.  For example, if your script has a
+.Dq Li REQUIRE
+on
+.Dq Li named ,
+it will start after the 
+.Dq Li named
+script has been started, even if the named-daemon itself hasn't
+been started.
 .Sh SEE ALSO
 .Xr rc 8
 .Sh HISTORY
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Jun 4 00:53:22 UTC 2008 
Responsible-Changed-Why:  
Over to maintainers (maybe) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124251 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/124251: commit references a PR
Date: Mon,  9 Jun 2008 09:08:19 +0000 (UTC)

 mtm         2008-06-09 09:07:58 UTC
 
   FreeBSD src repository
 
   Modified files:
     sbin/rcorder         rcorder.8 
   Log:
   SVN rev 179669 on 2008-06-09 09:07:58Z by mtm
   
   Document the misleading nature of the REQUIRE line. The patch in
   the PR has been heavily edited for style(9) and clarity. Mistakes are
   mine.
   
   PR: bin/124251
   
   Revision  Changes    Path
   1.5       +20 -1     src/sbin/rcorder/rcorder.8
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: mtm 
State-Changed-When: Mon Jun 9 09:15:09 UTC 2008 
State-Changed-Why:  
Patched in head 


Responsible-Changed-From-To: freebsd-rc->mtm 
Responsible-Changed-By: mtm 
Responsible-Changed-When: Mon Jun 9 09:15:09 UTC 2008 
Responsible-Changed-Why:  
Patched in head 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124251 
State-Changed-From-To: patched->closed 
State-Changed-By: mtm 
State-Changed-When: Tue Mar 9 18:03:56 UTC 2010 
State-Changed-Why:  
MFCing no longer an issue since we're in 9-CURRENT now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124251 
>Unformatted:
