From nobody@FreeBSD.org  Sun Jun  1 19:06:38 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 88BF3106564A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  1 Jun 2008 19:06:38 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6AF998FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Sun,  1 Jun 2008 19:06:38 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m51J4pDp070914
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 1 Jun 2008 19:04:51 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m51J4puj070913;
	Sun, 1 Jun 2008 19:04:51 GMT
	(envelope-from nobody)
Message-Id: <200806011904.m51J4puj070913@www.freebsd.org>
Date: Sun, 1 Jun 2008 19:04:51 GMT
From: Paul <onemda@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: tcsh coredumps
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         124191
>Category:       bin
>Synopsis:       [patch] tcsh(1): tcsh coredumps
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    keramida
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 01 19:10:01 UTC 2008
>Closed-Date:    Tue Jul 22 15:30:52 UTC 2008
>Last-Modified:  Tue Jul 22 15:30:52 UTC 2008
>Originator:     Paul
>Release:        FreeBSD 8.0 CURRENT
>Organization:
>Environment:
FreeBSD Voyager 8.0-CURRENT FreeBSD 8.0-CURRENT #4: Thu May 29 18:11:48 CEST 2008     root@Voyager:/usr/local/obj/usr/local/src/sys/KERNEL  i386
>Description:
http://lists.freebsd.org/pipermail/freebsd-current/2008-January/082638.html

I reporting this again because fix is still not comitted to HEAD.
>How-To-Repeat:

>Fix:
--- a/contrib/tcsh/tc.func.c    Wed Jan 23 11:47:09 2008 +0000                                                                                                                             
+++ b/contrib/tcsh/tc.func.c    Wed Jan 23 17:46:37 2008 +0200                                                                                                                             
@@ -632,7 +632,7 @@                                                                                                                                                                        
     }                                                                                                                                                                                     
     strbuf_terminate(&pass);                                                                                                                                                              
                                                                                                                                                                                           
-    cleanup_until(&sa);                                                                                                                                                                   
+    cleanup_until(&osa);                                                                                                                                                                  
                                                                                                                                                                                           
     return pass.s;                                                                                                                                                                        
 }                                                                                                                                                                                         


NOTE: Do not credit me for this patch, I am not author of it ...

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->keramida 
Responsible-Changed-By: keramida 
Responsible-Changed-When: Tue Jun 3 14:47:06 UTC 2008 
Responsible-Changed-Why:  
Grab this.  I've been running with the patch for a while, 
and it seems to work. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124191 
State-Changed-From-To: open->patched 
State-Changed-By: keramida 
State-Changed-When: Sun Jul 20 18:05:38 UTC 2008 
State-Changed-Why:  
The fix is now in HEAD.  In a couple of days or so, 
I'll try to commit it to stable/6 and stable/7 too. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124191 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/124191: commit references a PR
Date: Sun, 20 Jul 2008 18:05:44 +0000 (UTC)

 keramida    2008-07-20 18:05:18 UTC
 
   FreeBSD src repository
 
   Modified files:
     contrib/tcsh         tc.func.c 
   Log:
   SVN rev 180637 on 2008-07-20 18:05:18Z by keramida
   
   tcsh: fix abort in cleanup_until(), caused by internal xgetpass()
   
   The xgetpass() function pushes a cleanup entry for &osa, but then
   attempts to flush the stack until an entry matching &sa.  The two
   object pointers do not match, so the stack is popped too much,
   and then cleanup_until calls abort() when it unexpectedly hits
   the bottom of the cleanup stack.
   
   Reported by:    Paul B. Mahol, onemda at gmail.com,
                   Pietro Cerutti, gahr at gahr.ch
   PR:             bin/124191
   Reviewed by:    mp, kris
   MFC after:      2 days
   
   Revision  Changes    Path
   1.2       +640 -677  src/contrib/tcsh/tc.func.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/124191: commit references a PR
Date: Tue, 22 Jul 2008 15:15:02 +0000 (UTC)

 keramida    2008-07-22 15:14:33 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     contrib/tcsh         tc.func.c 
   Log:
   SVN rev 180697 on 2008-07-22 15:14:33Z by keramida
   
   MFC change 180637 - tcsh abort in xgetpass()
   
   PR:             bin/124191
   
   Revision     Changes    Path
   1.1.1.8.2.1  +1 -1      src/contrib/tcsh/tc.func.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/124191: commit references a PR
Date: Tue, 22 Jul 2008 15:15:24 +0000 (UTC)

 keramida    2008-07-22 15:14:59 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     contrib/tcsh         tc.func.c 
   Log:
   SVN rev 180698 on 2008-07-22 15:14:59Z by keramida
   
   MFC change 180637 - tcsh abort in xgetpass()
   
   PR:             bin/124191
   
   Revision     Changes    Path
   1.1.1.7.2.2  +1 -1      src/contrib/tcsh/tc.func.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: keramida 
State-Changed-When: Tue Jul 22 15:29:59 UTC 2008 
State-Changed-Why:  
Merged to RELENG_6 and RELENG_7 too now. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=124191 
>Unformatted:
