From nobody@FreeBSD.org  Tue Apr 29 20:50:44 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7BEFA1065678
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Apr 2008 20:50:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 6B02B8FC0A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Apr 2008 20:50:44 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m3TKo6xI009174
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 29 Apr 2008 20:50:06 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m3TKo68P009173;
	Tue, 29 Apr 2008 20:50:06 GMT
	(envelope-from nobody)
Message-Id: <200804292050.m3TKo68P009173@www.freebsd.org>
Date: Tue, 29 Apr 2008 20:50:06 GMT
From: Lawrence Mayer <lawmay3@i12.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch]: sysinstall -- remove dummy quotas option
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         123237
>Category:       bin
>Synopsis:       sysinstall(8): [patch]: sysinstall(8) -- remove dummy quotas option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brucec
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Tue Apr 29 21:00:02 UTC 2008
>Closed-Date:    Tue Feb 22 17:52:47 UTC 2011
>Last-Modified:  Tue Feb 22 18:00:26 UTC 2011
>Originator:     Lawrence Mayer
>Release:        n/a
>Organization:
>Environment:
>Description:
Attached patch updates sysinstall by removing quotas option from Startup Services Menu.

The quotas option sets the variable check_quotas. But changing check_quotas in sysinstall normally has no effect, since

1. enable_quotas=NO by default, which sysinstall can't change and

2. the GENERIC kernel has no support for quotas.

The only way check_quotas could ever have any effect would be by compiling a custom kernel with options QUOTA and then setting enable_quotas=YES in rc.conf (neither of which can be done via sysinstall). At that point, check_quotas can also be set in rc.conf.

The quotas option in sysinstall is thus a dummy option, which the attached patch removes.
>How-To-Repeat:

>Fix:
Apply attached patch to src/usr.sbin/sysinstall/menus.c Revision 1.431 <http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/src/usr.sbin/sysinstall/menus.c?rev=1.431;content-type=text%2Fplain>

Patch attached with submission follows:

--- menus_1.431.c	2008-04-29 12:49:15.338412800 -0700
+++ menus_1.432.c	2008-04-29 12:56:55.440006400 -0700
@@ -1263,8 +1263,6 @@
       { " OSF/1",	"This host wants to be able to run DEC OSF/1 binaries.",
 	dmenuVarCheck, configOSF1, NULL, VAR_OSF1_ENABLE "=YES" },
 #endif
-      { " quotas",	"This host wishes to check quotas on startup.",
-	dmenuVarCheck, dmenuToggleVariable, NULL, "check_quotas=YES" },
       { NULL } },
 };
 


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->randi 
Responsible-Changed-By: randi 
Responsible-Changed-When: Sat Jun 6 18:53:19 UTC 2009 
Responsible-Changed-Why:  
Grabbing this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123237 
State-Changed-From-To: open->patched 
State-Changed-By: brucec 
State-Changed-When: Sat Feb 19 09:24:28 UTC 2011 
State-Changed-Why:  
Fixed in HEAD. 


Responsible-Changed-From-To: randi->brucec 
Responsible-Changed-By: brucec 
Responsible-Changed-When: Sat Feb 19 09:24:28 UTC 2011 
Responsible-Changed-Why:  
Grab. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123237 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/123237: commit references a PR
Date: Sat, 19 Feb 2011 09:24:31 +0000 (UTC)

 Author: brucec
 Date: Sat Feb 19 09:24:24 2011
 New Revision: 218840
 URL: http://svn.freebsd.org/changeset/base/218840
 
 Log:
   Remove the quotas option from the Startup Services menu.
   GENERIC has no support for quotas so this option has no effect.
   
   PR:		bin/123237
   Submitted by:	Lawrence Mayer <lawmay3 at i12.com>
   MFC after:	3 days
 
 Modified:
   head/usr.sbin/sysinstall/menus.c
 
 Modified: head/usr.sbin/sysinstall/menus.c
 ==============================================================================
 --- head/usr.sbin/sysinstall/menus.c	Sat Feb 19 09:08:13 2011	(r218839)
 +++ head/usr.sbin/sysinstall/menus.c	Sat Feb 19 09:24:24 2011	(r218840)
 @@ -1283,8 +1283,6 @@ DMenu MenuStartup = {
        { " SVR4",	"This host wants to be able to run SVR4 binaries.",
  	dmenuVarCheck, dmenuToggleVariable, NULL, "svr4_enable=YES" },
  #endif
 -      { " quotas",	"This host wishes to check quotas on startup.",
 -	dmenuVarCheck, dmenuToggleVariable, NULL, "check_quotas=YES" },
        { NULL } },
  };
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/123237: commit references a PR
Date: Tue, 22 Feb 2011 17:38:49 +0000 (UTC)

 Author: brucec
 Date: Tue Feb 22 17:38:43 2011
 New Revision: 218953
 URL: http://svn.freebsd.org/changeset/base/218953
 
 Log:
   MFC r218840:
   
   Remove the quotas option from the Startup Services menu.
   GENERIC has no support for quotas so this option has no effect.
   
   PR:           bin/123237
   Submitted by: Lawrence Mayer <lawmay3 at i12.com>
 
 Modified:
   stable/8/usr.sbin/sysinstall/menus.c
 Directory Properties:
   stable/8/usr.sbin/sysinstall/   (props changed)
 
 Modified: stable/8/usr.sbin/sysinstall/menus.c
 ==============================================================================
 --- stable/8/usr.sbin/sysinstall/menus.c	Tue Feb 22 17:37:13 2011	(r218952)
 +++ stable/8/usr.sbin/sysinstall/menus.c	Tue Feb 22 17:38:43 2011	(r218953)
 @@ -1287,8 +1287,6 @@ DMenu MenuStartup = {
        { " SVR4",	"This host wants to be able to run SVR4 binaries.",
  	dmenuVarCheck, dmenuToggleVariable, NULL, "svr4_enable=YES" },
  #endif
 -      { " quotas",	"This host wishes to check quotas on startup.",
 -	dmenuVarCheck, dmenuToggleVariable, NULL, "check_quotas=YES" },
        { NULL } },
  };
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: brucec 
State-Changed-When: Tue Feb 22 17:52:32 UTC 2011 
State-Changed-Why:  
Merged to stable/7 and stable/8. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=123237 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/123237: commit references a PR
Date: Tue, 22 Feb 2011 17:50:39 +0000 (UTC)

 Author: brucec
 Date: Tue Feb 22 17:50:33 2011
 New Revision: 218956
 URL: http://svn.freebsd.org/changeset/base/218956
 
 Log:
   MFC r218839, r218840, r218841:
   
   In the distribution list, 'A' is listed as the key to press to select both
   'All' and 'Minimal'. Update the keys for Minimal and Custom to avoid the
   conflict.
   
   Remove the quotas option from the Startup Services menu.
   GENERIC has no support for quotas so this option has no effect.
   
   Allow users to create ufs1 filesystems via the noninteractive install.cfg
   system.
   
   PR:   bin/153809
   PR:   bin/123237
   PR:   bin/113979
 
 Modified:
   stable/7/usr.sbin/sysinstall/label.c
   stable/7/usr.sbin/sysinstall/menus.c
 Directory Properties:
   stable/7/usr.sbin/sysinstall/   (props changed)
 
 Modified: stable/7/usr.sbin/sysinstall/label.c
 ==============================================================================
 --- stable/7/usr.sbin/sysinstall/label.c	Tue Feb 22 17:43:09 2011	(r218955)
 +++ stable/7/usr.sbin/sysinstall/label.c	Tue Feb 22 17:50:33 2011	(r218956)
 @@ -1674,6 +1674,8 @@ diskLabelNonInteractive(Device *dev)
  			pi = tmp->private_data = new_part(PART_FILESYSTEM, mpoint, TRUE);
  			tmp->private_free = safe_free;
  			pi->newfs_data.newfs_ufs.softupdates = soft;
 +			if (!strcmp(typ, "ufs1"))
 +				pi->newfs_data.newfs_ufs.ufs1 = TRUE;
  		    }
  		}
  	    }
 
 Modified: stable/7/usr.sbin/sysinstall/menus.c
 ==============================================================================
 --- stable/7/usr.sbin/sysinstall/menus.c	Tue Feb 22 17:43:09 2011	(r218955)
 +++ stable/7/usr.sbin/sysinstall/menus.c	Tue Feb 22 17:50:33 2011	(r218956)
 @@ -922,9 +922,9 @@ DMenu MenuDistributions = {
  	checkDistUser,		distSetUser },
        { "9 X-User",		"Same as above + X Window System",
  	checkDistXUser,		distSetXUser },
 -      { "A Minimal",		"The smallest configuration possible",
 +      { "B Minimal",		"The smallest configuration possible",
  	checkDistMinimum,	distSetMinimum },
 -      { "B Custom",		"Specify your own distribution set",
 +      { "C Custom",		"Specify your own distribution set",
  	NULL,			dmenuSubmenu, NULL, &MenuSubDistributions, '>', '>', '>' },
        { NULL } },
  };
 @@ -1263,8 +1263,6 @@ DMenu MenuStartup = {
        { " OSF/1",	"This host wants to be able to run DEC OSF/1 binaries.",
  	dmenuVarCheck, configOSF1, NULL, VAR_OSF1_ENABLE "=YES" },
  #endif
 -      { " quotas",	"This host wishes to check quotas on startup.",
 -	dmenuVarCheck, dmenuToggleVariable, NULL, "check_quotas=YES" },
        { NULL } },
  };
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
