From nobody@FreeBSD.org  Fri Mar 14 01:10:51 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B5CA4106566B
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 Mar 2008 01:10:51 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id A1ECA8FC26
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 Mar 2008 01:10:51 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m2E17WLd057627
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 14 Mar 2008 01:07:32 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m2E17WbG057626;
	Fri, 14 Mar 2008 01:07:32 GMT
	(envelope-from nobody)
Message-Id: <200803140107.m2E17WbG057626@www.freebsd.org>
Date: Fri, 14 Mar 2008 01:07:32 GMT
From: Gael Roualland <gael.roualland@dial.oleane.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ipfw2 show_nat regression on 7.0-STABLE
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         121683
>Category:       bin
>Synopsis:       [ipfw]: ipfw2 show_nat regression on 7.0-STABLE
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ipfw
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 14 01:20:01 UTC 2008
>Closed-Date:    Fri Mar 14 09:49:37 UTC 2008
>Last-Modified:  Fri Mar 14 09:50:01 UTC 2008
>Originator:     Gael Roualland
>Release:        7.0-STABLE
>Organization:
>Environment:
FreeBSD jerry.priv 7.0-STABLE FreeBSD 7.0-STABLE #0: Thu Mar 13 21:12:57 CET 2008     gael@jerry:/home/cvsup/obj/home/cvsup/src/sys/JERRY  i386

>Description:
"ipfw show nat config" or "ipfw nat xx config" dumps core in show_nat().
(ipfw2.c rev 1.108.2.3)
>How-To-Repeat:
Add a nat configuration to ipfw rules.
>Fix:
The variable "e" in show_nat is no longer initialized while printing nat configuration since last change;
Trivial diff atatched, thanks.

Patch attached with submission follows:

--- ipfw2.c.orig	2008-03-04 13:07:34.000000000 +0100
+++ ipfw2.c	2008-03-14 02:07:53.000000000 +0100
@@ -5967,6 +5967,7 @@
 			if (frule <= n->id && lrule >= n->id)
 				print_nat_config(&data[i]);
 			i += sizeof(struct cfg_nat);
+			e = (struct cfg_redir *)&data[i];
 			for (redir_cnt = 0; redir_cnt < n->redir_cnt; redir_cnt++) {
 				i += sizeof(struct cfg_redir) + e->spool_cnt * 
 				    sizeof(struct cfg_spool);


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-ipfw 
Responsible-Changed-By: remko 
Responsible-Changed-When: Fri Mar 14 07:40:32 UTC 2008 
Responsible-Changed-Why:  
reassign to ipfw team 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121683 
State-Changed-From-To: open->closed 
State-Changed-By: piso 
State-Changed-When: Fri Mar 14 09:48:02 UTC 2008 
State-Changed-Why:  
Fix submitted to RELENG_7 (rev. 1.108.2.4). 


http://www.freebsd.org/cgi/query-pr.cgi?pr=121683 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/121683: commit references a PR
Date: Fri, 14 Mar 2008 09:41:54 +0000 (UTC)

 piso        2008-03-14 09:41:46 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sbin/ipfw            ipfw2.c 
   Log:
   Fix showing nat rules.
   
   Bug spotted by: Gael Roualland <gael.roualland@dial.oleane.com>
   PR: bin/121683
   
   Revision   Changes    Path
   1.108.2.4  +1 -0      src/sbin/ipfw/ipfw2.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
