From lyndon@orthanc.ca  Thu Mar 13 18:37:12 2008
Return-Path: <lyndon@orthanc.ca>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7E55C1065670
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 13 Mar 2008 18:37:12 +0000 (UTC)
	(envelope-from lyndon@orthanc.ca)
Received: from orthanc.ca (216-40-124-68.ip.van.radiant.net [216.40.124.68])
	by mx1.freebsd.org (Postfix) with ESMTP id 5125E8FC16
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 13 Mar 2008 18:37:12 +0000 (UTC)
	(envelope-from lyndon@orthanc.ca)
Received: from orthanc.ca (localhost6 [127.0.0.1])
	by orthanc.ca (8.14.1/8.14.1) with ESMTP id m2DIMfod092240
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 13 Mar 2008 11:22:42 -0700 (PDT)
	(envelope-from lyndon@orthanc.ca)
Received: (from root@localhost)
	by orthanc.ca (8.14.1/8.14.1/Submit) id m2DIMf26092239;
	Thu, 13 Mar 2008 11:22:41 -0700 (PDT)
	(envelope-from lyndon)
Message-Id: <200803131822.m2DIMf26092239@orthanc.ca>
Date: Thu, 13 Mar 2008 11:22:41 -0700 (PDT)
From: Lyndon Nerenberg <lyndon@orthanc.ca>
Reply-To: Lyndon Nerenberg <lyndon@orthanc.ca>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] nscd prints needless banner
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         121671
>Category:       bin
>Synopsis:       [patch] nscd(8) prints needless banner
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gavin
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 13 18:40:02 UTC 2008
>Closed-Date:    Sun Jan 17 11:28:02 UTC 2010
>Last-Modified:  Sun Jan 17 11:28:02 UTC 2010
>Originator:     Lyndon Nerenberg
>Release:        FreeBSD 7.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD orthanc.ca 7.0-STABLE FreeBSD 7.0-STABLE #1: Wed Mar 12 17:03:12 PDT 2008 root@orthanc.ca:/var/obj/usr/src/sys/GANDALF i386

>Description:
	nscd prints needless verbiage. 
>How-To-Repeat:
	Run nscd and examine the first two lines of output.
>Fix:

--- nscd.c	2008/03/13 18:17:53	1.1
+++ nscd.c	2008/03/13 18:18:16
@@ -622,9 +622,6 @@
 	/* by default all debug messages are omitted */
 	TRACE_OFF();
 
-	/* startup output */
-	print_version_info();
-
 	/* parsing command line arguments */
 	trace_mode_enabled = 0;
 	force_single_threaded = 0;
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->bushman 
Responsible-Changed-By: matteo 
Responsible-Changed-When: Dom 11 Mag 2008 16:34:16 UTC 
Responsible-Changed-Why:  
Michael is nscd's author and can judge about the usefulness of the message. Michael, can you please look at this PR? Thank you in advance 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121671 

From: "Artis Caune" <artis.caune@gmail.com>
To: bug-followup@FreeBSD.org
Cc: lyndon@orthanc.ca
Subject: Re: bin/121671: [PATCH] nscd(8) prints needless banner
Date: Thu, 21 Aug 2008 12:10:31 +0300

 Yeah, this bnner is very annoying.
 
 
 Two more things..
 
 1) There is also typo in man page:
 suggested-size:
     (in 5-10 times) greater then the default hash table size (255).
 
 default is 257 and 255 is not prime number :)
 
 
 --- nscd.conf.5.orig	2007-09-27 15:30:11.000000000 +0300
 +++ nscd.conf.5	2008-08-21 12:09:37.389432688 +0300
 @@ -106,7 +106,7 @@
  This is the internal hash table size.
  The value should be a prime number for optimum performance.
  You should only change this value when the number of cached elements is
 -significantly (in 5-10 times) greater then the default hash table size (255).
 +significantly (in 5-10 times) greater then the default hash table size (257).
  .It Va keep-hot-count Oo Ar cachename Oc Op Ar value
  The size limit of the cache with the given
  .Ar cachename .
 
 
 
 
 2) If I add cache to /etc/nsswitch.conf, rc.d/nsswitch on startup
 print syntax error while regenerating host.conf file:
 
 [root@didii ~]# /etc/rc.d/nsswitch start
 Generating host.conf.
 Warning: unrecognized source [cache],[root@didii ~]#
 
 
 --- /etc/rc.d/nsswitch.orig	2008-03-06 17:44:31.000000000 +0200
 +++ /etc/rc.d/nsswitch	2008-08-21 12:01:49.000000000 +0300
 @@ -79,6 +79,8 @@
  		;;
  	*=*)
  		;;
 +	cache)
 +		;;
  	*)
  		printf "Warning: unrecognized source [%s]", $_s > "/dev/stderr"
  		;;
 
 
 
 
 -- 
 regards,
 Artis Caune
 
 <----. CCNA
 <----|====================
 <----' didii FreeBSD

From: "Artis Caune" <artis.caune@gmail.com>
To: bug-followup@freebsd.org
Cc: lyndon@orthanc.ca
Subject: Re: bin/121671: [PATCH] nscd(8) prints needless banner
Date: Thu, 21 Aug 2008 13:21:33 +0300

 One more typo in /etc/rc.d/nsswitch:
 
 --- /etc/rc.d/nsswitch.orig	2008-03-06 17:44:31.000000000 +0200
 +++ /etc/rc.d/nsswitch	2008-08-21 13:18:41.000000000 +0300
 @@ -79,8 +79,10 @@
  		;;
  	*=*)
  		;;
 +	cache)
 +		;;
  	*)
 -		printf "Warning: unrecognized source [%s]", $_s > "/dev/stderr"
 +		printf "Warning: unrecognized source [%s]\n" $_s > "/dev/stderr"
  		;;
  	esac
      done
 
 
 
 
 
 -- 
 regards,
 Artis Caune
 
 <----. CCNA
 <----|====================
 <----' didii FreeBSD
Responsible-Changed-From-To: bushman->gavin 
Responsible-Changed-By: gavin 
Responsible-Changed-When: Sun Jan 3 17:49:45 UTC 2010 
Responsible-Changed-Why:  
THe main issue has been fixed for some time, I'll handle sorting out the two 
issues pointed out by Artis 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121671 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/121671: commit references a PR
Date: Sun,  3 Jan 2010 19:14:36 +0000 (UTC)

 Author: gavin
 Date: Sun Jan  3 19:14:22 2010
 New Revision: 201440
 URL: http://svn.freebsd.org/changeset/base/201440
 
 Log:
   The default hash table size is 257 not 255.  Reword the rest of the line
   slightly while here.
   
   PR:		bin/121671
   Submitted by:	Artis Caune  artis.caune gmail.com
   Approved by:	ed (mentor)
 
 Modified:
   head/etc/rc.d/nsswitch
 
 Modified: head/etc/rc.d/nsswitch
 ==============================================================================
 --- head/etc/rc.d/nsswitch	Sun Jan  3 18:27:10 2010	(r201439)
 +++ head/etc/rc.d/nsswitch	Sun Jan  3 19:14:22 2010	(r201440)
 @@ -77,10 +77,10 @@ generate_host_conf()
  	nis)
  		echo "nis" >> $host_conf
  		;;
 -	*=*)
 +	cache | *=*)
  		;;
  	*)
 -		printf "Warning: unrecognized source [%s]", $_s > "/dev/stderr"
 +		printf "Warning: unrecognized source [%s]\n" $_s > "/dev/stderr"
  		;;
  	esac
      done
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/121671: commit references a PR
Date: Sun,  3 Jan 2010 19:29:00 +0000 (UTC)

 Author: gavin
 Date: Sun Jan  3 19:28:51 2010
 New Revision: 201441
 URL: http://svn.freebsd.org/changeset/base/201441
 
 Log:
   The default hash table size is 257 not 255.  Reword the rest of the line
   slightly while here.
   
   PR:		bin/121671
   Submitted by:	Artis Caune  artis.caune gmail.com
   Approved by:	ed (mentor)
 
 Modified:
   head/usr.sbin/nscd/nscd.conf.5
 
 Modified: head/usr.sbin/nscd/nscd.conf.5
 ==============================================================================
 --- head/usr.sbin/nscd/nscd.conf.5	Sun Jan  3 19:14:22 2010	(r201440)
 +++ head/usr.sbin/nscd/nscd.conf.5	Sun Jan  3 19:28:51 2010	(r201441)
 @@ -106,7 +106,7 @@ The default policy is fifo.
  This is the internal hash table size.
  The value should be a prime number for optimum performance.
  You should only change this value when the number of cached elements is
 -significantly (in 5-10 times) greater then the default hash table size (255).
 +significantly (5-10 times) greater than the default hash table size (257).
  .It Va keep-hot-count Oo Ar cachename Oc Op Ar value
  The size limit of the cache with the given
  .Ar cachename .
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: gavin 
State-Changed-When: Sun Jan 3 19:31:32 UTC 2010 
State-Changed-Why:  
Fixed in HEAD, MFC in two weeks 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121671 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/121671: commit references a PR
Date: Sun,  3 Jan 2010 21:27:19 +0000 (UTC)

 Author: gavin
 Date: Sun Jan  3 21:27:10 2010
 New Revision: 201445
 URL: http://svn.freebsd.org/changeset/base/201445
 
 Log:
   Forced commit, to provide correct commit message for r201440:
   
   Don't complain when we encounter the "cache" source, it's valid.  Also fix
   the error message to include a line feed and not include a stray comma.
   
   PR:		bin/121671
   Submitted by:	Artis Caune  artis.caune gmail.com
   Approved by:	ed (mentor)
   MFC after:	2 weeks
   
   While here, change "> /dev/stderr" for more usual ">&2"
   
   Submitted by:	jilles
 
 Modified:
   head/etc/rc.d/nsswitch
 
 Modified: head/etc/rc.d/nsswitch
 ==============================================================================
 --- head/etc/rc.d/nsswitch	Sun Jan  3 20:45:49 2010	(r201444)
 +++ head/etc/rc.d/nsswitch	Sun Jan  3 21:27:10 2010	(r201445)
 @@ -80,7 +80,7 @@ generate_host_conf()
  	cache | *=*)
  		;;
  	*)
 -		printf "Warning: unrecognized source [%s]\n" $_s > "/dev/stderr"
 +		printf "Warning: unrecognized source [%s]\n" $_s >&2
  		;;
  	esac
      done
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/121671: commit references a PR
Date: Sun, 17 Jan 2010 11:10:43 +0000 (UTC)

 Author: gavin
 Date: Sun Jan 17 11:10:24 2010
 New Revision: 202464
 URL: http://svn.freebsd.org/changeset/base/202464
 
 Log:
   Merge r201440, r201445 from head:
   
     Don't complain when we encounter the "cache" source, it's valid.  Also fix
     the error message to include a line feed and not include a stray comma.
   
     Submitted by: Artis Caune  artis.caune gmail.com
   
     While here, change "> /dev/stderr" for more usual ">&2"
   
     Submitted by: jilles
   
   PR:		bin/121671
   Approved by:	ed (mentor, implicit)
 
 Modified:
   stable/8/etc/rc.d/nsswitch
 Directory Properties:
   stable/8/etc/rc.d/   (props changed)
 
 Modified: stable/8/etc/rc.d/nsswitch
 ==============================================================================
 --- stable/8/etc/rc.d/nsswitch	Sun Jan 17 10:59:07 2010	(r202463)
 +++ stable/8/etc/rc.d/nsswitch	Sun Jan 17 11:10:24 2010	(r202464)
 @@ -77,10 +77,10 @@ generate_host_conf()
  	nis)
  		echo "nis" >> $host_conf
  		;;
 -	*=*)
 +	cache | *=*)
  		;;
  	*)
 -		printf "Warning: unrecognized source [%s]", $_s > "/dev/stderr"
 +		printf "Warning: unrecognized source [%s]\n" $_s >&2
  		;;
  	esac
      done
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/121671: commit references a PR
Date: Sun, 17 Jan 2010 11:10:49 +0000 (UTC)

 Author: gavin
 Date: Sun Jan 17 11:10:32 2010
 New Revision: 202465
 URL: http://svn.freebsd.org/changeset/base/202465
 
 Log:
   Merge r201440, r201445 from head:
   
     Don't complain when we encounter the "cache" source, it's valid.  Also fix
     the error message to include a line feed and not include a stray comma.
   
     Submitted by: Artis Caune  artis.caune gmail.com
   
     While here, change "> /dev/stderr" for more usual ">&2"
   
     Submitted by: jilles
   
   PR:		bin/121671
   Approved by:	ed (mentor, implicit)
 
 Modified:
   stable/7/etc/rc.d/nsswitch
 Directory Properties:
   stable/7/etc/rc.d/   (props changed)
 
 Modified: stable/7/etc/rc.d/nsswitch
 ==============================================================================
 --- stable/7/etc/rc.d/nsswitch	Sun Jan 17 11:10:24 2010	(r202464)
 +++ stable/7/etc/rc.d/nsswitch	Sun Jan 17 11:10:32 2010	(r202465)
 @@ -77,10 +77,10 @@ generate_host_conf()
  	nis)
  		echo "nis" >> $host_conf
  		;;
 -	*=*)
 +	cache | *=*)
  		;;
  	*)
 -		printf "Warning: unrecognized source [%s]", $_s > "/dev/stderr"
 +		printf "Warning: unrecognized source [%s]\n" $_s >&2
  		;;
  	esac
      done
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gavin 
State-Changed-When: Sun Jan 17 11:26:54 UTC 2010 
State-Changed-Why:  
All the issues raised in this PR have now been merged.  Thanks all 
for your submissions! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=121671 
>Unformatted:
