From nobody@FreeBSD.org  Wed Jan 30 17:28:29 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4B72616A421
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Jan 2008 17:28:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 4034C13C4D5
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Jan 2008 17:28:29 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m0UHQeiX028375
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 30 Jan 2008 17:26:40 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m0UHQeHf028373;
	Wed, 30 Jan 2008 17:26:40 GMT
	(envelope-from nobody)
Message-Id: <200801301726.m0UHQeHf028373@www.freebsd.org>
Date: Wed, 30 Jan 2008 17:26:40 GMT
From: Niki Denev <nike_d@cytexbg.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: unable to remount/update gjournaled fs with "current" option
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         120162
>Category:       bin
>Synopsis:       [patch] mount(1): unable to remount/update gjournaled fs with "current" option
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    matteo
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 30 17:30:02 UTC 2008
>Closed-Date:    Mon Mar 31 11:02:40 UTC 2008
>Last-Modified:  Mon Mar 31 11:02:40 UTC 2008
>Originator:     Niki Denev
>Release:        FreeBSD 7.0-BETA2
>Organization:
>Environment:
FreeBSD ndenev 7.0-BETA2 FreeBSD 7.0-BETA2 #5: Sat Nov  3 18:13:12 EET 2007     ndenev@ndenev:/usr/obj/usr/src/sys/XXX  i386
>Description:
When doing mount update with "current" option, mount(8) treats "gjournal" as mount option and tries to apply it. But "gjournal" is a flag, and not an mount option.
>How-To-Repeat:
do a :
# mount -u -ocurrent $fs
on a gjournaled $fs filesystem.
>Fix:
The applied patch to mount.c:flags2opts() fixes the problem by not reporting "gjournal" as option.


Patch attached with submission follows:

--- sbin/mount/mount.c.orig	2008-01-30 19:15:20.000000000 +0200
+++ sbin/mount/mount.c	2008-01-30 19:16:09.000000000 +0200
@@ -871,7 +871,6 @@
 	if (flags & MNT_SUIDDIR)	res = catopt(res, "suiddir");
 	if (flags & MNT_MULTILABEL)	res = catopt(res, "multilabel");
 	if (flags & MNT_ACLS)		res = catopt(res, "acls");
-	if (flags & MNT_GJOURNAL)	res = catopt(res, "gjournal");
 
 	return (res);
 }


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->matteo 
Responsible-Changed-By: matteo 
Responsible-Changed-When: Lun 4 Feb 2008 07:31:09 UTC 
Responsible-Changed-Why:  
Take this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120162 
State-Changed-From-To: open->patched 
State-Changed-By: matteo 
State-Changed-When: Lun 4 Feb 2008 07:38:01 UTC 
State-Changed-Why:  
Fix committed to HEAD. MFC coming in a week 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120162 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/120162: commit references a PR
Date: Mon,  4 Feb 2008 07:38:05 +0000 (UTC)

 matteo      2008-02-04 07:37:57 UTC
 
   FreeBSD src repository
 
   Modified files:
     sbin/mount           mount.c 
   Log:
   Fix mount -p and mount -u -ocurrent on gjournaled FS
   
   PR:             bin/120162
   Submitted by:   Niki Denev
   MFC after:      1 week
   
   Revision  Changes    Path
   1.98      +0 -1      src/sbin/mount/mount.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/120162: commit references a PR
Date: Sun, 30 Mar 2008 19:42:40 +0000 (UTC)

 matteo      2008-03-30 19:42:34 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     sbin/mount           mount.c 
   Log:
   MFC rev. 1.97-1.98
   
   Fix printing of unionfs mounts when using the -p option
   Fix mount -p and mount -u -ocurrent on gjournaled FS
   
   PR: bin/75585, bin/120162
   
   Revision  Changes    Path
   1.96.2.1  +8 -3      src/sbin/mount/mount.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: matteo 
State-Changed-When: Lun 31 Mar 2008 11:02:21 UTC 
State-Changed-Why:  
MFC'ed to RELENG_7 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120162 
>Unformatted:
