From ab@purple.the-7.net  Mon Jan 28 13:35:31 2008
Return-Path: <ab@purple.the-7.net>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0CA7F16A419
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Jan 2008 13:35:31 +0000 (UTC)
	(envelope-from ab@purple.the-7.net)
Received: from purple.the-7.net (purple.the-7.net [IPv6:2001:470:1f01:622:230:48ff:fe23:4c67])
	by mx1.freebsd.org (Postfix) with ESMTP id EBB8913C448
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Jan 2008 13:35:30 +0000 (UTC)
	(envelope-from ab@purple.the-7.net)
Received: from purple.the-7.net (ab@localhost.the-7.net [127.0.0.1])
	by purple.the-7.net (8.14.2/8.14.2) with ESMTP id m0SDZPKu081873
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=OK)
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 28 Jan 2008 05:35:25 -0800 (PST)
	(envelope-from ab@purple.the-7.net)
Received: (from ab@localhost)
	by purple.the-7.net (8.14.2/8.14.2/Submit) id m0SDZPTR081866;
	Mon, 28 Jan 2008 05:35:25 -0800 (PST)
	(envelope-from ab)
Message-Id: <200801281335.m0SDZPTR081866@purple.the-7.net>
Date: Mon, 28 Jan 2008 05:35:25 -0800 (PST)
From: "Eugene M. Kim" <20080111.freebsd.org@ab.ote.we.lv>
Reply-To: "Eugene M. Kim" <20080111.freebsd.org@ab.ote.we.lv>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [REGRESSION] loader_conf_files in /boot/loader.conf no longer works
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         120084
>Category:       bin
>Synopsis:       [boot] loader_conf_files in /boot/loader.conf no longer works [regression]
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    luigi
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 28 13:40:00 UTC 2008
>Closed-Date:    Fri Jan 30 16:11:05 UTC 2009
>Last-Modified:  Fri Jan 30 16:11:28 UTC 2009
>Originator:     Eugene M. Kim
>Release:        FreeBSD 7.0-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD purple.the-7.net 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #2: Mon Jan 28 03:35:57 PST 2008 ab@purple.the-7.net:/home/FreeBSD/build/RELENG_7/obj/home/FreeBSD/build/RELENG_7/src/sys/PURPLE i386
>Description:
On RELENG_6, setting loader_conf_files used to cause the boot loader to
read and process the specified configuration files, as documented in
loader.conf(5).

On RELENG_7, setting loader_conf_files has no effect.
>How-To-Repeat:
Specify in /boot/loader.conf:

	loader_conf_files="/boot/modules.conf"

with the modules.conf containing a bunch of kmod-loading directives
(MODULENAME_load="YES") and reboot.  The modules.conf is not processed,
and the modules specified therein are not loaded.
>Fix:
None known.
>Release-Note:
>Audit-Trail:

From: Sam Banks <samb@catalyst.net.nz>
To: bug-followup@FreeBSD.org, 20080111.freebsd.org@ab.ote.we.lv
Cc:  
Subject: Re: bin/120084: [boot] loader_conf_files in /boot/loader.conf no
 longer works [regression]
Date: Thu, 19 Jun 2008 09:03:51 +1200

 I've tested this on 7.0-RELEASE and can't reproduce the problem using 
 the following:
 
 Inside /boot/loader.conf, I have loader_conf_files="/boot/modules.conf". 
 Inside /boot/modules.conf, I have nullfs_load="YES" and ntfs_load="YES". 
 When I reboot, both of those modules are loaded into the kernel.
 
 The only thing I can do to reproduce the results is, inside 
 /boot/modules.conf, modify it to read NULLFS_load="YES" and 
 NTFS_load="YES". I wasn't sure if the capitilised module name inside 
 MODULENAME_load="YES" was just a "replace with lower case module name" 
 or whether the module name is being entered in capitals.
 
 Just to check the basics:
 
 1. Is loader_conf_files spelled correctly in /boot/loader.conf?
 
 2. Does the value of loader_conf_files in /boot/loader.conf match the 
 file in /boot it's meant to load?
 
 3. Do the modules load when you kldload them manually when the system is 
 up and running?

From: "Eugene M. Kim" <20080111.freebsd.org@ab.ote.we.lv>
To: Sam Banks <samb@catalyst.net.nz>
Cc: bug-followup@FreeBSD.org
Subject: Re: bin/120084: [boot] loader_conf_files in /boot/loader.conf no
 longer works [regression]
Date: Thu, 19 Jun 2008 08:38:30 -0700

 Sam Banks wrote:
 > I've tested this on 7.0-RELEASE and can't reproduce the problem using
 > the following:
 >
 > Inside /boot/loader.conf, I have
 > loader_conf_files="/boot/modules.conf". Inside /boot/modules.conf, I
 > have nullfs_load="YES" and ntfs_load="YES". When I reboot, both of
 > those modules are loaded into the kernel.
 >
 > The only thing I can do to reproduce the results is, inside
 > /boot/modules.conf, modify it to read NULLFS_load="YES" and
 > NTFS_load="YES". I wasn't sure if the capitilised module name inside
 > MODULENAME_load="YES" was just a "replace with lower case module name"
 > or whether the module name is being entered in capitals.
 >
 > Just to check the basics:
 >
 > 1. Is loader_conf_files spelled correctly in /boot/loader.conf?
 >
 > 2. Does the value of loader_conf_files in /boot/loader.conf match the
 > file in /boot it's meant to load?
 >
 > 3. Do the modules load when you kldload them manually when the system
 > is up and running?
 
 Yes to all three of them (at least on the 8-CURRENT machine that
 exhibits the same problem).
 
 I recently installed VMware on one of my spare machines, and will try
 soon to reproduce the problem from scratch.
 
 Eugene
 

From: Luigi Rizzo <rizzo@iet.unipi.it>
To: bug-followup@FreeBSD.org, 20080111.freebsd.org@ab.ote.we.lv
Cc:  
Subject: Re: bin/120084: [boot] loader_conf_files in /boot/loader.conf no longer works [regression]
Date: Sun, 18 Jan 2009 21:23:14 +0100

 this PR can be closed.
 The handling of loader_conf_files was broken and it depended on
 the address returned on a realloc (basically, the assignment
 was ignored if the new value for the variable fit the same
 buffer used for the old variable).
 
 This has been fixed in HEAD back in dec.2008, and in RELENG_7
 a week ago
 
 	cheers
 	luigi
 
State-Changed-From-To: open->closed 
State-Changed-By: keramida 
State-Changed-When: Fri Jan 30 16:09:59 UTC 2009 
State-Changed-Why:  
luigi@ has fixed this 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120084 
Responsible-Changed-From-To: freebsd-bugs->luigi 
Responsible-Changed-By: keramida 
Responsible-Changed-When: Fri Jan 30 16:11:15 UTC 2009 
Responsible-Changed-Why:  
Mark as fixed by luigi. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120084 
>Unformatted:
