From nobody@FreeBSD.org  Sun Jan 27 12:01:59 2008
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7538316A475
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Jan 2008 12:01:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 61A2113C47E
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Jan 2008 12:01:59 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id m0RC0HH7016224
	for <freebsd-gnats-submit@FreeBSD.org>; Sun, 27 Jan 2008 12:00:17 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id m0RC0HI9016223;
	Sun, 27 Jan 2008 12:00:17 GMT
	(envelope-from nobody)
Message-Id: <200801271200.m0RC0HI9016223@www.freebsd.org>
Date: Sun, 27 Jan 2008 12:00:17 GMT
From: mattijs vreeling <mattijs.vreeling@snow.nl>
To: freebsd-gnats-submit@FreeBSD.org
Subject: dnsbl features in sendmail mc file not showing up in cf file
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         120038
>Category:       bin
>Synopsis:       sendmail(8): dnsbl features in sendmail mc file not showing up in cf file
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gshapiro
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 27 12:10:01 UTC 2008
>Closed-Date:    Sun Feb 24 01:04:39 UTC 2008
>Last-Modified:  Sun Feb 24 01:10:08 UTC 2008
>Originator:     mattijs vreeling
>Release:        6.3-STABLE
>Organization:
snow
>Environment:
FreeBSD linq.nxdomain.nl 6.3-STABLE FreeBSD 6.3-STABLE #3: Wed Jan 23 23:47:47 CET 2008 root@linq.nxdomain.nl:/usr/obj/usr/src/sys/LINQ_KERN i386
>Description:
when adding the dnsbl feature to the mc file, in my case
/etc/mail/linq.nxdomain.nl.mc, after running make && make install the
rule isn't showing up in the sendmail.cf file. 

-- line in .mc file --
FEATURE(dnsbl, `sbl.spamhaus.org', `"550 Mail from " $&{client_addr} " on SBL, see http://www.spamhaus.org/query/bl?ip=" $&{client_addr}')

-- lines in .cf file --
# DNS based IP address spam list sbl.spamhaus.org
R$*                     $: $&{client_addr}
R$-.$-.$-.$-            $: <?> $(dnsbl $4.$3.$2.$1.sbl.spamhaus.org. $: OK $)
R<?>OK                  $: OKSOFAR
R<?>$+<TMP>             $: TMPOK

-- expected lines in .cf file --
# DNS based IP address spam list sbl.spamhaus.org
R$*                     $: $&{client_addr}
R$-.$-.$-.$-            $: <?> $(dnsbl $4.$3.$2.$1.sbl.spamhaus.org. $: OK $)
R<?>OK                  $: OKSOFAR
R<?>$+<TMP>             $: TMPOK
R<?>$+                  $#error $@ 5.7.1 $: "550 Mail from " $&{client_addr} " on SBL, see http://www.spamhaus.org/query/bl?ip=" $&{client_addr}

>How-To-Repeat:
add FEATURE(dnsbl, `sbl.spamhaus.org', `"550 Mail from " $&{client_addr} "
on SBL, see http://www.spamhaus.org/query/bl?ip=" $&{client_addr}') to
.mc file and run make && make install from /etc/mail
>Fix:
workaround for me at the moment is to add the rewrite line in my
sendmail.cf file manually. 

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->gshapiro 
Responsible-Changed-By: remko 
Responsible-Changed-When: Sun Jan 27 21:51:11 UTC 2008 
Responsible-Changed-Why:  
Hello Gregory, can you look at this PR from my collegue? If i can help to
fix the problem let me know! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120038 
State-Changed-From-To: open->feedback 
State-Changed-By: gshapiro 
State-Changed-When: Mon Jan 28 03:41:47 UTC 2008 
State-Changed-Why:  
This is happening because of the way m4 handles commas.  You can 
fix this by using double quoting: 

FEATURE(dnsbl, `sbl.spamhaus.org', ``"550 Mail from " $&{client_addr} " on SBL, see http://www.spamhaus.org/query/bl?ip=" $&{client_addr}'') 

or by not using a comma in the text: 

FEATURE(dnsbl, `sbl.spamhaus.org', `"550 Mail from " $&{client_addr} " on SBL see http://www.spamhaus.org/query/bl?ip=" $&{client_addr}') 



http://www.freebsd.org/cgi/query-pr.cgi?pr=120038 

From: Mattijs Vreeling <mattijs.vreeling@snow.nl>
To: gshapiro@FreeBSD.org, bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/120038: sendmail(8): dnsbl features in sendmail mc file not
 showing up in cf file
Date: Mon, 28 Jan 2008 08:45:10 +0100

 Ah, makes sense. It's just that this was working with FreeBSD 
 6.2-PRERELEASE from about a year back. Also, the example .mc file has 
 the wrong syntax then:
 
 -- freebsd.mc --
 VERSIONID(`$FreeBSD: src/etc/sendmail/freebsd.mc,v 1.30.2.4 2007/11/22 
 16:20:01 gshapiro Exp $')
 <snip>
 dnl FEATURE(dnsbl, `blackholes.mail-abuse.org', `"550 Mail from " 
 $&{client_addr} " rejected, see http://mail-abuse.org/cgi-bin/lookup?" 
 $&{client_addr}')
 --
 
 Cheers,
 Mattijs
 
 gshapiro@FreeBSD.org wrote:
 > Synopsis: sendmail(8): dnsbl features in sendmail mc file not showing up in cf file
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: gshapiro
 > State-Changed-When: Mon Jan 28 03:41:47 UTC 2008
 > State-Changed-Why: 
 > This is happening because of the way m4 handles commas.  You can
 > fix this by using double quoting:
 >
 > FEATURE(dnsbl, `sbl.spamhaus.org', ``"550 Mail from " $&{client_addr} " on SBL, see http://www.spamhaus.org/query/bl?ip=" $&{client_addr}'')
 >
 > or by not using a comma in the text:
 >
 > FEATURE(dnsbl, `sbl.spamhaus.org', `"550 Mail from " $&{client_addr} " on SBL see http://www.spamhaus.org/query/bl?ip=" $&{client_addr}')
 >
 >
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=120038
 >   
 
 
State-Changed-From-To: feedback->patched 
State-Changed-By: gshapiro 
State-Changed-When: Sun Feb 17 05:39:09 UTC 2008 
State-Changed-Why:  
I fixed the example in freebsd.mc.  This broke due to new parsing 
in cf/feature/dnsbl.m4 for features added in 8.14.  The change is 
committed to HEAD and will be MFC'ed in a week. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120038 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/120038: commit references a PR
Date: Sun, 17 Feb 2008 05:38:34 +0000 (UTC)

 gshapiro    2008-02-17 05:38:30 UTC
 
   FreeBSD src repository
 
   Modified files:
     etc/sendmail         freebsd.mc 
   Log:
   Fix quoting for the dnsbl example -- m4 misparses quoted strings with
   commas due to our deconstruction of the line in cf/feature/dnsbl.m4.
   
   PR:             120038
   Submitted by:   mattijs vreeling
   MFC after:      1 week
   
   Revision  Changes    Path
   1.36      +1 -1      src/etc/sendmail/freebsd.mc
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: patched->closed 
State-Changed-By: gshapiro 
State-Changed-When: Sun Feb 24 01:02:43 UTC 2008 
State-Changed-Why:  
Change MFC'ed to RELENG_{7,6,5,4} 

http://www.freebsd.org/cgi/query-pr.cgi?pr=120038 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/120038: commit references a PR
Date: Sun, 24 Feb 2008 01:02:23 +0000 (UTC)

 gshapiro    2008-02-24 01:02:18 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_7)
     etc/sendmail         freebsd.mc 
   Log:
   MFC: Fix quoting for the dnsbl example -- m4 misparses quoted strings with
        commas due to our deconstruction of the line in cf/feature/dnsbl.m4.
   
        PR:             120038
        Submitted by:   mattijs vreeling
   
        Revision  Changes    Path
        1.36      +1 -1      src/etc/sendmail/freebsd.mc
   
   Revision  Changes    Path
   1.34.2.2  +1 -1      src/etc/sendmail/freebsd.mc
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/120038: commit references a PR
Date: Sun, 24 Feb 2008 01:03:15 +0000 (UTC)

 gshapiro    2008-02-24 01:03:11 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_6)
     etc/sendmail         freebsd.mc 
   Log:
   MFC: Fix quoting for the dnsbl example -- m4 misparses quoted strings with
        commas due to our deconstruction of the line in cf/feature/dnsbl.m4.
   
        PR:             120038
        Submitted by:   mattijs vreeling
   
        Revision  Changes    Path
        1.36      +1 -1      src/etc/sendmail/freebsd.mc
   
   Revision  Changes    Path
   1.30.2.5  +1 -1      src/etc/sendmail/freebsd.mc
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/120038: commit references a PR
Date: Sun, 24 Feb 2008 01:03:30 +0000 (UTC)

 gshapiro    2008-02-24 01:03:24 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_5)
     etc/sendmail         freebsd.mc 
   Log:
   MFC: Fix quoting for the dnsbl example -- m4 misparses quoted strings with
        commas due to our deconstruction of the line in cf/feature/dnsbl.m4.
   
        PR:             120038
        Submitted by:   mattijs vreeling
   
        Revision  Changes    Path
        1.36      +1 -1      src/etc/sendmail/freebsd.mc
   
   Revision  Changes    Path
   1.29.2.5  +1 -1      src/etc/sendmail/freebsd.mc
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/120038: commit references a PR
Date: Sun, 24 Feb 2008 01:03:40 +0000 (UTC)

 gshapiro    2008-02-24 01:03:33 UTC
 
   FreeBSD src repository
 
   Modified files:        (Branch: RELENG_4)
     etc/sendmail         freebsd.mc 
   Log:
   MFC: Fix quoting for the dnsbl example -- m4 misparses quoted strings with
        commas due to our deconstruction of the line in cf/feature/dnsbl.m4.
   
        PR:             120038
        Submitted by:   mattijs vreeling
   
        Revision  Changes    Path
        1.36      +1 -1      src/etc/sendmail/freebsd.mc
   
   Revision   Changes    Path
   1.10.2.24  +1 -1      src/etc/sendmail/freebsd.mc
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
