From nobody@FreeBSD.ORG Wed Jun  2 07:07:06 1999
Return-Path: <nobody@FreeBSD.ORG>
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 150DF15124; Wed,  2 Jun 1999 07:07:06 -0700 (PDT)
Message-Id: <19990602140706.150DF15124@hub.freebsd.org>
Date: Wed,  2 Jun 1999 07:07:06 -0700 (PDT)
From: dima@server.ru
Sender: nobody@FreeBSD.ORG
To: freebsd-gnats-submit@freebsd.org
Subject: /usr/src/sbin/mountd/mountd.c has '#ifdef __NetBSD' a msdosfs_args in union 'args' that used in mount call
X-Send-Pr-Version: www-1.0

>Number:         11992
>Category:       bin
>Synopsis:       /usr/src/sbin/mountd/mountd.c has '#ifdef __NetBSD' a msdosfs_args in union 'args' that used in mount call
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jun  2 07:10:01 PDT 1999
>Closed-Date:    Sun Apr 22 14:19:07 PDT 2001
>Last-Modified:  Sun Apr 22 14:23:39 PDT 2001
>Originator:     Dmitry Kazarov
>Release:        FreeBSD-3.2-STABLE
>Organization:
Server Inc
>Environment:
>Description:
lines 1647-1654 of /usr/src/sbin/mountd/mountd.c are:
union {
        struct ufs_args ua;
        struct iso_args ia;
        struct mfs_args ma;
#ifdef __NetBSD__
        struct msdosfs_args da;
#endif
} args;

late in lines 1730-1731 that union used in mount (2) call:
while (mount(fsb->f_fstypename, ... , (caddr_t)&args) < 0 ) {

Other occurences of msdosfs are not #ifdef-ed (lines 66, 775-780, 784) so that ifdef could case a problem on exporting msdos fs. 
>How-To-Repeat:
Just look there
>Fix:
Remove lines 1651 and 1653.

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: iedowse 
State-Changed-When: Sun Apr 22 14:19:07 PDT 2001 
State-Changed-Why:  
Fixed in revision 1.48 of mountd.c, as part of some other 
changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=11992 
>Unformatted:
