From dan@kulesh.obluda.cz  Wed Jan  9 10:26:36 2008
Return-Path: <dan@kulesh.obluda.cz>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 717FA16A41A
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  9 Jan 2008 10:26:36 +0000 (UTC)
	(envelope-from dan@kulesh.obluda.cz)
Received: from smtp1.kolej.mff.cuni.cz (smtp1.kolej.mff.cuni.cz [78.128.192.10])
	by mx1.freebsd.org (Postfix) with ESMTP id F2BC413C478
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  9 Jan 2008 10:26:35 +0000 (UTC)
	(envelope-from dan@kulesh.obluda.cz)
Received: from kulesh.obluda.cz (openvpn.ms.mff.cuni.cz [195.113.20.87])
	by smtp1.kolej.mff.cuni.cz (8.13.8/8.13.8) with ESMTP id m09AQKNk054853
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 9 Jan 2008 11:26:21 +0100 (CET)
	(envelope-from dan@kulesh.obluda.cz)
Received: from kulesh.obluda.cz (localhost. [127.0.0.1])
	by kulesh.obluda.cz (8.14.2/8.14.2) with ESMTP id m09AQJi0049434
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 9 Jan 2008 11:26:19 +0100 (CET)
	(envelope-from dan@kulesh.obluda.cz)
Received: (from root@localhost)
	by kulesh.obluda.cz (8.14.2/8.14.1/Submit) id m09AQJhf049433;
	Wed, 9 Jan 2008 11:26:19 +0100 (CET)
	(envelope-from dan)
Message-Id: <200801091026.m09AQJhf049433@kulesh.obluda.cz>
Date: Wed, 9 Jan 2008 11:26:19 +0100 (CET)
From: Dan Lukes <dan@obluda.cz>
Reply-To: Dan Lukes <dan@obluda.cz>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: vidcontrol miss latest VESA mode (off-by-one bug)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         119483
>Category:       bin
>Synopsis:       [patch] vidcontrol(1) misses latest VESA mode (off-by-one bug)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Jan 09 10:30:01 UTC 2008
>Closed-Date:    
>Last-Modified:  Fri May 17 00:50:01 UTC 2013
>Originator:     Dan Lukes
>Release:        FreeBSD 6.3-PRERELEASE i386
>Organization:
Obludarium
>Environment:
System: FreeBSD kulesh.obluda.cz 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #0: Mon Jan 7 20:31:37 CET 2008 root@:/usr/obj/usr/src/sys/KULESH i386
src/usr.sbin/vidcontrol/vidcontrol.c,v 1.52.2.2 2006/10/04 06:09:11

>Description:
	vidcontrol -i mode
	miss the mode 0x1ff=M_VESA_MODE_MAX in listing due off-by-one bug
	The M_VESA_MODE_MAX is latest valid mode - not the first invalid

>How-To-Repeat:
	use vidcontrol -i mode on hardware which has 0x1ff mode - it will
not be listed
>Fix:


--- /usr/src/usr.sbin/vidcontrol/vidcontrol.c.ORIG	2008-01-09 11:20:05.000000000 +0100
+++ /usr/src/usr.sbin/vidcontrol/vidcontrol.c	2008-01-09 11:20:35.000000000 +0100
@@ -960,7 +960,7 @@
 	printf("---------------------------------------"
 	       "---------------------------------------\n");
 
-	for (mode = 0; mode < M_VESA_MODE_MAX; ++mode) {
+	for (mode = 0; mode <= M_VESA_MODE_MAX; ++mode) {
 		_info.vi_mode = mode;
 		if (ioctl(0, CONS_MODEINFO, &_info))
 			continue;

>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/119483: commit references a PR
Date: Sat, 11 May 2013 13:32:45 +0000 (UTC)

 Author: eadler
 Date: Sat May 11 13:32:38 2013
 New Revision: 250509
 URL: http://svnweb.freebsd.org/changeset/base/250509
 
 Log:
   The M_VESA_MODE_MAX is latest valid mode - not the first invalid.
   Permit its use in vidcontrol -i
   
   PR:		bin/119483
   Submitted by:	Dan Lukes <dan@obluda.cz>
   Arrival-Date:	Wed Jan 09 10:30:01 UTC 2008
   Reviewed by:	ed
   MFC after:	3 days
 
 Modified:
   head/usr.sbin/vidcontrol/vidcontrol.c
 
 Modified: head/usr.sbin/vidcontrol/vidcontrol.c
 ==============================================================================
 --- head/usr.sbin/vidcontrol/vidcontrol.c	Sat May 11 13:21:31 2013	(r250508)
 +++ head/usr.sbin/vidcontrol/vidcontrol.c	Sat May 11 13:32:38 2013	(r250509)
 @@ -959,7 +959,7 @@ show_mode_info(void)
  	printf("---------------------------------------"
  	       "---------------------------------------\n");
  
 -	for (mode = 0; mode < M_VESA_MODE_MAX; ++mode) {
 +	for (mode = 0; mode <= M_VESA_MODE_MAX; ++mode) {
  		_info.vi_mode = mode;
  		if (ioctl(0, CONS_MODEINFO, &_info))
  			continue;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/119483: commit references a PR
Date: Fri, 17 May 2013 00:41:09 +0000 (UTC)

 Author: eadler
 Date: Fri May 17 00:40:48 2013
 New Revision: 250730
 URL: http://svnweb.freebsd.org/changeset/base/250730
 
 Log:
   MFC r250509:
   	The M_VESA_MODE_MAX is latest valid mode - not the first invalid.
   	Permit its use in vidcontrol -i
   
   PR:		bin/119483
 
 Modified:
   stable/8/usr.sbin/vidcontrol/vidcontrol.c
 
 Modified: stable/8/usr.sbin/vidcontrol/vidcontrol.c
 ==============================================================================
 --- stable/8/usr.sbin/vidcontrol/vidcontrol.c	Fri May 17 00:40:46 2013	(r250729)
 +++ stable/8/usr.sbin/vidcontrol/vidcontrol.c	Fri May 17 00:40:48 2013	(r250730)
 @@ -961,7 +961,7 @@ show_mode_info(void)
  	printf("---------------------------------------"
  	       "---------------------------------------\n");
  
 -	for (mode = 0; mode < M_VESA_MODE_MAX; ++mode) {
 +	for (mode = 0; mode <= M_VESA_MODE_MAX; ++mode) {
  		_info.vi_mode = mode;
  		if (ioctl(0, CONS_MODEINFO, &_info))
  			continue;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/119483: commit references a PR
Date: Fri, 17 May 2013 00:41:05 +0000 (UTC)

 Author: eadler
 Date: Fri May 17 00:40:46 2013
 New Revision: 250729
 URL: http://svnweb.freebsd.org/changeset/base/250729
 
 Log:
   MFC r250509:
   	The M_VESA_MODE_MAX is latest valid mode - not the first invalid.
   	Permit its use in vidcontrol -i
   
   PR:		bin/119483
 
 Modified:
   stable/9/usr.sbin/vidcontrol/vidcontrol.c
 Directory Properties:
   stable/9/usr.sbin/vidcontrol/   (props changed)
 
 Modified: stable/9/usr.sbin/vidcontrol/vidcontrol.c
 ==============================================================================
 --- stable/9/usr.sbin/vidcontrol/vidcontrol.c	Fri May 17 00:26:56 2013	(r250728)
 +++ stable/9/usr.sbin/vidcontrol/vidcontrol.c	Fri May 17 00:40:46 2013	(r250729)
 @@ -961,7 +961,7 @@ show_mode_info(void)
  	printf("---------------------------------------"
  	       "---------------------------------------\n");
  
 -	for (mode = 0; mode < M_VESA_MODE_MAX; ++mode) {
 +	for (mode = 0; mode <= M_VESA_MODE_MAX; ++mode) {
  		_info.vi_mode = mode;
  		if (ioctl(0, CONS_MODEINFO, &_info))
  			continue;
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 
>Unformatted:
