From peterjeremy@optushome.com.au  Mon Dec 31 21:08:00 2007
Return-Path: <peterjeremy@optushome.com.au>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1853E16A417
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 31 Dec 2007 21:08:00 +0000 (UTC)
	(envelope-from peterjeremy@optushome.com.au)
Received: from turion.vk2pj.dyndns.org (c220-239-20-82.belrs4.nsw.optusnet.com.au [220.239.20.82])
	by mx1.freebsd.org (Postfix) with ESMTP id 598A213C442
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 31 Dec 2007 21:07:57 +0000 (UTC)
	(envelope-from peterjeremy@optushome.com.au)
Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1])
	by turion.vk2pj.dyndns.org (8.14.2/8.14.2) with ESMTP id lBVL7vwT003900;
	Tue, 1 Jan 2008 08:07:57 +1100 (EST)
	(envelope-from peter@turion.vk2pj.dyndns.org)
Received: (from peter@localhost)
	by turion.vk2pj.dyndns.org (8.14.2/8.14.2/Submit) id lBVL7vMm003899;
	Tue, 1 Jan 2008 08:07:57 +1100 (EST)
	(envelope-from peter)
Message-Id: <200712312107.lBVL7vMm003899@turion.vk2pj.dyndns.org>
Date: Tue, 1 Jan 2008 08:07:57 +1100 (EST)
From: Peter Jeremy <peterjeremy@optushome.com.au>
Reply-To: Peter Jeremy <peterjeremy@optushome.com.au>
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] inetd(8) missing wait/nowait requirement on ONC entries
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         119203
>Category:       bin
>Synopsis:       [patch] inetd(8) missing wait/nowait requirement on ONC entries
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          doc-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 31 21:10:01 UTC 2007
>Closed-Date:    Sat Jan 19 18:02:40 UTC 2008
>Last-Modified:  Sat Jan 19 18:02:40 UTC 2008
>Originator:     Peter Jeremy
>Release:        FreeBSD 6.3-PRERELEASE amd64
>Organization:
n/a
>Environment:
System: FreeBSD turion.vk2pj.dyndns.org 6.3-PRERELEASE FreeBSD 6.3-PRERELEASE #31: Wed Dec 26 09:23:54 EST 2007 root@turion.vk2pj.dyndns.org:/usr/obj/usr/src/sys/turion amd64

>Description:
	The inetd man page does not mention the requirement for a
	wait/nowait column in ONC entries.  The code does require
	this and the sample inetd.conf file includes it.

>How-To-Repeat:
	Code inspection.
	Create inetd.conf entry for ONC service without wait/nowait
	column and [re]start inetd.  This will create a syslog message like:
Jan  1 08:01:46 turion inetd[3795]: /etc/inetd.conf: bad wait/nowait for service rstatd

>Fix:

Index: usr.sbin/inetd/inetd.8
===================================================================
RCS file: /usr/ncvs/src/usr.sbin/inetd/inetd.8,v
retrieving revision 1.81.2.2
diff -u -r1.81.2.2 inetd.8
--- usr.sbin/inetd/inetd.8	29 Apr 2007 19:22:12 -0000	1.81.2.2
+++ usr.sbin/inetd/inetd.8	21 Jun 2007 19:23:57 -0000
@@ -177,6 +177,7 @@
 service-name/version
 socket-type
 rpc/protocol
+{wait|nowait}[/max-child[/max-connections-per-ip-per-minute]]
 user[:group][/login-class]
 server-program
 server-program-arguments
>Release-Note:
>Audit-Trail:

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/119203: commit references a PR
Date: Sat, 12 Jan 2008 21:09:54 +0000 (UTC)

 maxim       2008-01-12 21:09:48 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.sbin/inetd       inetd.8 
   Log:
   o inetd(8) requires wait/nowait column in inetd.conf for
   ONC services as well.
   
   PR:             bin/119203
   Submitted by:   Peter Jeremy
   MFC atfer:      1 week
   
   Revision  Changes    Path
   1.85      +2 -1      src/usr.sbin/inetd/inetd.8
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Sat Jan 12 21:10:03 UTC 2008 
State-Changed-Why:  
Committed to HEAD.  Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119203 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Sat Jan 19 18:02:19 UTC 2008 
State-Changed-Why:  
Merged to RELENG_6 and RELENG_7. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=119203 
>Unformatted:
