From nobody@FreeBSD.org  Wed Nov 28 01:54:53 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 99F6916A417
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Nov 2007 01:54:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 747EB13C45B
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Nov 2007 01:54:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.2/8.14.2) with ESMTP id lAS1skPw092059
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Nov 2007 01:54:46 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.2/8.14.1/Submit) id lAS1skGi092058;
	Wed, 28 Nov 2007 01:54:46 GMT
	(envelope-from nobody)
Message-Id: <200711280154.lAS1skGi092058@www.freebsd.org>
Date: Wed, 28 Nov 2007 01:54:46 GMT
From: Weongyo Jeong <weongyo.jeong@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: ndiscvt(8) makes a syntax error when it processes STRING.
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         118295
>Category:       bin
>Synopsis:       [patch] ndiscvt(8) makes a syntax error when it processes STRING.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 28 02:00:02 UTC 2007
>Closed-Date:    
>Last-Modified:  Wed Jul 03 01:40:18 UTC 2013
>Originator:     Weongyo Jeong
>Release:        FreeBSD 7.0 CURRENT
>Organization:
CDNetworks
>Environment:
FreeBSD freebsd.weongyo.org 7.0-CURRENT FreeBSD 7.0-CURRENT #3: Sun Jun 24 21:47:30 KST 2007     weongyo@bsd.dev1.cdnetworks.co.kr:/usr/obj/usr/src/sys/GENERIC  i386

>Description:
In some INF files, we can meet some texts to define a register key like below

"ENUM\"%ZD1211B_50U_PNP%

It makes a ndiscvt(8)'s syntax error when it parses because \" is treated as a character escape sequence.

>How-To-Repeat:
$ cat > t.inf
[UnZDRegistryUSB.reg]
HKLM,SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\UNZD1211B%InterfaceType%,DEL_HKR_0000,0,"ENUM\"%ZD1211B_50U_PNP%
^D
$ ndiscvt -i t.inf -s ZD11BUXP.SYS -o tmp.h
ndiscvt: line 2: %ZD1211B_50U_PNP%: syntax error.

>Fix:
Index: inf-token.l
===================================================================
RCS file: /data/cvs/src/usr.sbin/ndiscvt/inf-token.l,v
retrieving revision 1.3
diff -u -r1.3 inf-token.l
--- inf-token.l 11 Jan 2004 21:10:35 -0000      1.3
+++ inf-token.l 27 Nov 2007 12:25:53 -0000
@@ -67,7 +67,7 @@
 \/\/.*$                        ;
 =                      { return EQUALS; }
 ,                      { return COMMA; }
-\"(\\\"|[^"]|\"\")*\"  {
+\"([^"]|\"\")*\"       {
                        int len = strlen(yytext) - 2;
                        int blen = len + 1;
                        char *walker;
@@ -94,9 +94,6 @@
                                                while(isspace(yytext[i]))
                                                        i++;
                                                break;
-                                       case '\"':
-                                               i++;
-                                               break;
                                        case '(':
                                                i++;
                                                break;


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->weongyo 
Responsible-Changed-By: thompsa 
Responsible-Changed-When: Fri Dec 28 01:10:36 UTC 2007 
Responsible-Changed-Why:  
Pass back to the new committer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118295 
State-Changed-From-To: open->open 
State-Changed-By: linimon 
State-Changed-When: Wed Jul 3 00:50:32 UTC 2013 
State-Changed-Why:  
commit bit has been taken in for safekeeping. 


Responsible-Changed-From-To: weongyo->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Wed Jul 3 00:50:32 UTC 2013 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=118295 
>Unformatted:
