From moonshade@pnhz.kz  Mon Nov 26 09:43:55 2007
Return-Path: <moonshade@pnhz.kz>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B60E416A419
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Nov 2007 09:43:55 +0000 (UTC)
	(envelope-from moonshade@pnhz.kz)
Received: from relay.pnhz.kz (relay.pnhz.kz [212.154.198.217])
	by mx1.freebsd.org (Postfix) with ESMTP id 0494413C465
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Nov 2007 09:43:54 +0000 (UTC)
	(envelope-from moonshade@pnhz.kz)
Received: from abyss.pnhz.kz (abyss.pnhz.kz [192.168.121.40])
	by relay.pnhz.kz with ESMTP id lAQ9fS1d090911
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 26 Nov 2007 15:41:29 +0600 (ALMT)
	(envelope-from moonshade@pnhz.kz)
Message-Id: <1196070088.89863@abyss.pnhz.kz>
Date: Mon, 26 Nov 2007 15:41:28 +0600
From: "Denis Eremenko <moonshade@pnhz.kz>" <moonshade@pnhz.kz>
To: "FreeBSD gnats submit" <FreeBSD-gnats-submit@freebsd.org>
Subject: bin: more informative error message for install(1)
X-Send-Pr-Version: gtk-send-pr 0.4.8 
X-GNATS-Notify:

>Number:         118260
>Category:       bin
>Synopsis:       bin: more informative error message for install(1)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 26 09:50:04 UTC 2007
>Closed-Date:    Fri Nov 02 22:19:32 UTC 2012
>Last-Modified:  Fri Nov 02 22:19:32 UTC 2012
>Originator:     Denis Eremenko <moonshade@pnhz.kz>
>Release:        FreeBSD 6.3-PRERELEASE i386
>Organization:
>Environment:


System: FreeBSD 6.3-PRERELEASE #0: Mon Nov 19 17:10:51 ALMT 2007
    moonshade@abyss.pnhz.kz:/usr/obj/data/os/FreeBSD/src/6/src/sys/ABYSS-6



>Description:


More informative error message for install(1) in "install file1 ... fileN directory" case.

Originally it says "wrong number or types of arguments" and it takes
some time to understand that "directory" is simply missing.

>How-To-Repeat:

>Fix:

--- patch-xinstall begins here ---
--- xinstall.c.orig	2007-11-26 14:57:23.000000000 +0600
+++ xinstall.c	2007-11-26 15:22:38.000000000 +0600
@@ -216,7 +216,7 @@
 
 	/* can't do file1 file2 directory/file */
 	if (argc != 2) {
-		warnx("wrong number or types of arguments");
+		warnx("wrong number or types of arguments, target does not exist or not a directory");
 		usage();
 	}
 
--- patch-xinstall ends here ---



>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->edwin 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Wed Nov 28 00:08:48 UTC 2007 
Responsible-Changed-Why:  
I'll handle it with my mentor. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118260 

From: Edwin Groothuis <edwin@mavetju.org>
To: FreeBSD Gnats Submit <freebsd-gnats-submit@freebsd.org>,
	grog@freebsd.org
Cc:  
Subject: Re: bin/118260: bin: more informative error message for install(1)
Date: Wed, 5 Dec 2007 13:24:39 +1100

 Greg, is this one better?
 
 --- /usr/src/usr.bin/xinstall/xinstall.c	Wed Jan 26 01:34:57 2005
 +++ xinstall.c	Wed Dec  5 10:53:11 2007
 @@ -216,7 +216,12 @@
  
  	/* can't do file1 file2 directory/file */
  	if (argc != 2) {
 -		warnx("wrong number or types of arguments");
 +		if (no_target)
 +			warnx("target directory `%s' does not exist",
 +			    argv[argc - 1]);
 +		else
 +			warnx("target `%s' is not a directory",
 +			    argv[argc - 1]);
  		usage();
  	}
  
 
 -- 
 Edwin Groothuis      |            Personal website: http://www.mavetju.org
 edwin@mavetju.org    |              Weblog: http://www.mavetju.org/weblog/
State-Changed-From-To: open->patched 
State-Changed-By: edwin 
State-Changed-When: Fri Dec 14 08:47:01 UTC 2007 
State-Changed-Why:  
Commited to HEAD 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118260 
Responsible-Changed-From-To: edwin->freebsd-bugs 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Feb 14 10:34:20 UTC 2008 
Responsible-Changed-Why:  

Give back into the pool until later. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118260 
State-Changed-From-To: patched->closed 
State-Changed-By: eadler 
State-Changed-When: Fri Nov 2 22:19:31 UTC 2012 
State-Changed-Why:  
MFCed/fixed by now 

http://www.freebsd.org/cgi/query-pr.cgi?pr=118260 
>Unformatted:
