From danny@cs.huji.ac.il  Fri Oct 26 07:31:24 2007
Return-Path: <danny@cs.huji.ac.il>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E961216A420
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 26 Oct 2007 07:31:24 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from cs1.cs.huji.ac.il (cs1.cs.huji.ac.il [132.65.16.10])
	by mx1.freebsd.org (Postfix) with ESMTP id A0F8D13C4CA
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 26 Oct 2007 07:31:24 +0000 (UTC)
	(envelope-from danny@cs.huji.ac.il)
Received: from sunfire.cs.huji.ac.il ([132.65.16.80])
	by cs1.cs.huji.ac.il with esmtp
	id 1IlJf8-000FbJ-Je
	for FreeBSD-gnats-submit@freebsd.org; Fri, 26 Oct 2007 09:31:22 +0200
Received: from danny by sunfire.cs.huji.ac.il with local (Exim 4.68 (FreeBSD))
	(envelope-from <danny@cs.huji.ac.il>)
	id 1IlJf8-0009W2-Ip
	for FreeBSD-gnats-submit@freebsd.org; Fri, 26 Oct 2007 09:31:22 +0200
Message-Id: <E1IlJf8-0009W2-Ip@sunfire.cs.huji.ac.il>
Date: Fri, 26 Oct 2007 09:31:22 +0200
From: Danny Braniss <danny@cs.huji.ac.il>
Reply-To: Danny Braniss <danny@cs.huji.ac.il>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: csup not-really-equivalent to cvsup
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         117520
>Category:       bin
>Synopsis:       [patch] csup(1) not-really-equivalent to cvsup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 26 07:40:01 UTC 2007
>Closed-Date:    Sat Sep 15 23:43:22 UTC 2012
>Last-Modified:  Sat Sep 15 23:43:22 UTC 2012
>Originator:     Danny Braniss
>Release:        FreeBSD 7.0-BETA1 amd64
>Organization:
>Environment:
System: FreeBSD sunfire 7.0-BETA1 FreeBSD 7.0-BETA1 #1: Sat Oct 20 16:30:43 IST 2007 danny@sunfire:/r+d/obj/sunfire/r+d/7.0/src/sys/HUJI amd64


	
>Description:
	csup parses strings differently than cvsup
>How-To-Repeat:
	this works ok with cvsup, but not with csup
	     *default prefix=/r+d/releng_7
>Fix:
	suggested fix to accept quoted string, which is definitly incomplete
	but shows the way.

--- /r+d/7.0/src/contrib/csup/token.l   2006-03-14 05:51:10.000000000 +0200
+++ /cs/system/danny/src/csup/token.l   2007-10-26 09:22:47.815207000 +0200
@@ -67,6 +67,13 @@
                                err(1, "strdup");
                          return STRING;
                        }
+\"[^\"\n]+\"   {
+                         yylval.str = strdup(yytext+1);
+                         if (yylval.str == NULL)
+                               err(1, "strdup");
+                         yylval.str[strlen(yylval.str)-1]='\0';
+                         return STRING;
+                       }
 \n                     lineno++;
 
 %%

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->mux 
Responsible-Changed-By: remko 
Responsible-Changed-When: Fri Oct 26 07:42:21 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117520 
State-Changed-From-To: open->open 
State-Changed-By: linimon 
State-Changed-When: Thu Jun 23 18:05:33 UTC 2011 
State-Changed-Why:  
mux has returned his commit bit for safekeeping. 


Responsible-Changed-From-To: mux->freebsd-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Thu Jun 23 18:05:33 UTC 2011 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=117520 
State-Changed-From-To: open->closed 
State-Changed-By: eadler 
State-Changed-When: Sat Sep 15 23:43:20 UTC 2012 
State-Changed-Why:  
looks like a similar patch was committed some time ago 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117520 
>Unformatted:
