From nobody@FreeBSD.org  Tue Oct 23 21:58:34 2007
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 25B2816A417
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Oct 2007 21:58:34 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21])
	by mx1.freebsd.org (Postfix) with ESMTP id 2572B13C48A
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Oct 2007 21:58:34 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.14.1/8.14.1) with ESMTP id l9NLw8gm045904
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 23 Oct 2007 21:58:08 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.14.1/8.14.1/Submit) id l9NLw8A6045900;
	Tue, 23 Oct 2007 21:58:08 GMT
	(envelope-from nobody)
Message-Id: <200710232158.l9NLw8A6045900@www.freebsd.org>
Date: Tue, 23 Oct 2007 21:58:08 GMT
From: Bruce Cran <bruce@cran.org.uk>
To: freebsd-gnats-submit@FreeBSD.org
Subject: typo in netstat/sctp.c
X-Send-Pr-Version: www-3.1
X-GNATS-Notify:

>Number:         117433
>Category:       bin
>Synopsis:       [SCTP]: typo in netstat/sctp.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rrs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 23 22:00:02 UTC 2007
>Closed-Date:    Wed Apr 16 17:43:07 UTC 2008
>Last-Modified:  Wed Apr 16 17:43:07 UTC 2008
>Originator:     Bruce Cran
>Release:        7.0-PRERELEASE
>Organization:
>Environment:
FreeBSD tau.draftnet 7.0-PRERELEASE FreeBSD 7.0-PRERELEASE #3: Tue Oct 23 21:32:28 BST 2007 brucec@tau.draftnet:/usr/obj/usr/src/sys/MYKERNEL i386
>Description:
There's a typo in netstat/sctp.c - "max burst dosn't allow sending". 
There are also a couple of lines in the SCTP statistics that end with a full stop while none of the other lines do.
>How-To-Repeat:
Run "netstat -s"
>Fix:


Patch attached with submission follows:

--- sctp.c	2007-10-23 22:44:39.000000000 +0100
+++ sctp.c.new	2007-10-23 22:46:14.000000000 +0100
@@ -563,7 +563,7 @@
 	p(sctps_sendretransdata, "\t\t%ju retran%smitted DATA chunks\n");
 	p(sctps_sendfastretrans, "\t\t%ju fa%st retransmitted DATA chunks\n");
 	p(sctps_sendmultfastretrans, "\t\t%ju FR'%s that happened more "
-	    "than once to same chunk.\n");
+	    "than once to same chunk\n");
 	p(sctps_sendheartbeat, "\t\t%ju intput HB chunk%s\n");
 	p(sctps_sendecne, "\t\t%ju output ECNE chunk%s\n");
 	p(sctps_sendauth, "\t\t%ju output AUTH chunk%s\n");
@@ -645,12 +645,12 @@
 #endif
 	p(sctps_naglesent, "\t%ju RFC813 allowed %sending\n");
 	p(sctps_naglequeued, "\t%ju RFC813 doe%s not allow sending\n");
-	p(sctps_maxburstqueued, "\t%ju max bur%st dosn't allow sending\n");
+	p(sctps_maxburstqueued, "\t%ju max bur%st doesn't allow sending\n");
 	p(sctps_ifnomemqueued, "\t%ju look ahead tell%s us no memory in "
 	    "interface\n");
 	p(sctps_windowprobed, "\t%ju numbers of window probe%s sent\n");
 	p(sctps_lowlevelerr, "\t%ju time%s an output error to clamp "
-	    "down on next user send.\n");
+	    "down on next user send\n");
 	p(sctps_lowlevelerrusr, "\t%ju time%s sctp_senderrors were "
 	    "caused from a user\n");
 	p(sctps_datadropchklmt, "\t%ju number of in data drop%s due to "
@@ -660,7 +660,7 @@
 	p(sctps_ecnereducedcwnd, "\t%ju time%s a ECN reduced "
 	    "the cwnd\n");
 	p(sctps_vtagexpress, "\t%ju u%sed express lookup via vtag\n");
-	p(sctps_vtagbogus, "\t%ju colli%sion in express lookup.\n");
+	p(sctps_vtagbogus, "\t%ju colli%sion in express lookup\n");
 	p(sctps_primary_randry, "\t%ju time%s the sender ran dry "
 	    "of user data on primary\n");
 	p1a(sctps_cmt_randry, "\t%ju same for above\n");


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->rrs 
Responsible-Changed-By: remko 
Responsible-Changed-When: Wed Oct 24 06:17:49 UTC 2007 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=117433 

From: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/117433: typo in netstat/sctp.c
Date: Wed, 24 Oct 2007 07:22:01 +0000 (UTC)

 On Tue, 23 Oct 2007, Bruce Cran wrote:
 
 > Patch attached with submission follows:
 >
 > -	p(sctps_maxburstqueued, "\t%ju max bur%st dosn't allow sending\n");
 > +	p(sctps_maxburstqueued, "\t%ju max bur%st doesn't allow sending\n");
 
 while on this, if width allows you might even want to consider to write
 "does not".
 
 Yeah I know that we also have "can't" instead of "cannot", etc... but
 we can at least try;-)
 
 
 -- 
 Bjoern A. Zeeb                                 bzeeb at Zabbadoz dot NeT
 Software is harder than hardware  so better get it right the first time.
State-Changed-From-To: open->closed 
State-Changed-By: rrs 
State-Changed-When: Wed Apr 16 17:42:17 UTC 2008 
State-Changed-Why:  
My commit from yesterday fixes this in Current. I will 
MFC it into Release_7 next week. For 7.0 a patch is available 
on http://www.sctp.org 


http://www.freebsd.org/cgi/query-pr.cgi?pr=117433 
>Unformatted:
