From root@amigo.faf.fa.disney.com Thu May 13 09:45:07 1999
Return-Path: <root@amigo.faf.fa.disney.com>
Received: from mail.disney.com (mail.disney.com [204.128.192.15])
	by hub.freebsd.org (Postfix) with ESMTP id 551B414C47
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 13 May 1999 09:44:34 -0700 (PDT)
	(envelope-from root@amigo.faf.fa.disney.com)
Received: from pain10.corp.disney.com (root@pain10.corp.disney.com [153.7.110.100])
	by mail.disney.com (8.9.1/8.9.1) with SMTP id JAA10550
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 13 May 1999 09:44:30 -0700 (PDT)
Received: from louie.fa.disney.com by pain.corp.disney.com with ESMTP; Thu, 13 May 1999 09:43:45 -0700
Received: from snowhite.faf.fa.disney.com (snowhite.faf.fa.disney.com [153.7.115.1])
	by louie.fa.disney.com (8.9.2/8.9.2) with ESMTP id JAA10869
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 13 May 1999 09:44:29 -0700 (PDT)
Received: from amigo.faf.fa.disney.com (amigo.faf.fa.disney.com [153.7.115.230])
	by snowhite.faf.fa.disney.com (8.9.2/8.9.2) with ESMTP id MAA05650
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 13 May 1999 12:44:27 -0400 (EDT)
	(envelope-from root@amigo.faf.fa.disney.com)
Received: (from root@localhost)
	by amigo.faf.fa.disney.com (8.9.2/8.9.2) id MAA68220;
	Thu, 13 May 1999 12:44:28 -0400 (EDT)
	(envelope-from root@amigo.faf.fa.disney.com)
Message-Id: <199905131644.MAA68220@amigo.faf.fa.disney.com>
Date: Thu, 13 May 1999 12:44:28 -0400 (EDT)
From: Jim.Pirzyk@disney.com
Sender: root@amigo.faf.fa.disney.com
Reply-To: Jim.Pirzyk@disney.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: Bug in command 'atm show arp' 
X-Send-Pr-Version: 3.2

>Number:         11691
>Category:       bin
>Synopsis:       'atm show arp' has ATM addresses in wrong byte order for SPANS
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 13 09:50:00 PDT 1999
>Closed-Date:    Mon May 24 11:48:54 PDT 1999
>Last-Modified:  Mon May 24 11:56:54 PDT 1999
>Originator:     Jim Pirzyk
>Release:        FreeBSD 3.1-RELEASE i386
>Organization:
>Environment:

A FreeBSD host running SPANS atm.  Need to have mutiple atm hosts connected
to the same atm switch and VCs already established to those hosts.

>Description:

When doing an 'atm show arp' while running SPANS signaling manager, the 
ATM address is not being displayed in the correct order.  This is different
than the order being displayed by the SPANS signaling modules in the kernel.

The good order is by the spans_addr_print in 
/usr/src/sys/netatm/spans/spans_util.c  

The bad code is in:
/usr/src/lib/libatm/atm_addr.c

>How-To-Repeat:

run the 'atm show arp' on the command line.  Then grep for SPANS in
/var/log/messages and look at the two atm addresses, they should start
in the same order.

>Fix:
	
*** atm_addr.c.orig	Tue Sep 15 04:22:33 1998
--- atm_addr.c	Thu May 13 12:35:13 1999
***************
*** 305,311 ****
  		u2.c[3] = atm_spans->aas_addr[7];
  
  		if (!(u1.w == 0 && u2.w == 0))
! 			sprintf(str, "0x%08x.%08x", u1.w, u2.w);
  		break;
  
  	case T_ATM_PVC_ADDR:
--- 305,311 ----
  		u2.c[3] = atm_spans->aas_addr[7];
  
  		if (!(u1.w == 0 && u2.w == 0))
! 			sprintf(str, "0x%08x.%08x", ntohl(u1.w), ntohl(u2.w));
  		break;
  
  	case T_ATM_PVC_ADDR:

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: mks 
State-Changed-When: Mon May 24 11:48:54 PDT 1999 
State-Changed-Why:  
Fix applied - atm_addr.c rev 1.2 
>Unformatted:
