From Cy.Schubert@komquats.com  Wed Oct  3 00:52:59 2007
Return-Path: <Cy.Schubert@komquats.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DF5E416A41A
	for <FreeBSD-gnats-submit@FreeBSD.org>; Wed,  3 Oct 2007 00:52:59 +0000 (UTC)
	(envelope-from Cy.Schubert@komquats.com)
Received: from pd2mo1so.prod.shaw.ca (idcmail-mo1so.shaw.ca [24.71.223.10])
	by mx1.freebsd.org (Postfix) with ESMTP id C20CE13C45D
	for <FreeBSD-gnats-submit@FreeBSD.org>; Wed,  3 Oct 2007 00:52:59 +0000 (UTC)
	(envelope-from Cy.Schubert@komquats.com)
Received: from pd4mr4so.prod.shaw.ca
 (pd4mr4so-qfe3.prod.shaw.ca [10.0.141.215]) by l-daemon
 (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004))
 with ESMTP id <0JPB00MOP68L8Y10@l-daemon> for
 FreeBSD-gnats-submit@FreeBSD.org; Tue, 02 Oct 2007 17:50:45 -0600 (MDT)
Received: from pn2ml1so.prod.shaw.ca ([10.0.121.145])
 by pd4mr4so.prod.shaw.ca (Sun Java System Messaging Server 6.2-7.05 (built Sep
 5 2006)) with ESMTP id <0JPB00DWG68JSQ30@pd4mr4so.prod.shaw.ca> for
 FreeBSD-gnats-submit@FreeBSD.org; Tue, 02 Oct 2007 17:50:43 -0600 (MDT)
Received: from spqr.komquats.com ([24.68.216.215])
 by l-daemon (Sun ONE Messaging Server 6.0 HotFix 1.01 (built Mar 15 2004))
 with ESMTP id <0JPB00FNH68I19U1@l-daemon> for
 FreeBSD-gnats-submit@FreeBSD.org; Tue, 02 Oct 2007 17:50:42 -0600 (MDT)
Received: from cwsys.cwsent.com (cwsys [10.1.1.1])
	by spqr.komquats.com (Postfix) with ESMTP id 48870279C2	for
 <FreeBSD-gnats-submit@FreeBSD.org>; Tue, 02 Oct 2007 16:50:38 -0700 (PDT)
Received: from cwsys.cwsent.com (localhost [127.0.0.1])
	by cwsys.cwsent.com (8.14.1/8.14.1) with ESMTP id l92NobhY030742	for
 <FreeBSD-gnats-submit@FreeBSD.org>; Tue, 02 Oct 2007 16:50:37 -0700
Received: (from cy@localhost)	by cwsys.cwsent.com (8.14.1/8.13.1/Submit)
 id l92Nobww030741; Tue, 02 Oct 2007 16:50:37 -0700 (PDT envelope-from cy)
Message-Id: <200710022350.l92Nobww030741@cwsys.cwsent.com>
Date: Tue, 02 Oct 2007 16:50:37 -0700 (PDT)
From: Cy Schubert <cy@FreeBSD.org>
Reply-To: Cy Schubert <cy@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:
Subject: dump(8) fails to dump UFS filesystems when nullfs filesyste present
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         116849
>Category:       bin
>Synopsis:       [patch] dump(8) fails to dump UFS filesystems when nullfs filesyste present
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    cy
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 03 01:00:03 GMT 2007
>Closed-Date:    Mon Mar 02 03:09:23 UTC 2009
>Last-Modified:  Mon Mar  2 04:20:02 UTC 2009
>Originator:     Cy Schubert
>Release:        FreeBSD-2.0
>Organization:
FreeBSD
>Environment:
System: FreeBSD bob 6.2-STABLE FreeBSD 6.2-STABLE #3: Thu Sep 27 16:38:11 PDT 2007 root@cwsys:/export/obj/opt/src/cvs-stable6/src/sys/KOMQUATS i386


>Description:
Example fstab:

/dev/ad3s1g             /dsk01          ufs     rw 1 2
    [...]
/dsk01                  /stable5/dsk01          nullfs  rw,noauto 0 0

# dump 0f /dev/null /dsk01
dump: unknown filesystem /dsk01
#

>How-To-Repeat:
See above
>Fix:

--- sbin/dump/optr.c.orig	2005-02-15 22:48:35.000000000 -0800
+++ sbin/dump/optr.c	2007-10-02 16:33:26.000000000 -0700
@@ -315,9 +315,10 @@
 		return;
 	}
 	while ((fs = getfsent()) != NULL) {
-		if (strcmp(fs->fs_type, FSTAB_RW) &&
+		if ((strcmp(fs->fs_type, FSTAB_RW) &&
 		    strcmp(fs->fs_type, FSTAB_RO) &&
-		    strcmp(fs->fs_type, FSTAB_RQ))
+		    strcmp(fs->fs_type, FSTAB_RQ)) ||
+		    strcmp(fs->fs_vfstype, "ufs"))
 			continue;
 		fs = allocfsent(fs);
 		if ((pf = (struct pfstab *)malloc(sizeof (*pf))) == NULL)


>Release-Note:
>Audit-Trail:

From: "Stephen Hurd" <shurd@broadcom.com>
To: "bug-followup@FreeBSD.org" <bug-followup@FreeBSD.org>,
	"cy@FreeBSD.org" <cy@FreeBSD.org>
Cc:  
Subject: Re: bin/116849: [patch] dump(8) fails to dump UFS filesystems
 when nullfs filesyste present
Date: Fri, 27 Feb 2009 16:03:53 -0800

 --_000_1BB65751E91EA64EA8436124B779A8BC3FA05F1EA2IRVEXCHCCR01c_
 Content-Type: text/plain;
  charset=us-ascii
 Content-Transfer-Encoding: quoted-printable
 
 Still there in 7.1 and there's a patch... ping?
 
 --_000_1BB65751E91EA64EA8436124B779A8BC3FA05F1EA2IRVEXCHCCR01c_
 Content-Type: text/html;
  charset=us-ascii
 Content-Transfer-Encoding: quoted-printable
 
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
 <HTML><HEAD>
 <META http-equiv=3DContent-Type content=3D"text/html; charset=3Dus-ascii">
 <META content=3D"MSHTML 6.00.6000.16788" name=3DGENERATOR></HEAD>
 <BODY>
 <DIV><SPAN class=3D414130200-28022009><FONT face=3DArial size=3D2>Still the=
 re in 7.1=20
 and there's a patch... ping?</FONT></SPAN></DIV></BODY></HTML>
 
 --_000_1BB65751E91EA64EA8436124B779A8BC3FA05F1EA2IRVEXCHCCR01c_--
 

From: Cy Schubert <Cy.Schubert@komquats.com>
To: "Stephen Hurd" <shurd@broadcom.com>
Cc: "bug-followup@FreeBSD.org" <bug-followup@FreeBSD.org>,
        "cy@FreeBSD.org" <cy@FreeBSD.org>
Subject: Re: bin/116849: [patch] dump(8) fails to dump UFS filesystems when 
 nullfs filesyste present
Date: Sat, 28 Feb 2009 07:52:08 -0800

 In message <1BB65751E91EA64EA8436124B779A8BC3FA05F1EA2@IRVEXCHCCR01.corp.ad.
 bro
 adcom.com>, "Stephen Hurd" writes:
 > Still there in 7.1 and there's a patch... ping?
 
 No one has picked this PR up. As I'm a ports committer, not a src 
 committer, I'll need to find someone to champion this for us for find 
 someone to mentor me in the src tree.
 
 
 -- 
 Cheers,
 Cy Schubert <Cy.Schubert@komquats.com>
 FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org
 
 			e**(i*pi)+1=0
 
 
Responsible-Changed-From-To: freebsd-bugs->cy-bugs 
Responsible-Changed-By: cy 
Responsible-Changed-When: Mon Mar 2 02:52:00 UTC 2009 
Responsible-Changed-Why:  
kib has given me approval to commit this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116849 
Responsible-Changed-From-To: cy-bugs->cy 
Responsible-Changed-By: cy 
Responsible-Changed-When: Mon Mar 2 02:57:52 UTC 2009 
Responsible-Changed-Why:  
Fix typo as to my id from from cy-bugs to cy. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116849 
State-Changed-From-To: open->closed 
State-Changed-By: cy 
State-Changed-When: Mon Mar 2 03:09:00 UTC 2009 
State-Changed-Why:  
Committed with the approval of kib. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116849 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/116849: commit references a PR
Date: Mon,  2 Mar 2009 03:09:02 +0000 (UTC)

 Author: cy (ports committer)
 Date: Mon Mar  2 03:08:46 2009
 New Revision: 189267
 URL: http://svn.freebsd.org/changeset/base/189267
 
 Log:
   Verify that the filesystem being referenced in fstab is indeed a UFS
   filesystem. This avoids confusion with nullfs and unionfs filesystems
   which reference the root of a UFS filesystem as a target.
   
   PR:		116849
   Approved by:	kib
 
 Modified:
   head/sbin/dump/optr.c
 
 Modified: head/sbin/dump/optr.c
 ==============================================================================
 --- head/sbin/dump/optr.c	Mon Mar  2 02:51:52 2009	(r189266)
 +++ head/sbin/dump/optr.c	Mon Mar  2 03:08:46 2009	(r189267)
 @@ -318,9 +318,10 @@ dump_getfstab(void)
  		return;
  	}
  	while ((fs = getfsent()) != NULL) {
 -		if (strcmp(fs->fs_type, FSTAB_RW) &&
 +		if ((strcmp(fs->fs_type, FSTAB_RW) &&
  		    strcmp(fs->fs_type, FSTAB_RO) &&
 -		    strcmp(fs->fs_type, FSTAB_RQ))
 +		    strcmp(fs->fs_type, FSTAB_RQ)) ||
 +		    strcmp(fs->fs_vfstype, "ufs"))
  			continue;
  		fs = allocfsent(fs);
  		if ((pf = (struct pfstab *)malloc(sizeof (*pf))) == NULL)
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 

From: Cy Schubert <Cy.Schubert@komquats.com>
To: "Stephen Hurd" <shurd@broadcom.com>
Cc: "bug-followup@FreeBSD.org" <bug-followup@FreeBSD.org>,
        "cy@FreeBSD.org" <cy@FreeBSD.org>, kib@FreeBSD.org
Subject: Re: bin/116849: [patch] dump(8) fails to dump UFS filesystems when 
 nullfs filesyste present
Date: Sun, 01 Mar 2009 20:10:15 -0800

 In message <1BB65751E91EA64EA8436124B779A8BC3FA05F1EA2@IRVEXCHCCR01.corp.ad.
 bro
 adcom.com>, "Stephen Hurd" writes:
 > Still there in 7.1 and there's a patch... ping?
 
 Hi Stephen,
 
 I've committed the patch to head (8.0-CURRENT) with the permission of kib@. I expect it to mature there for a while before it's merged into stable/7.
 
 Thanks for reminding us of the patch. Even though I've had it running on my systems since October 2007 and as I use an automated patch application script during my build process here at home and at work, I forgot about it (that's how well my automated patch script works -- fire and forget kind of thing). Anyhow, it's in.
 
 
 -- 
 Cheers,
 Cy Schubert <Cy.Schubert@komquats.com>
 FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org
 
 			e**(i*pi)+1=0
 
 
>Unformatted:
