From pirzyk@lilo.cites.uiuc.edu  Tue Sep 25 22:46:04 2007
Return-Path: <pirzyk@lilo.cites.uiuc.edu>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 026B516A419
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Sep 2007 22:46:04 +0000 (UTC)
	(envelope-from pirzyk@lilo.cites.uiuc.edu)
Received: from lilo.cites.uiuc.edu (lilo.cites.uiuc.edu [128.174.204.16])
	by mx1.freebsd.org (Postfix) with ESMTP id AD4F213C44B
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Sep 2007 22:46:03 +0000 (UTC)
	(envelope-from pirzyk@lilo.cites.uiuc.edu)
Received: from lilo.cites.uiuc.edu (localhost [127.0.0.1])
	by lilo.cites.uiuc.edu (8.13.8/8.13.8) with ESMTP id l8PMJHA2039535
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 25 Sep 2007 17:19:17 -0500 (CDT)
	(envelope-from pirzyk@lilo.cites.uiuc.edu)
Received: (from root@localhost)
	by lilo.cites.uiuc.edu (8.13.8/8.13.8/Submit) id l8PMJHbi039534;
	Tue, 25 Sep 2007 17:19:17 -0500 (CDT)
	(envelope-from pirzyk)
Message-Id: <200709252219.l8PMJHbi039534@lilo.cites.uiuc.edu>
Date: Tue, 25 Sep 2007 17:19:17 -0500 (CDT)
From: Jim Pirzyk <pirzyk@freebsd.org>
Reply-To: Jim Pirzyk <pirzyk@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: syslogd bug
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         116642
>Category:       bin
>Synopsis:       [patch] syslogd(8) bug
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 25 22:50:01 GMT 2007
>Closed-Date:    Wed Feb 20 21:55:55 UTC 2008
>Last-Modified:  Tue Jul 10 03:39:44 UTC 2012
>Originator:     Jim Pirzyk
>Release:        FreeBSD 6.2-RELEASE-p4 i386
>Organization:
>Environment:
System: FreeBSD lilo.cites.uiuc.edu 6.2-RELEASE-p4 FreeBSD 6.2-RELEASE-p4 #0: Thu Apr 26 17:40:53 UTC 2007 root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386


	
>Description:
	When saving the name of the PIPE, the cfline saves the value to the
	wrong data element in the filed structure.  Since the element in question
	is part of a union and they start in the same place, and are the same
	lenth, this does not cause any program issues.  If those two constraints
	are relaxed, it will cause a problem.

>How-To-Repeat:
	
>Fix:

--- ./syslogd.c.orig	Thu Jun 29 16:22:30 2006
+++ syslogd.c	Tue Sep 25 17:15:29 2007
@@ -1941,7 +1941,7 @@
 
 	case '|':
 		f->f_un.f_pipe.f_pid = 0;
-		(void)strlcpy(f->f_un.f_fname, p + 1, sizeof(f->f_un.f_fname));
+		(void)strlcpy(f->f_un.f_pipe.f_pname, p + 1, sizeof(f->f_un.f_pipe.f_pname));
 		f->f_type = F_PIPE;
 		break;
 
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->dwmalone 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Wed Feb 20 09:46:28 UTC 2008 
Responsible-Changed-Why:  
I'll have a look at this one. 

David. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116642 
State-Changed-From-To: open->closed 
State-Changed-By: dwmalone 
State-Changed-When: Wed Feb 20 21:55:27 UTC 2008 
State-Changed-Why:  
Fixed in -current - thanks for the patch Jim. 

David. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116642 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: bin/116642: commit references a PR
Date: Wed, 20 Feb 2008 21:54:45 +0000 (UTC)

 dwmalone    2008-02-20 21:54:41 UTC
 
   FreeBSD src repository
 
   Modified files:
     usr.sbin/syslogd     syslogd.c 
   Log:
   Two no-op fixes to improve corretness of syslogd code:
   
   1) Use [AP]F_LOCAL rather than [AP]F_UNIX.
   2) When copying a pipe's name, use f->f_un.f_pipe.f_pname, not f->f_un.f_fname.
   
   PR:             20889
   Submitted by:   Damieon Stark
   PR:             116642
   Submitted by:   Jim Pirzyk
   Reviewed by:    md5
   
   Revision  Changes    Path
   1.155     +4 -3      src/usr.sbin/syslogd/syslogd.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
Responsible-Changed-From-To: dwmalone->freebsd-bugs 
Responsible-Changed-By: eadler 
Responsible-Changed-When: Tue Jul 10 03:39:43 UTC 2012 
Responsible-Changed-Why:  
over to the pool (approved by bugmeister) 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116642 
>Unformatted:
