From brix@lothlorien.brixandersen.dk  Mon Sep 24 13:11:04 2007
Return-Path: <brix@lothlorien.brixandersen.dk>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 51D8916A41A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Sep 2007 13:11:04 +0000 (UTC)
	(envelope-from brix@lothlorien.brixandersen.dk)
Received: from solow.pil.dk (relay.pil.dk [195.41.47.164])
	by mx1.freebsd.org (Postfix) with ESMTP id 0AD8F13C44B
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Sep 2007 13:11:03 +0000 (UTC)
	(envelope-from brix@lothlorien.brixandersen.dk)
Received: from lothlorien.brixandersen.dk (osgiliath.brixandersen.dk [87.53.223.189])
	by solow.pil.dk (Postfix) with ESMTP id 8BF4D1CC0D2;
	Mon, 24 Sep 2007 15:11:02 +0200 (CEST)
Received: by lothlorien.brixandersen.dk (Postfix, from userid 1001)
	id 9340311428; Mon, 24 Sep 2007 15:11:00 +0200 (CEST)
Message-Id: <20070924131100.9340311428@lothlorien.brixandersen.dk>
Date: Mon, 24 Sep 2007 15:11:00 +0200 (CEST)
From: Henrik Brix Andersen <henrik@brixandersen.dk>
Reply-To: Henrik Brix Andersen <henrik@brixandersen.dk>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Sam Leffler <sam@FreeBSD.org>
Subject: [patch] Enable history support in wpa_cli(8)
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         116606
>Category:       bin
>Synopsis:       [patch] Enable history support in wpa_cli(8)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sam
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 24 13:20:02 GMT 2007
>Closed-Date:    Tue Dec 30 17:52:38 UTC 2008
>Last-Modified:  Tue Dec 30 17:52:38 UTC 2008
>Originator:     Henrik Brix Andersen
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD lothlorien.brixandersen.dk 7.0-CURRENT FreeBSD 7.0-CURRENT #73: Mon Sep 24 14:11:27 CEST 2007 root@lothlorien.brixandersen.dk:/usr/obj/usr/src/sys/LOTHLORIEN i386


	
>Description:
Enable history support (e.g. arrow-up for last command) in wpa_cli(8).

	
>How-To-Repeat:
	
>Fix:

	

--- wpa_cli.diff begins here ---
--- usr.sbin/wpa/wpa_cli/Makefile.orig	2007-09-24 14:24:52.000000000 +0200
+++ usr.sbin/wpa/wpa_cli/Makefile	2007-09-24 14:26:18.000000000 +0200
@@ -11,4 +11,8 @@ MAN=	wpa_cli.8
 CFLAGS+= -DCONFIG_CTRL_IFACE
 CFLAGS+= -DCONFIG_CTRL_IFACE_UNIX
 
+CFLAGS+= -DCONFIG_READLINE
+DPADD+= ${LIBNCURSES} ${LIBREADLINE}
+LDADD+= -lncurses -lreadline
+
 .include <bsd.prog.mk>
--- wpa_cli.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->sam 
Responsible-Changed-By: remko 
Responsible-Changed-When: Mon Sep 24 13:52:02 UTC 2007 
Responsible-Changed-Why:  
WPA stuff is something for you I think, can you have a look at this 
please? 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116606 
State-Changed-From-To: open->feedback 
State-Changed-By: sam 
State-Changed-When: Mon Oct 15 18:55:18 UTC 2007 
State-Changed-Why:  
I'd prefer to make this optional and not default as libreadline is quite large; 
will look at this after 7.0 ships unless you update with a different patch 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116606 

From: Henrik Brix Andersen <henrik@brixandersen.dk>
To: bug-followup@FreeBSD.org, sam@FreeBSD.org
Cc:  
Subject: Re: bin/116606: [patch] Enable history support in wpa_cli(8)
Date: Tue, 16 Oct 2007 00:08:38 +0200

 On Mon, Oct 15, 2007 at 06:56:32PM +0000, sam@FreeBSD.org wrote:
 > I'd prefer to make this optional and not default as libreadline is
 > quite large; will look at this after 7.0 ships unless you update
 > with a different patch
 
 Point taken, how about this patch? It makes it possible to disable
 libreadline support in wpa_cli(8) by defining WITHOUT_GNU_SUPPORT:
 
 --- usr.sbin/wpa/wpa_cli/Makefile.orig	2007-07-11 18:04:07.000000000 +0200
 +++ usr.sbin/wpa/wpa_cli/Makefile	2007-10-16 00:01:51.000000000 +0200
 @@ -1,5 +1,7 @@
  # $FreeBSD: src/usr.sbin/wpa/wpa_cli/Makefile,v 1.3 2007/07/11 16:04:07 sam Exp $
  
 +.include <bsd.own.mk>
 +
  WPA_SUPPLICANT_DISTDIR?= ${.CURDIR}/../../../contrib/wpa_supplicant
  .PATH: ${WPA_SUPPLICANT_DISTDIR}
  
 @@ -11,4 +13,10 @@ MAN=	wpa_cli.8
  CFLAGS+= -DCONFIG_CTRL_IFACE
  CFLAGS+= -DCONFIG_CTRL_IFACE_UNIX
  
 +.if ${MK_GNU_SUPPORT} != "no"
 +DPADD+= ${LIBNCURSES} ${LIBREADLINE}
 +CFLAGS+= -DCONFIG_READLINE
 +LDADD+= -lncurses -lreadline
 +.endif
 +
  .include <bsd.prog.mk>
 
 
 -- 
 Henrik Brix Andersen <henrik@brixandersen.dk>
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Mon Mar 3 07:02:18 UTC 2008 
State-Changed-Why:  
Note that feedback was received some time ago. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116606 
State-Changed-From-To: open->closed 
State-Changed-By: sam 
State-Changed-When: Tue Dec 30 17:51:05 UTC 2008 
State-Changed-Why:  
left this to brix to decide whether or not to commit; users can enable 
history editing w/ local configs so don't see a reason 
to leave the bug open 

http://www.freebsd.org/cgi/query-pr.cgi?pr=116606 
>Unformatted:
