From Andre.Albsmeier@siemens.com  Fri Aug  3 11:15:09 2007
Return-Path: <Andre.Albsmeier@siemens.com>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 014EC16A418
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  3 Aug 2007 11:15:09 +0000 (UTC)
	(envelope-from Andre.Albsmeier@siemens.com)
Received: from thoth.sbs.de (thoth.sbs.de [192.35.17.2])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D7F113C45A
	for <FreeBSD-gnats-submit@freebsd.org>; Fri,  3 Aug 2007 11:15:08 +0000 (UTC)
	(envelope-from Andre.Albsmeier@siemens.com)
Received: from mail3.siemens.de (localhost [127.0.0.1])
	by thoth.sbs.de (8.12.6/8.12.6) with ESMTP id l73Ap1jY006336
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 3 Aug 2007 12:51:01 +0200
Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.40.130])
	by mail3.siemens.de (8.12.6/8.12.6) with ESMTP id l73Ap1OU008594
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 3 Aug 2007 12:51:01 +0200
Received: (from localhost)
	by curry.mchp.siemens.de (8.14.1/8.14.1) id l73Ap1O0091129
	for FreeBSD-gnats-submit@freebsd.org; Fri, 3 Aug 2007 12:51:01 +0200 (CEST)
Message-Id: <200708031051.l73Ap0Bd064476@curry.mchp.siemens.de>
Date: Fri, 3 Aug 2007 12:51:00 +0200 (CEST)
From: Andre Albsmeier <Andre.Albsmeier@siemens.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] add functionality of mount_nfs' -L -a -d options to amd
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         115165
>Category:       bin
>Synopsis:       [PATCH] amd(8): add functionality of mount_nfs' -L -a -d options to amd
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-fs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 03 11:20:07 GMT 2007
>Closed-Date:    Tue Sep 18 12:28:41 GMT 2007
>Last-Modified:  Tue Sep 18 12:28:41 GMT 2007
>Originator:     Andre Albsmeier
>Release:        FreeBSD 6.2-STABLE i386
>Organization:
>Environment:

System: FreeBSD FreeBSD 6.2-STABLE #1: Wed Aug 1 15:06:22 CEST 2007

>Description:

NFS can be tuned very well by using the mount_nfs options mentioned
above. However, currently it is not possible to instruct amd to
use these options when mounting NFS volumes.

>How-To-Repeat:

Try to tell amd to use the options mentioned above.

>Fix:

This patch adds the amd options readahead=X, dumbtimr and nolockd
to amd. It also replaces the patch in PR# 85204 which only adds
the readahead feature.

--- contrib/amd/libamu/mount_fs.c.ORI	2006-04-12 09:02:19.000000000 +0200
+++ contrib/amd/libamu/mount_fs.c	2007-08-03 10:06:27.000000000 +0200
@@ -583,6 +583,20 @@
   nap->flags |= MNT2_NFS_OPT_FSNAME;
 #endif /* MNT2_NFS_OPT_FSNAME */
 
+  nap->readahead = hasmntval(mntp, "readahead");
+#ifdef MNT2_NFS_OPT_READAHEAD
+  if (nap->readahead)
+    nap->flags |= MNT2_NFS_OPT_READAHEAD;
+#endif /* MNT2_NFS_OPT_READAHEAD */
+
+#ifdef MNT2_NFS_OPT_DUMBTIMR
+  if (hasmntopt(mntp, "dumbtimr") != NULL)
+    nap->flags |= MNT2_NFS_OPT_DUMBTIMR;
+#endif /* MNT2_NFS_OPT_DUMBTIMR */
+
+  if (hasmntopt(mntp, "nolockd") != NULL)
+    nap->flags |= NFSMNT_NOLOCKD;
+
   nap->rsize = hasmntval(mntp, MNTTAB_OPT_RSIZE);
 #ifdef MNT2_NFS_OPT_RSIZE
   if (nap->rsize)

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-fs 
Responsible-Changed-By: remko 
Responsible-Changed-When: Fri Aug 3 15:02:07 UTC 2007 
Responsible-Changed-Why:  
this sounds more like something for the fs@ team. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115165 

From: Craig Rodrigues <rodrigc@crodrigues.org>
To: bug-followup@FreeBSD.org, Andre.Albsmeier@siemens.com
Cc:  
Subject: Re: bin/115165: [PATCH] amd(8): add functionality of mount_nfs' -L -a -d options to amd
Date: Sun, 5 Aug 2007 16:37:22 -0400

 Hi,
 
 These changes need to be submitted to the am-utils maintainer,
 since FreeBSD imports the am-utils from:
 
 http://www.am-utils.org/
 
 -- 
 Craig Rodrigues        
 rodrigc@crodrigues.org

From: Andre Albsmeier <Andre.Albsmeier@siemens.com>
To: Craig Rodrigues <rodrigc@crodrigues.org>
Cc: bug-followup@FreeBSD.org, Andre.Albsmeier@siemens.com
Subject: Re: bin/115165: [PATCH] amd(8): add functionality of mount_nfs' -L
	-a -d options to amd
Date: Tue, 7 Aug 2007 09:17:52 +0200

 On Sun, 05-Aug-2007 at 16:37:22 -0400, Craig Rodrigues wrote:
 > Hi,
 > 
 > These changes need to be submitted to the am-utils maintainer,
 > since FreeBSD imports the am-utils from:
 > 
 > http://www.am-utils.org/
 
 Done, https://bugzilla.fsl.cs.sunysb.edu/show_bug.cgi?id=582
State-Changed-From-To: open->closed 
State-Changed-By: matteo 
State-Changed-When: Tue Sep 18 12:28:15 UTC 2007 
State-Changed-Why:  
Bug was submitted to upstream maintainer, so no need to keep it open here 

http://www.freebsd.org/cgi/query-pr.cgi?pr=115165 
>Unformatted:
